meh. | 17 Jun 2012 17:41
Gravatar

[PATCH] ui: add support for color attributes

I don't know if this patch is wanted, if it isn't it's not a problem,
I will just maintain a repo on github with my patches.

If it is wanted and not made properly I'll be glad to fix what's
wrong.

The main reason for this is to make my theme consistent with the rest
of my themes (http://i.imgur.com/b4t7U.png).
>From 670ba0e67c47ec282c7dc839865c76a240f39b76 Mon Sep 17 00:00:00 2001
From: meh <meh <at> paranoici.org>
Date: Sun, 17 Jun 2012 16:28:00 +0200
Subject: [PATCH] ui: add support for color attributes

---
 options.c   |  101 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 options.h   |   15 +++++++++
 ui_curses.c |   27 ++++++++++++++--
 3 files changed, 141 insertions(+), 2 deletions(-)

diff --git a/options.c b/options.c
index 8325c05..e1c9344 100644
--- a/options.c
+++ b/options.c
 <at>  <at>  -104,6 +104,18  <at>  <at>  int colors[NR_COLORS] = {
 	COLOR_WHITE | BRIGHT
 };

+int attrs[NR_ATTRS] = {
(Continue reading)

Gregory Petrosyan | 18 Jun 2012 13:02
Picon
Gravatar

Re: [PATCH] ui: add support for color attributes

On Sun, Jun 17, 2012 at 05:41:19PM +0200, meh. wrote:
> I don't know if this patch is wanted, if it isn't it's not a problem,
> I will just maintain a repo on github with my patches.
> 
> If it is wanted and not made properly I'll be glad to fix what's
> wrong.
> 
> The main reason for this is to make my theme consistent with the rest
> of my themes (http://i.imgur.com/b4t7U.png).

Thanks a lot for the patch!

Can you please explain (in the commit message and in cmus' documentation files)
what exactly this patch does, so that users can discover this functionality?

	Gregory

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

meh. | 18 Jun 2012 13:10
Gravatar

Re: [PATCH] ui: add support for color attributes

> Can you please explain (in the commit message and in cmus' documentation files)
> what exactly this patch does, so that users can discover this functionality?

Sure, is the doc file to edit Doc/cmus.txt?

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

Gregory Petrosyan | 18 Jun 2012 13:13
Picon
Gravatar

Re: [PATCH] ui: add support for color attributes

On Mon, Jun 18, 2012 at 01:10:02PM +0200, meh. wrote:
> > Can you please explain (in the commit message and in cmus' documentation files)
> > what exactly this patch does, so that users can discover this functionality?
> 
> Sure, is the doc file to edit Doc/cmus.txt?

Yeah, sure — manpage is generated from it.

	Gregory

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
meh. | 18 Jun 2012 15:18
Gravatar

Re: [PATCH] ui: add support for color attributes

Anything else?
>From dbba5210438ec81991e76026c703a088a1792a8d Mon Sep 17 00:00:00 2001
From: meh <meh <at> paranoici.org>
Date: Sun, 17 Jun 2012 16:28:00 +0200
Subject: [PATCH] ui: add support for color attributes

This commit adds text attribute support to UI elements.

This adds the following color settings:
  - color_cmdline_attr
  - color_cur_sel_attr
  - color_statusline_attr
  - color_titleline_attr
  - color_win_attr
  - color_win_cur_sel_attr
  - color_win_inactive_cur_sel_attr
  - color_win_inactive_sel_attr
  - color_win_sel_attr
  - color_win_title_attr

Every options supports a set of attributes which have to be
sperated by a '|' without spaces.

Example:

  set color_cmdline_attr=underline|reverse

The possible attributes are:
(Continue reading)

Gregory Petrosyan | 18 Jun 2012 15:51
Picon
Gravatar

Re: [PATCH] ui: add support for color attributes

On Mon, Jun 18, 2012 at 03:18:19PM +0200, meh. wrote:
> Anything else?

No, the patch looks great! Thanks a lot; I've pushed it to the pu branch.

	Gregory

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

meh. | 18 Jun 2012 15:52
Gravatar

Re: [PATCH] ui: add support for color attributes

> No, the patch looks great! Thanks a lot; I've pushed it to the pu branch.

Thank you for merging :)

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


Gmane