Alessandro Ghedini | 10 May 2012 13:00
Picon
Gravatar

[PATCH] ecasound.el: fix regexp to match ewf files

Hi,

attached is a trivial patch that fixes the regexp inside ecasound.el which
matches *.ewf files. The patch basically replaces "$" with "\\'" to match an
end of string instead of a newline as per the example at [0].

Also, when bytecompiling it, I get:

> ecasound.el:974:1:Warning: !! The file uses old-style backquotes !!
> This functionality has been obsolete for more than 10 years already
> and will be removed soon.  See (elisp)Backquote in the manual

Though, not being an elisp expert, I can't tell what needs to be fixed.

Cheers

[0] http://www.gnu.org/software/emacs/manual/html_node/elisp/Auto-Major-Mode.html

--

-- 
perl -E '$_=q;$/=  <at> {[ <at> _]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
(Continue reading)

Kai Vehmanen | 10 May 2012 22:55

Re: [PATCH] ecasound.el: fix regexp to match ewf files

Hi,

On Thu, 10 May 2012, Alessandro Ghedini wrote:

> attached is a trivial patch that fixes the regexp inside ecasound.el which
> matches *.ewf files. The patch basically replaces "$" with "\\'" to match an
> end of string instead of a newline as per the example at [0].

thanks, applied and pushed to master!

> Also, when bytecompiling it, I get:
>
>> ecasound.el:974:1:Warning: !! The file uses old-style backquotes !!
>> This functionality has been obsolete for more than 10 years already
>> and will be removed soon.  See (elisp)Backquote in the manual

Just 10 years, no hurry yet. ;) More seriously, ecasound.el hasn't been 
actively maintained for a while (= no patches in a long while), so if if 
any ecasound.el users are listening, maintenance patches are warmly 
accepted.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ecasound-list mailing list
Ecasound-list <at> lists.sourceforge.net
(Continue reading)

Mario Lang | 10 May 2012 23:18
Favicon
Gravatar

Re: [PATCH] ecasound.el: fix regexp to match ewf files

Kai Vehmanen <kvehmanen <at> eca.cx> writes:

> Hi,
>
> On Thu, 10 May 2012, Alessandro Ghedini wrote:
>
>> Also, when bytecompiling it, I get:
>>
>>> ecasound.el:974:1:Warning: !! The file uses old-style backquotes !!
>>> This functionality has been obsolete for more than 10 years already
>>> and will be removed soon.  See (elisp)Backquote in the manual
>
> Just 10 years, no hurry yet. ;) More seriously, ecasound.el hasn't been 
> actively maintained for a while (= no patches in a long while), so if if 
> any ecasound.el users are listening, maintenance patches are warmly 
> accepted.

Noted and put on my list :-).  I will try to give it at least a review
and make it warning-clean.  I didn't actually use it myself in quite a
while :-(.

--

-- 
CYa,
  ⡍⠁⠗⠊⠕ | Debian Developer <URL:http://debian.org/>
  .''`. | Get my public key via finger mlang/key <at> db.debian.org
 : :' : | 1024D/7FC1A0854909BCCDBE6C102DDFFC022A6B113E44
 `. `'
   `-      <URL:http://delysid.org/>  <URL:http://www.staff.tugraz.at/mlang/>

------------------------------------------------------------------------------
(Continue reading)


Gmane