headers
Josh Parmenter | 1 Aug 2012 07:26

scope buffer question

Hi everyone,

In scope_buffer.hpp, there is a compiler warning about:

	friend class scope_buffer_writer;
	friend class scope_buffer_reader;

where both were declared earlier as:

struct scope_buffer_writer;
struct scope_buffer_reader;

I know class and struct function in similar ways, but should this be stricter? Let me know, I can adjust if we
think it should be changed.

Josh

******************************************
/* Joshua D. Parmenter
http://www.realizedsound.net/josh/

“Every composer – at all times and in all cases – gives his own interpretation of how modern society is
structured: whether actively or passively, consciously or unconsciously, he makes choices in this
regard. He may be conservative or he may subject himself to continual renewal; or he may strive for a
revolutionary, historical or social palingenesis." - Luigi Nono
*/

_______________________________________________
sc-dev mailing list
(Continue reading)

Permalink | Reply |
headers
Jakob Leben | 1 Aug 2012 11:08
Picon
Gravatar

Re: scope buffer question

Hi,

Afaik, you can safely change either the forward declaration or the
"friend" statements in any such way that the warnings go away.
See definition of scope_buffer_writer and scope_buffer_reader later in
the same file...

On Wed, Aug 1, 2012 at 7:26 AM, Josh Parmenter
<josh@...> wrote:
> Hi everyone,
>
> In scope_buffer.hpp, there is a compiler warning about:
>
>         friend class scope_buffer_writer;
>         friend class scope_buffer_reader;
>
> where both were declared earlier as:
>
> struct scope_buffer_writer;
> struct scope_buffer_reader;
>
> I know class and struct function in similar ways, but should this be stricter? Let me know, I can adjust if we
think it should be changed.
>
> Josh
>
> ******************************************
> /* Joshua D. Parmenter
> http://www.realizedsound.net/josh/
>
(Continue reading)

Permalink | Reply |
headers
Josh Parmenter | 1 Aug 2012 17:37

Re: scope buffer question

Thanks Jakob,
Please take a look and see if the attached looks ok.
Best,
Josh

On Aug 1, 2012, at 2:08 AM, Jakob Leben <jakob.leben@...> wrote:

> Hi,
> 
> Afaik, you can safely change either the forward declaration or the
> "friend" statements in any such way that the warnings go away.
> See definition of scope_buffer_writer and scope_buffer_reader later in
> the same file...
> 
> On Wed, Aug 1, 2012 at 7:26 AM, Josh Parmenter
<josh@...> wrote:
>> Hi everyone,
>> 
>> In scope_buffer.hpp, there is a compiler warning about:
>> 
>>        friend class scope_buffer_writer;
>>        friend class scope_buffer_reader;
>> 
>> where both were declared earlier as:
>> 
>> struct scope_buffer_writer;
>> struct scope_buffer_reader;
>> 
>> I know class and struct function in similar ways, but should this be stricter? Let me know, I can adjust if
we think it should be changed.
(Continue reading)

Permalink | Reply |
headers
Josh Parmenter | 1 Aug 2012 18:29

Re: scope buffer question

ergh... patch attached
Josh
Attachment (SharedMemoryCleanup.diff): application/octet-stream, 1076 bytes

On Aug 1, 2012, at 8:37 AM, Josh Parmenter <josh@...> wrote:

> Thanks Jakob,
> Please take a look and see if the attached looks ok.
> Best,
> Josh
> 
> On Aug 1, 2012, at 2:08 AM, Jakob Leben <jakob.leben@...> wrote:
> 
>> Hi,
>> 
>> Afaik, you can safely change either the forward declaration or the
>> "friend" statements in any such way that the warnings go away.
>> See definition of scope_buffer_writer and scope_buffer_reader later in
>> the same file...
>> 
>> On Wed, Aug 1, 2012 at 7:26 AM, Josh Parmenter
<josh@...> wrote:
>>> Hi everyone,
>>> 
>>> In scope_buffer.hpp, there is a compiler warning about:
>>> 
>>>       friend class scope_buffer_writer;
>>>       friend class scope_buffer_reader;
(Continue reading)

Permalink | Reply |
headers
Jakob Leben | 1 Aug 2012 18:52
Picon
Gravatar

Re: scope buffer question

On Wed, Aug 1, 2012 at 6:29 PM, Josh Parmenter
<josh@...> wrote:
> ergh... patch attached
> Josh
>
> On Aug 1, 2012, at 8:37 AM, Josh Parmenter
<josh@...> wrote:
>
>> Thanks Jakob,
>> Please take a look and see if the attached looks ok.

Looks good! Untested, but uncontroversial.

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/
Permalink | Reply |
headers
Josh Parmenter | 1 Aug 2012 18:55

Re: scope buffer question

Great - I'll push that off.
Josh

On Aug 1, 2012, at 9:52 AM, Jakob Leben <jakob.leben@...> wrote:

> On Wed, Aug 1, 2012 at 6:29 PM, Josh Parmenter
<josh@...> wrote:
>> ergh... patch attached
>> Josh
>> 
>> On Aug 1, 2012, at 8:37 AM, Josh Parmenter
<josh@...> wrote:
>> 
>>> Thanks Jakob,
>>> Please take a look and see if the attached looks ok.
> 
> Looks good! Untested, but uncontroversial.
> 
> _______________________________________________
> sc-dev mailing list
> 
> info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

******************************************
/* Joshua D. Parmenter
http://www.realizedsound.net/josh/

“Every composer – at all times and in all cases – gives his own interpretation of how modern society is
(Continue reading)

Permalink | Reply |

Gmane