Isaku Yamahata | 6 Nov 2010 02:13
Picon
Favicon

FWD:[PATCH] [Seabios] Over 4GB address ranges for 64bit PCI BARs

FWD

----- Forwarded message from Isaku Yamahata <yamahata at valinux.co.jp> -----

Subject: Re: [PATCH] [Seabios] Over 4GB address ranges for 64bit PCI BARs
User-Agent: Mutt/1.5.19 (2009-01-05)

Hi.
The current BAR allocation doesn't check overflow and some patches
are floating around which aren't merged yet.
There are several issues.

- overflow check
  This should be fixed.
  Some patches are proposed. None hasn't been merged yet.
  Your patch also addresses this issue.
  http://www.seabios.org/pipermail/seabios/2010-July/000794.html
  http://www.seabios.org/pipermail/seabios/2010-October/001089.html

- abstraction of pci bar allocation 
  This is very coding detail. This should be addressed.
  The current PCI BAR allocation uses primitives. So overflow check becomes
  ugly. So it would desirable to abstract it.
  Kevin suggested to use the existing PMM framework. But I concluded PMM
  doesn't suit for it, so introduced new api. But I haven't got any feedback
  from him yet.

- >4GB 64bit bar allocation
  Your patche tries to address this issue. But it breaks PCI-to-PCI
  bridge filtering support.
(Continue reading)


Gmane