discussion about OpenBIOS - a free portable firmware implementation ()

Stefan Weil | 12 May 2012 14:00

[PATCH] Replace 'Qemu' by 'QEMU'

The official product name is written 'QEMU'.

Signed-off-by: Stefan Weil <sw@...>
---
 arch/ppc/qemu/start.S  |    2 +-
 arch/ppc/qemu/tree.fs  |    2 +-
 arch/sparc32/ldscript  |    2 +-
 arch/sparc64/ldscript  |    2 +-
 drivers/pci_database.c |    2 +-
 drivers/sbus.c         |    6 +++---
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/ppc/qemu/start.S b/arch/ppc/qemu/start.S
index aa582e2..77ced18 100644
--- a/arch/ppc/qemu/start.S
+++ b/arch/ppc/qemu/start.S
 <at>  <at>  -701,7 +701,7  <at>  <at>  _GLOBAL(flush_icache_range):
         isync
         blr

-        /* Get RAM size from Qemu configuration device */
+        /* Get RAM size from QEMU configuration device */

 #define CFG_ADDR 0xf0000510
 #define FW_CFG_RAM_SIZE         0x03
diff --git a/arch/ppc/qemu/tree.fs b/arch/ppc/qemu/tree.fs
index e4115ea..1b9c293 100644
--- a/arch/ppc/qemu/tree.fs
+++ b/arch/ppc/qemu/tree.fs
 <at>  <at>  -1,4 +1,4  <at>  <at>

(Continue reading)

headers

Andreas Färber | 20 May 2012 18:11

Re: [PATCH] Replace 'Qemu' by 'QEMU'

Am 12.05.2012 14:00, schrieb Stefan Weil:
> The official product name is written 'QEMU'.
> 
> Signed-off-by: Stefan Weil <sw@...>

Thanks, applied all changes to comments in r1060.

> diff --git a/drivers/pci_database.c b/drivers/pci_database.c
> index ac47621..0983da3 100644
> --- a/drivers/pci_database.c
> +++ b/drivers/pci_database.c
>  <at>  <at>  -176,7 +176,7  <at>  <at>  static const pci_dev_t vga_devices[] = {
>      },
>      {
>          PCI_VENDOR_ID_QEMU, PCI_DEVICE_ID_QEMU_VGA,
> -        NULL, "QEMU,VGA", "Qemu VGA",    "VGA\0",
> +        NULL, "QEMU,VGA", "QEMU VGA",    "VGA\0",
>          0, 0, 0,
>          NULL, NULL,
>      },

I wonder if changing this string here would be guest-visible or just for
debugging purposes in OpenBIOS?

Andreas

--

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

(Continue reading)

headers

Stefan Weil | 20 May 2012 22:36

Re: [PATCH] Replace 'Qemu' by 'QEMU'

Am 20.05.2012 18:11, schrieb Andreas Färber:
> Am 12.05.2012 14:00, schrieb Stefan Weil:
>> The official product name is written 'QEMU'.
>>
>> Signed-off-by: Stefan Weil <sw@...>
>
> Thanks, applied all changes to comments in r1060.
>
>> diff --git a/drivers/pci_database.c b/drivers/pci_database.c
>> index ac47621..0983da3 100644
>> --- a/drivers/pci_database.c
>> +++ b/drivers/pci_database.c
>>  <at>  <at>  -176,7 +176,7  <at>  <at>  static const pci_dev_t vga_devices[] = {
>> },
>> {
>> PCI_VENDOR_ID_QEMU, PCI_DEVICE_ID_QEMU_VGA,
>> - NULL, "QEMU,VGA", "Qemu VGA", "VGA\0",
>> + NULL, "QEMU,VGA", "QEMU VGA", "VGA\0",
>> 0, 0, 0,
>> NULL, NULL,
>> },
>
> I wonder if changing this string here would be guest-visible or just for
> debugging purposes in OpenBIOS?
>
> Andreas
>

That's the model part of the PCI device structure.
The model is exposed as a property in function ob_pci_add_properties,

(Continue reading)