Philippe Reynes | 28 Jun 2012 22:36
Picon
Favicon

[PATCH 1/5] [PATCH 1/5] Add missing constant to mx27

Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
---
 arch/arm/cpu/arm926ejs/mx27/asm-offsets.c |   34 ++++++++++++
 arch/arm/include/asm/arch-mx27/imx-regs.h |   11 ++++-
 arch/arm/include/asm/arch-mx27/mxc_nand.h |   83 +++++++++++++++++++++++++++++
 3 files changed, 127 insertions(+), 1 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-mx27/mxc_nand.h

diff --git a/arch/arm/cpu/arm926ejs/mx27/asm-offsets.c b/arch/arm/cpu/arm926ejs/mx27/asm-offsets.c
index f3a8d7b..b95c58c 100644
--- a/arch/arm/cpu/arm926ejs/mx27/asm-offsets.c
+++ b/arch/arm/cpu/arm926ejs/mx27/asm-offsets.c
 <at>  <at>  -34,6 +34,7  <at>  <at>  int main(void)
 	DEFINE(PCDR1, IMX_PLL_BASE + offsetof(struct pll_regs, pcdr1));
 	DEFINE(PCCR0, IMX_PLL_BASE + offsetof(struct pll_regs, pccr0));
 	DEFINE(PCCR1, IMX_PLL_BASE + offsetof(struct pll_regs, pccr1));
+	DEFINE(CCSR, IMX_PLL_BASE + offsetof(struct pll_regs, ccsr));

 	DEFINE(ESDCTL0_ROF, offsetof(struct esdramc_regs, esdctl0));
 	DEFINE(ESDCFG0_ROF, offsetof(struct esdramc_regs, esdcfg0));
 <at>  <at>  -41,5 +42,38  <at>  <at>  int main(void)
 	DEFINE(ESDCFG1_ROF, offsetof(struct esdramc_regs, esdcfg1));
 	DEFINE(ESDMISC_ROF, offsetof(struct esdramc_regs, esdmisc));

+	DEFINE(GPCR, IMX_SYSTEM_CTL_BASE +
+	       offsetof(struct system_control_regs, gpcr));
+	DEFINE(FMCR, IMX_SYSTEM_CTL_BASE +
+	       offsetof(struct system_control_regs, fmcr));
+	DEFINE(DSCR2, IMX_SYSTEM_CTL_BASE +
(Continue reading)

Philippe Reynes | 28 Jun 2012 22:36
Picon
Favicon

[PATCH 2/5] [PATCH 2/5] Add support for the armadeus APF27 board

Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
Signed-off-by: Nicolas Colombain <nicolas.colombain <at> armadeus.com>
---
 board/armadeus/apf27/Makefile        |   52 ++++++
 board/armadeus/apf27/apf27.c         |  310 ++++++++++++++++++++++++++++++++++
 board/armadeus/apf27/config.mk       |   38 ++++
 board/armadeus/apf27/lowlevel_init.S |  275 ++++++++++++++++++++++++++++++
 boards.cfg                           |    1 +
 5 files changed, 676 insertions(+), 0 deletions(-)
 create mode 100644 board/armadeus/apf27/Makefile
 create mode 100644 board/armadeus/apf27/apf27.c
 create mode 100644 board/armadeus/apf27/config.mk
 create mode 100644 board/armadeus/apf27/lowlevel_init.S

diff --git a/board/armadeus/apf27/Makefile b/board/armadeus/apf27/Makefile
new file mode 100644
index 0000000..fe6ba5c
--- /dev/null
+++ b/board/armadeus/apf27/Makefile
 <at>  <at>  -0,0 +1,52  <at>  <at> 
+#
+# (C) Copyright 2000-2004
+# Wolfgang Denk, DENX Software Engineering, wd <at> denx.de.
+# (C) Copyright 2012
+# Eric Jarrige <eric.jarrige <at> armadeus.org>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
(Continue reading)

Fabio Estevam | 29 Jun 2012 01:06
Picon

Re: [PATCH 2/5] [PATCH 2/5] Add support for the armadeus APF27 board

Hi Philippe,

On Thu, Jun 28, 2012 at 5:36 PM, Philippe Reynes <tremyfr <at> yahoo.fr> wrote:
> Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
> Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>

Here we have armadeus.org

> Signed-off-by: Nicolas Colombain <nicolas.colombain <at> armadeus.com>

,and here it is armadeus.com. Which one is correct?

> ---
>  board/armadeus/apf27/Makefile        |   52 ++++++
>  board/armadeus/apf27/apf27.c         |  310 ++++++++++++++++++++++++++++++++++
>  board/armadeus/apf27/config.mk       |   38 ++++
>  board/armadeus/apf27/lowlevel_init.S |  275 ++++++++++++++++++++++++++++++
>  boards.cfg                           |    1 +

You missed an entry to the MAINTAINERS file.

> +void
> +show_boot_progress(int status)
> +{
> +#ifdef CONFIG_SHOW_BOOT_PROGRESS
> +#endif

This ifdef seems to be useless at this location.

> --- /dev/null
(Continue reading)

Eric Jarrige | 29 Jun 2012 03:16

Re: [PATCH 2/5] [PATCH 2/5] Add support for the armadeus APF27 board

Hi Fabio,

On 29 juin 2012, at 01:06, Fabio Estevam wrote:

> Hi Philippe,
> 
> On Thu, Jun 28, 2012 at 5:36 PM, Philippe Reynes <tremyfr <at> yahoo.fr> wrote:
>> Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
>> Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
> 
> Here we have armadeus.org
> 
>> Signed-off-by: Nicolas Colombain <nicolas.colombain <at> armadeus.com>
> 
> ,and here it is armadeus.com. Which one is correct?

Both are correct.
I am just answering to clarify this point that is not directly related to the patch .
Many members of the Armadeus project are not involved in the homonym
company. That's the reason why both domain names exist.

Regards,
Eric

_______________________________________________
U-Boot mailing list
U-Boot <at> lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
(Continue reading)

Stefano Babic | 7 Jul 2012 20:03
Picon
Picon
Favicon

Re: [PATCH 2/5] [PATCH 2/5] Add support for the armadeus APF27 board

On 28/06/2012 22:36, Philippe Reynes wrote:
> Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
> Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
> Signed-off-by: Nicolas Colombain <nicolas.colombain <at> armadeus.com>
> ---

Hi Philippe,

> +	rm -f $(SOBJS) $(OBJS)
> +
> +distclean:	clean
> +	rm -f $(LIB) core *.bak $(obj).depend

clean / distclean are not needed, drop these rules

> +#include <common.h>
> +#include "crc.h"
> +#include <jffs2/jffs2.h>
> +#include <nand.h>
> +#include <netdev.h>
> +#include <asm/io.h>
> +#include <asm/arch/imx-regs.h>
> +#include <asm/errno.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +u32 get_board_rev(void)
> +{
> +	struct iim_regs *iim = (struct iim_regs *)IMX_IIM_BASE;
> +
(Continue reading)

Philippe Reynes | 28 Jun 2012 22:36
Picon
Favicon

[PATCH 3/5] [PATCH 3/5] Add nand_spl support for the apf27

Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
---
 nand_spl/board/armadeus/apf27/Makefile   |   79 +++++
 nand_spl/board/armadeus/apf27/config.mk  |   45 +++
 nand_spl/board/armadeus/apf27/start.S    |  548 ++++++++++++++++++++++++++++++
 nand_spl/board/armadeus/apf27/u-boot.lds |   39 +++
 4 files changed, 711 insertions(+), 0 deletions(-)
 create mode 100644 nand_spl/board/armadeus/apf27/Makefile
 create mode 100644 nand_spl/board/armadeus/apf27/config.mk
 create mode 100644 nand_spl/board/armadeus/apf27/start.S
 create mode 100644 nand_spl/board/armadeus/apf27/u-boot.lds

diff --git a/nand_spl/board/armadeus/apf27/Makefile b/nand_spl/board/armadeus/apf27/Makefile
new file mode 100644
index 0000000..600ef6b
--- /dev/null
+++ b/nand_spl/board/armadeus/apf27/Makefile
 <at>  <at>  -0,0 +1,79  <at>  <at> 
+#
+# (C) Copyright 2007
+# Stefan Roese, DENX Software Engineering, sr <at> denx.de.
+# (C) Copyright 2012
+# Eric Jarrige <eric.jarrige <at> armadeus.org>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
(Continue reading)

Scott Wood | 29 Jun 2012 00:18
Favicon

Re: [PATCH 3/5] [PATCH 3/5] Add nand_spl support for the apf27

On 06/28/2012 03:36 PM, Philippe Reynes wrote:
> Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
> Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
> ---
>  nand_spl/board/armadeus/apf27/Makefile   |   79 +++++
>  nand_spl/board/armadeus/apf27/config.mk  |   45 +++
>  nand_spl/board/armadeus/apf27/start.S    |  548 ++++++++++++++++++++++++++++++
>  nand_spl/board/armadeus/apf27/u-boot.lds |   39 +++
>  4 files changed, 711 insertions(+), 0 deletions(-)
>  create mode 100644 nand_spl/board/armadeus/apf27/Makefile
>  create mode 100644 nand_spl/board/armadeus/apf27/config.mk
>  create mode 100644 nand_spl/board/armadeus/apf27/start.S
>  create mode 100644 nand_spl/board/armadeus/apf27/u-boot.lds

nand_spl is deprecated -- please use the new spl/ infrastructure.

-Scott

> +/*
> + * Standard NAND flash commands
> + */
> +#define NAND_CMD_READ0		0
> +#define NAND_CMD_READ1		1
> +#define NAND_CMD_PAGEPROG	0x10
> +#define NAND_CMD_READOOB	0x50
> +#define NAND_CMD_ERASE1		0x60
> +#define NAND_CMD_STATUS		0x70
> +#define NAND_CMD_STATUS_MULTI	0x71
> +#define NAND_CMD_SEQIN		0x80
> +#define NAND_CMD_READID		0x90
(Continue reading)

Stefano Babic | 7 Jul 2012 19:34
Picon
Picon
Favicon

Re: [PATCH 3/5] [PATCH 3/5] Add nand_spl support for the apf27

On 28/06/2012 22:36, Philippe Reynes wrote:
> Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
> Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
> ---

Hi Philippe,

>  nand_spl/board/armadeus/apf27/Makefile   |   79 +++++
>  nand_spl/board/armadeus/apf27/config.mk  |   45 +++
>  nand_spl/board/armadeus/apf27/start.S    |  548 ++++++++++++++++++++++++++++++
>  nand_spl/board/armadeus/apf27/u-boot.lds |   39 +++
>  4 files changed, 711 insertions(+), 0 deletions(-)
>  create mode 100644 nand_spl/board/armadeus/apf27/Makefile
>  create mode 100644 nand_spl/board/armadeus/apf27/config.mk
>  create mode 100644 nand_spl/board/armadeus/apf27/start.S
>  create mode 100644 nand_spl/board/armadeus/apf27/u-boot.lds
> 

nand_spl is obsolete - new boards should add spl support with the newer
SPL framework (using spl/ instead of nand_spl/)

Best regards,
Stefano Babic

--

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic <at> denx.de
=====================================================================
(Continue reading)

Philippe Reynes | 28 Jun 2012 22:36
Picon
Favicon

[PATCH 4/5] [PATCH 4/5] Add FPGA support for the apf27 board

Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
---
 board/armadeus/apf27/Makefile |    2 +-
 board/armadeus/apf27/apf27.c  |   16 +++
 board/armadeus/apf27/fpga.c   |  272 +++++++++++++++++++++++++++++++++++++++++
 board/armadeus/apf27/fpga.h   |   39 ++++++
 4 files changed, 328 insertions(+), 1 deletions(-)
 create mode 100644 board/armadeus/apf27/fpga.c
 create mode 100644 board/armadeus/apf27/fpga.h

diff --git a/board/armadeus/apf27/Makefile b/board/armadeus/apf27/Makefile
index fe6ba5c..7a39426 100644
--- a/board/armadeus/apf27/Makefile
+++ b/board/armadeus/apf27/Makefile
 <at>  <at>  -27,7 +27,7  <at>  <at>  include $(TOPDIR)/config.mk

 LIB	= $(obj)lib$(BOARD).o

-COBJS	:= apf27.o
+COBJS	:= apf27.o fpga.o
 SOBJS	:= lowlevel_init.o

 SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/armadeus/apf27/apf27.c b/board/armadeus/apf27/apf27.c
index 75be2c1..b073703 100644
--- a/board/armadeus/apf27/apf27.c
+++ b/board/armadeus/apf27/apf27.c
 <at>  <at>  -21,6 +21,7  <at>  <at> 

(Continue reading)

Stefano Babic | 7 Jul 2012 19:43
Picon
Picon
Favicon

Re: [PATCH 4/5] [PATCH 4/5] Add FPGA support for the apf27 board

On 28/06/2012 22:36, Philippe Reynes wrote:
> Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
> Signed-off-by: Eric Jarrige <eric.jarrige <at> armadeus.org>
> ---

Hi Philippe,

> + *
> + */
> +#include <common.h>
> +
> +#if defined(CONFIG_FPGA)

Maybe you can drop this and compiling this file only if CONFIG_FPGA is
set, changing your Makefile

> +
> +#define GPIO_PORT(x)  ((x & GPIO_PORT_MASK) >> GPIO_PORT_SHIFT)
> +#define GPIO_SET(x)   writel(readl(&gpregs->port[GPIO_PORT(x)].dr) | \
> +		(1 << (x & GPIO_PIN_MASK)), &gpregs->port[GPIO_PORT(x)].dr)
> +
> +/* (DR(GPIO_PORT(x)) |= (1<<(x & GPIO_PIN_MASK))) */
> +#define GPIO_CLEAR(x) writel(readl(&gpregs->port[GPIO_PORT(x)].dr) & \
> +		~(1 << (x & GPIO_PIN_MASK)), &gpregs->port[GPIO_PORT(x)].dr)
> +/* (DR(GPIO_PORT(x)) &= ~(1<<(x & GPIO_PIN_MASK))) */
> +#define GPIO_WRITE(x, y) (y ? GPIO_SET(x) : GPIO_CLEAR(x))
> +#define GPIO_READ(x) ((readl(&gpregs->port[GPIO_PORT(x)].ssr) & \
> +		(1 << (x & GPIO_PIN_MASK))) >> (x & GPIO_PIN_MASK))

No, we have in u-boot a GPIO API to access the GPIOs. Check
(Continue reading)

Philippe Reynes | 28 Jun 2012 22:36
Picon
Favicon

[PATCH 5/5] [PATCH 5/5] Add config file for the apf27

Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
---
 include/configs/apf27.h |  916 +++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 916 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/apf27.h

diff --git a/include/configs/apf27.h b/include/configs/apf27.h
new file mode 100644
index 0000000..985fa1a
--- /dev/null
+++ b/include/configs/apf27.h
 <at>  <at>  -0,0 +1,916  <at>  <at> 
+/*
+ *
+ * Configuration settings for the Armadeus Project motherboard APF27
+ *
+ * Copyright (C) 2008-2012 ej / Armadeus Project <eric.jarrige <at> armadeus.org>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
(Continue reading)

Stefano Babic | 7 Jul 2012 19:31
Picon
Picon
Favicon

Re: [PATCH 5/5] [PATCH 5/5] Add config file for the apf27

On 28/06/2012 22:36, Philippe Reynes wrote:
> Signed-off-by: Philippe Reynes <tremyfr <at> yahoo.fr>
> ---

Hi Philippe,

>  include/configs/apf27.h |  916 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 916 insertions(+), 0 deletions(-)
>  create mode 100644 include/configs/apf27.h
> 
> diff --git a/include/configs/apf27.h b/include/configs/apf27.h
> new file mode 100644

Really this patch must be merged with patch 2/5: "Add support for the
armadeus APF27". They belong together, and it maintains the tree bisectable.

> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#define CONFIG_VERSION_VARIABLE
> +#define CONFIG_ENV_VERSION	"3.1"
> +#define CONFIG_IDENT_STRING	" apf27 patch 3.6"
> +#define CONFIG_BOARD_NAME	apf27
> +
> +/*
> + * SoC configurations
> + */
> +#define CONFIG_ARM926EJS		/* this is an ARM926EJS CPU */
> +#define CONFIG_MX27			/* in a Freescale i.MX27 Chip */
(Continue reading)


Gmane