Universal Boot Loader general discussion ()

Aaron Williams | 11 Jul 2012 00:39

Re: U-boot Porting

Hi Daniel,

My comments are inline.

On 07/09/2012 02:11 PM, Daniel Schwierzeck wrote:
> Hi Aaron,
>
> 2012/7/6 Aaron Williams <Aaron.Williams <at> cavium.com>:
>> Hi Andreas,
>>
>> I would love to see OCTEON support in the mainline as well, though I am not
>> sure how I should go about this since it is a substantial amount of code.
>> Fortunately most of the changes are not to the common code, and many of the
>> common code changes are feature enhancements portable to other platforms as
>> well.
> we should do this step by step. My suggestions are:
>
> 1) send a patch series with only the changes on MIPS common code. I
> assume that you updated most of the header files
> with the current ones from linux? I am currently working on extending
> the support for MIPS32 CPUs thus we should unify the common
> MIPS code base at first.
I made a number of additions to the header files. For the most part I 
did not update them from Linux but modified the existing ones. I tried 
to keep my changes minimal. As I said I use board_octeon.c instead of 
board.c. I have wrapped all of our changes with #ifdef CONFIG_OCTEON.

It should be fairly easy to do this.

>

(Continue reading)

headers

Wolfgang Denk | 11 Jul 2012 07:50

Re: U-boot Porting

Dear Aaron,

In message <4FFCAF12.1030401 <at> cavium.com> you wrote:
> 
> I made a number of additions to the header files. For the most part I 
> did not update them from Linux but modified the existing ones. I tried 
> to keep my changes minimal. As I said I use board_octeon.c instead of 
> board.c. I have wrapped all of our changes with #ifdef CONFIG_OCTEON.
> 
> It should be fairly easy to do this.

We spend a lot of time here discussiong thaings that you have done and
how easy it will be to merge these into mainline.  I think we are
wasting time here.  Instead of much further ado, you should just start
posting the first small sets of these easy to merge patches, so we can
really see if they go in that easily.

> GCC as of version 4.7 should work. Note that for OCTEON we compile using 
> the N32 ABI instead of O32. Doing "basic" OCTEON support will not be 
> easy since there is a huge dependence on our SDK.

Obviouslye we need a way to test the code so we can be sure it is at
least compile-clean.  So the availability of a tool chain is somethign
that needs to be solved first.

> The only required drivers are the MDIO drivers. Most of the other 
> drivers, i.e. Ethernet, PCI, I2C, serial, flash, NAND and watchdog are 
> located under arch/mips/cpu/octeon. I don't know if it makes sense to 
> move these into the drivers tree since these are specific to OCTEON and 
> some (i.e. the Ethernet driver and NAND) have a strong dependency on our

(Continue reading)