Universal Boot Loader general discussion ()

Wolfgang Denk | 22 Jul 2012 10:03

[PATCH 1/2] BC3450 board: change debug code to using debug()

Signed-off-by: Wolfgang Denk <wd <at> denx.de>
Cc: Detlev Zundel <dzu <at> denx.de>
---
 board/bc3450/cmd_bc3450.c |   12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/board/bc3450/cmd_bc3450.c b/board/bc3450/cmd_bc3450.c
index a9e4902..935769b 100644
--- a/board/bc3450/cmd_bc3450.c
+++ b/board/bc3450/cmd_bc3450.c
 <at>  <at>  -32,13 +32,6  <at>  <at> 
  */
 #if defined(CONFIG_CMD_BSP)

-#undef DEBUG
-#ifdef DEBUG
-# define dprintf(fmt,args...)	printf(fmt, ##args)
-#else
-# define dprintf(fmt,args...)
-#endif
-
 /*
  * Definitions for DS1620 chip
  */
 <at>  <at>  -129,7 +122,7  <at>  <at>  int sm501_gpio_init (void)
 	static int init_done = 0;

 	if (init_done) {
-/*	dprintf("sm501_gpio_init: nothing to be done.\n"); */
+		debug("sm501_gpio_init: nothing to be done.\n");

(Continue reading)

headers

Wolfgang Denk | 22 Jul 2012 10:03

[PATCH 2/2] BC3450 board: Remove unused CONFIG_SYS_CPU definition

This fixes:
cmd_bc3450.c:55:0: warning: "CONFIG_SYS_CPU" redefined [enabled by default]

Signed-off-by: Wolfgang Denk <wd <at> denx.de>
Cc: Detlev Zundel <dzu <at> denx.de>
---
 board/bc3450/cmd_bc3450.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/board/bc3450/cmd_bc3450.c b/board/bc3450/cmd_bc3450.c
index 935769b..fefffc3 100644
--- a/board/bc3450/cmd_bc3450.c
+++ b/board/bc3450/cmd_bc3450.c
 <at>  <at>  -45,7 +45,6  <at>  <at> 
 #define THERM_WRITE_TL		0x02
 #define THERM_WRITE_TH		0x01

-#define CONFIG_SYS_CPU			2
 #define CONFIG_SYS_1SHOT		1
 #define CONFIG_SYS_STANDALONE		0

--

-- 
1.7.10.4

headers

Wolfgang Denk | 22 Jul 2012 21:53

Re: [PATCH 2/2] BC3450 board: Remove unused CONFIG_SYS_CPU definition

Dear Wolfgang Denk,

In message <1342944195-23901-2-git-send-email-wd <at> denx.de> you wrote:
> This fixes:
> cmd_bc3450.c:55:0: warning: "CONFIG_SYS_CPU" redefined [enabled by default]
> 
> Signed-off-by: Wolfgang Denk <wd <at> denx.de>
> Cc: Detlev Zundel <dzu <at> denx.de>
> ---
>  board/bc3450/cmd_bc3450.c |    1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

Best regards,

Wolfgang Denk

--

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd <at> denx.de
"Don't worry about people stealing your ideas. If your ideas are  any
good, you'll have to ram them down people's throats."  - Howard Aiken

headers

Wolfgang Denk | 22 Jul 2012 21:53

Re: [PATCH 1/2] BC3450 board: change debug code to using debug()

Dear Wolfgang Denk,

In message <1342944195-23901-1-git-send-email-wd <at> denx.de> you wrote:
> Signed-off-by: Wolfgang Denk <wd <at> denx.de>
> Cc: Detlev Zundel <dzu <at> denx.de>
> ---
>  board/bc3450/cmd_bc3450.c |   12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

--

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd <at> denx.de
If there are self-made purgatories, then we all have to live in them.
	-- Spock, "This Side of Paradise", stardate 3417.7