Re: [PATCH v4 1/5] net/bootp: add VCI support for BOOTP also

Hi Joe,

On Mon, Aug 6, 2012 at 1:21 AM, Ilya Yanok <ilya.yanok <at> cogentembedded.com>wrote:

> Vendor Class Identifier option is common to BOOTP and DHCP and
> can be useful without PXE. So send VCI in both BOOTP and DHCP
> requests if CONFIG_BOOTP_VCI_STRING is defined.
>
> Signed-off-by: Ilya Yanok <ilya.yanok <at> cogentembedded.com>
>
> ---
> Changes in v4:
>  - moved vci_strlen var inside macro
>  - used strlen instead of sizeof
>
>
Is it ok now? What about the rest of the series?

Regards, Ilya.

_______________________________________________
U-Boot mailing list
U-Boot <at> lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [PATCH v4 1/5] net/bootp: add VCI support for BOOTP also

Hi Ilya,

On Sun, Aug 5, 2012 at 4:21 PM, Ilya Yanok
<ilya.yanok <at> cogentembedded.com> wrote:
> Vendor Class Identifier option is common to BOOTP and DHCP and
> can be useful without PXE. So send VCI in both BOOTP and DHCP
> requests if CONFIG_BOOTP_VCI_STRING is defined.
>
> Signed-off-by: Ilya Yanok <ilya.yanok <at> cogentembedded.com>
>
> ---

Acked-by: Joe Hershberger <joe.hershberger <at> ni.com>

Re: [PATCH v4 3/5] OMAP: spl: call timer_inti() from SPL

On Sun, Aug 5, 2012 at 2:21 PM, Ilya Yanok
<ilya.yanok <at> cogentembedded.com> wrote:
> We need to initialize timer properly, otherwise all delays
> inside SPL will be wrong.
>
> Signed-off-by: Ilya Yanok <ilya.yanok <at> cogentembedded.com>
> ---
>
>  arch/arm/cpu/armv7/omap-common/spl.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/omap-common/spl.c b/arch/arm/cpu/armv7/omap-common/spl.c
> index 4d1ac85..f0d766c 100644
> --- a/arch/arm/cpu/armv7/omap-common/spl.c
> +++ b/arch/arm/cpu/armv7/omap-common/spl.c
>  <at>  <at>  -152,6 +152,8  <at>  <at>  void board_init_r(gd_t *id, ulong dummy)
>         mem_malloc_init(CONFIG_SYS_SPL_MALLOC_START,
>                         CONFIG_SYS_SPL_MALLOC_SIZE);
>
> +       timer_init();
> +
>  #ifdef CONFIG_SPL_BOARD_INIT
>         spl_board_init();
>  #endif

Calling it twice has other bad side-effects so there should be a
timer_init removal somewhere too.

--

-- 
Tom

[PATCH] am33xx: Remove redundant timer config

We have the timer code in arch/arm/cpu/armv7/omap-common/timer.c that
has been configuring and enabling the timer, so remove our code that
does the same thing by different methods.

Tested on EVM GP, SK-EVM and Beaglebone.

Signed-off-by: Tom Rini <trini <at> ti.com>
---
 arch/arm/cpu/armv7/am33xx/board.c |   20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c
index 2ca4ca7..5b00719 100644
--- a/arch/arm/cpu/armv7/am33xx/board.c
+++ b/arch/arm/cpu/armv7/am33xx/board.c
 <at>  <at>  -37,7 +37,6  <at>  <at> 
 DECLARE_GLOBAL_DATA_PTR;

 struct wd_timer *wdtimer = (struct wd_timer *)WDT_BASE;
-struct gptimer *timer_base = (struct gptimer *)CONFIG_SYS_TIMERBASE;
 struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE;

 static const struct gpio_bank gpio_bank_am33xx[4] = {
 <at>  <at>  -119,22 +118,6  <at>  <at>  static int read_eeprom(void)
 #define UART_SMART_IDLE_EN	(0x1 << 0x3)
 #endif

-#ifdef CONFIG_SPL_BUILD
-/* Initialize timer */
-static void init_timer(void)

Re: [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

On Sun, Aug 5, 2012 at 2:21 PM, Ilya Yanok
<ilya.yanok <at> cogentembedded.com> wrote:
> __u_boot_cmd* symbols are not used in SPL so there is no need
> to tell the linker that they are undefined. With these symbols
> marked as undefined linker fails to garbage collect some unused
> functions and even fails to build the resulting image.

I don't like this because it causes SPL to bloat when the commands
aren't also removed from the build.  But I assume a number of commands
were being pulled in as part of the networking stack?

--

-- 
Tom

[PATCH v5 4/5] OMAP: networking support for SPL

This patch adds support for networking in SPL. Some devices are
capable of loading SPL via network so it makes sense to load the
main U-Boot binary via network too. This patch tries to use
existing network code as much as possible. Unfortunately, it depends
on environment which in turn depends on other code so SPL size
is increased significantly. No effort was done to decouple network
code and environment so far.

Signed-off-by: Ilya Yanok <ilya.yanok <at> cogentembedded.com>

---
Changes in v3:
 - use BOOTP in SPL regardless of CONFIG_CMD_DHCP
 - add support for setting different VCI in SPL

Changes in v4:
 - fix compilation of SPL's libcommon with CONFIG_HUSH_PARSER
   and CONFIG_BOOTD defined
 - rename spl_eth.c to spl_net.c
 - set ethact variable if device name is passed

Changes in v5:
 - set up guards in cmd_nvedit.c more carefully
 - now we don't need command.c and only need main.c for
   show_boot_progress() so defined it to be noop and remove
   both files from SPL sources
 - SPL guards in command.c and main.c are no longer needed
 - add some guards in env_common.c
 - qsort.c is no longer needed
 - add guard to hashtable.c to save some space