gmane.comp.cms.magnolia.devel

JIRA (on behalf of Gregory Joseph | 16 Jul 22:24

[magnolia-dev] [JIRA] Created: (MAGNOLIA-2274) CheckNodeTypesDefinition needs to work for "less-standard" setups (other repository providers, non-standard configuration, multiple repositories, ...)

CheckNodeTypesDefinition needs to work for "less-standard" setups (other repository providers,
non-standard configuration, multiple repositories, ...)
------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: MAGNOLIA-2274
                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2274
             Project: Magnolia
          Issue Type: Improvement
          Components: core
    Affects Versions: 3.6
            Reporter: Gregory Joseph
            Assignee: Philipp Bracher
             Fix For: 3.6.1

It currently assumes that we're using jackrabbit (usage of the custom_nodetypes.xml file, its structure
and its location), and that there is a single repository named "magnolia".

--

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 16 Jul 22:24

[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2274) CheckNodeTypesDefinition needs to work for "less-standard" setups (other repository providers, non-standard configuration, multiple repositories, ...)


     [
http://jira.magnolia.info/browse/MAGNOLIA-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph updated MAGNOLIA-2274:
-------------------------------------

    Description: 
It currently assumes that we're using jackrabbit (usage of the custom_nodetypes.xml file, its structure
and its location), and that there is a single repository named "magnolia".

This supersedes the fix in MAGNOLIA-2271 which made the condition pass in case this file wasn't found
(which as a consequence, would let Magnolia start on unchecked systems with "wrong" nodetypes)

  was:It currently assumes that we're using jackrabbit (usage of the custom_nodetypes.xml file, its
structure and its location), and that there is a single repository named "magnolia".

> CheckNodeTypesDefinition needs to work for "less-standard" setups (other repository providers,
non-standard configuration, multiple repositories, ...)
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2274
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2274
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.6
>            Reporter: Gregory Joseph
>            Assignee: Philipp Bracher
>             Fix For: 3.6.1

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 16 Jul 22:28

[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2271) Update is block is repository structure isn't standard


     [
http://jira.magnolia.info/browse/MAGNOLIA-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph updated MAGNOLIA-2271:
-------------------------------------

        Summary: Update is block is repository structure isn't standard  (was: Magnolia 3.6 update can crash due to
unexpected repository location)
    Component/s: core

> Update is block is repository structure isn't standard
> ------------------------------------------------------
>
>                 Key: MAGNOLIA-2271
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2271
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6
>
>
> the update task setup/for3_6/CheckNodeTypesDefinition.java is looking for a custom-nodetypes.xml
file based on the repo home configuration property.
> If the repositories.xml file has been customized and changed without using that property as the base path
magnolia will never startup due to a FileNotFound exception. We should at least ignore it, making startup
work as usual.

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 16 Jul 22:28

[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2271) Update/install is blocked is repository structure isn't standard


     [
http://jira.magnolia.info/browse/MAGNOLIA-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph updated MAGNOLIA-2271:
-------------------------------------

    Summary: Update/install is blocked is repository structure isn't standard  (was: Update is block is
repository structure isn't standard)

> Update/install is blocked is repository structure isn't standard
> ----------------------------------------------------------------
>
>                 Key: MAGNOLIA-2271
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2271
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6
>
>
> the update task setup/for3_6/CheckNodeTypesDefinition.java is looking for a custom-nodetypes.xml
file based on the repo home configuration property.
> If the repositories.xml file has been customized and changed without using that property as the base path
magnolia will never startup due to a FileNotFound exception. We should at least ignore it, making startup
work as usual.

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 16 Jul 22:28

[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2272) Ability to choose a custom save handler per control/field


     [
http://jira.magnolia.info/browse/MAGNOLIA-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph updated MAGNOLIA-2272:
-------------------------------------

    Fix Version/s: 3.6.1
                       (was: 3.6)

> Ability to choose a custom save handler per control/field
> ---------------------------------------------------------
>
>                 Key: MAGNOLIA-2272
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2272
>             Project: Magnolia
>          Issue Type: Improvement
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6.1
>
>
> We know that the current SaveHandlerImpl is a big limit in creating customized controls and behaviours
(for example it could be needed to create an image and save it into the repo from a configured text).
> SaveHandlerImpl could easily be expanded in order to allow the configuration of custom save handles per
dialog fields (without breaking or requiring any api change). I'd like to commit this contribution
(already done) for 3.6

--

--

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 16 Jul 22:28

[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2273) Make MessagesManager easier to extend/replace


     [
http://jira.magnolia.info/browse/MAGNOLIA-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph updated MAGNOLIA-2273:
-------------------------------------

    Fix Version/s: 3.6.1
                       (was: 3.6)

> Make MessagesManager easier to extend/replace
> ---------------------------------------------
>
>                 Key: MAGNOLIA-2273
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2273
>             Project: Magnolia
>          Issue Type: Improvement
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6.1
>
>
> The current implementation ca't in any way be integrated/replaced in order to manage translations in a
different way (for example saving them into the magnolia repo)... we should add a bit of flexibility

--

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa

(Continue reading)

headers

JIRA (on behalf of Fabrizio Giustina | 16 Jul 22:41

[magnolia-dev] [JIRA] Commented: (MAGNOLIA-2270) Better logs and avoid NPEs when magnolia is started from an unexpanded war


    [
http://jira.magnolia.info/browse/MAGNOLIA-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163#action_17163
] 

Fabrizio Giustina commented on MAGNOLIA-2270:
---------------------------------------------

mh, I am not so sure it's a false statement, at least not for any appserver: servletContext.getRealPath()
can return null for unexpanded wars and magnolia crashes at startup for that...
on which container did you run magnolia unexpanded?

> Better logs and avoid NPEs when magnolia is started from an unexpanded war
> --------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2270
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2270
>             Project: Magnolia
>          Issue Type: Improvement
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6
>
>
> Magnolia doesn't work with if started from an unexpanded war, as we know, but we also should give a better output.
> 3.6-rc1 dies with an unhelpful NPE in MgnlServletContextListener

--

-- 
This message is automatically generated by JIRA.

(Continue reading)

headers

JIRA (on behalf of Jan Haderka | 17 Jul 08:30

[magnolia-dev] [JIRA] Commented: (MAGNOLIA-2270) Better logs and avoid NPEs when magnolia is started from an unexpanded war


    [
http://jira.magnolia.info/browse/MAGNOLIA-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164#action_17164
] 

Jan Haderka commented on MAGNOLIA-2270:
---------------------------------------

The only app server I've seen so far returning null was Weblogic 9 and older. And for this we have a solution in
form of special module that takes care of the things (since there was more customization necessary then
just this listener).
As for which App servers I've tested those were various versions of Glassfish, JBoss, Weblogic and Websphere.
I haven't tested on Tomcat 6 (and I will), but see no reason why it should not run. And even if it doesn't for
some reason it is not correct to give false impression that you can't run as a war file in general.

> Better logs and avoid NPEs when magnolia is started from an unexpanded war
> --------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2270
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2270
>             Project: Magnolia
>          Issue Type: Improvement
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6
>
>
> Magnolia doesn't work with if started from an unexpanded war, as we know, but we also should give a better output.
> 3.6-rc1 dies with an unhelpful NPE in MgnlServletContextListener

(Continue reading)

headers

JIRA (on behalf of Fabrizio Giustina | 17 Jul 12:29

[magnolia-dev] [JIRA] Commented: (MAGNOLIA-2270) Better logs and avoid NPEs when magnolia is started from an unexpanded war


    [
http://jira.magnolia.info/browse/MAGNOLIA-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166#action_17166
] 

Fabrizio Giustina commented on MAGNOLIA-2270:
---------------------------------------------

> it is not correct to give false impression that you can't run as a war file in general. 

the check here is clean and simple:
- if servletContext.getRealPath() returns null you are using an unexpanded war in a container where
magnolia will not run unexpanded.
- If you are using a expanded war or a unexpanded war in a server where magnolia can run you will never see this
message. If servletContext.getRealPath() returns null it means that you are running a unexpanded war in
a server where this is not supported and the log clearly helps you in fixing your configuration.

> Better logs and avoid NPEs when magnolia is started from an unexpanded war
> --------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2270
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2270
>             Project: Magnolia
>          Issue Type: Improvement
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6
>
>

(Continue reading)

headers

JIRA (on behalf of Jan Haderka | 17 Jul 12:59

[magnolia-dev] [JIRA] Commented: (MAGNOLIA-2270) Better logs and avoid NPEs when magnolia is started from an unexpanded war


    [
http://jira.magnolia.info/browse/MAGNOLIA-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167#action_17167
] 

Jan Haderka commented on MAGNOLIA-2270:
---------------------------------------

{quote}
    *  if servletContext.getRealPath() returns null you are using an unexpanded war in a container where
magnolia will not run unexpanded.
    * If you are using a expanded war or a unexpanded war in a server where magnolia can run you will never see this
message. If servletContext.getRealPath() returns null it means that you are running a unexpanded war in
a server where this is not supported and the log clearly helps you in fixing your configuration.
{quote}
My take on this is as follows:
* if {{servletContext.getRealPath()}} returns null, either server is not configured properly or
magnolia is not configured properly (if it still relies on the value). And configuration change doesn't
necessarily mean that you have to expand the war file. It can be many different things, for example
Weblogic 10 has a flag that can be put in deployment descriptors specifying if you want to get real value or not.

So the statement in the error message ??Magnolia needs to be run from an expanded webapp?? is not correct.
The correct message in this case would be "_Real path can't be obtained. Magnolia is not configured
properly and therefore unable to start. Please refer to Magnolia documentation for installation
instructions specific for your environment (OS, app server)._"

> Better logs and avoid NPEs when magnolia is started from an unexpanded war
> --------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2270

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 17 Jul 13:41

[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2271) Update/install is blocked if repository structure isn't standard


     [
http://jira.magnolia.info/browse/MAGNOLIA-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph updated MAGNOLIA-2271:
-------------------------------------

    Summary: Update/install is blocked if repository structure isn't standard  (was: Update/install is
blocked is repository structure isn't standard)

> Update/install is blocked if repository structure isn't standard
> ----------------------------------------------------------------
>
>                 Key: MAGNOLIA-2271
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2271
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6
>
>
> the update task setup/for3_6/CheckNodeTypesDefinition.java is looking for a custom-nodetypes.xml
file based on the repo home configuration property.
> If the repositories.xml file has been customized and changed without using that property as the base path
magnolia will never startup due to a FileNotFound exception. We should at least ignore it, making startup
work as usual.

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 17 Jul 15:11

[magnolia-dev] [JIRA] Resolved: (MAGNOLIA-2269) workflow module does not changes the tree configurations safely enough


     [
http://jira.magnolia.info/browse/MAGNOLIA-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph resolved MAGNOLIA-2269.
--------------------------------------

    Resolution: Fixed

committed on 3.6-rc branch and trunk

> workflow module does not changes the tree configurations safely enough
> ----------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2269
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2269
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: workflow
>    Affects Versions: 3.6 RC1
>            Reporter: Gregory Joseph
>            Assignee: Gregory Joseph
>             Fix For: 3.6
>
>
> WorkflowModuleVersionHandler should use CheckAndModifyPropertyValueTask and not SetPropertyTask
to modify the treeConfiguration properties, because we do not want to accidentally change a tree's
config if it was modified.

--

--

(Continue reading)

headers

JIRA (on behalf of Gregory Joseph | 17 Jul 15:45

[magnolia-dev] [JIRA] Resolved: (MAGNOLIA-2270) Better logs and avoid NPEs when magnolia is started from an unexpanded war


     [
http://jira.magnolia.info/browse/MAGNOLIA-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Joseph resolved MAGNOLIA-2270.
--------------------------------------

    Resolution: Fixed

corrected error message on trunk and 3.6-rc branch

> Better logs and avoid NPEs when magnolia is started from an unexpanded war
> --------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2270
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2270
>             Project: Magnolia
>          Issue Type: Improvement
>    Affects Versions: 3.6 RC1
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>             Fix For: 3.6
>
>
> Magnolia doesn't work with if started from an unexpanded war, as we know, but we also should give a better output.
> 3.6-rc1 dies with an unhelpful NPE in MgnlServletContextListener

--

-- 
This message is automatically generated by JIRA.
-

(Continue reading)