gmane.comp.cms.nuxeo.general

visual cleanup patch to document_view.xhtml

Hello,

When customizing nuxeo I noticed that the "Restore" button for a deleted
document seems to be out of place.  I've modified the
document_view.xhtml to place this button by the lifecycle information,
and will show up when the document is deleted (as before).  The attached
diff against nuxeo 5.1.4 modifies the placement of the restore button
and eliminates the need for the file trash_details.xhtml.

Is there any interest in incorporating these type of patches into the
nuxeo distribution?  If so, I've also been thinking of a visual cleanup
of the lock_details.xhtml. 

Cheers,
Mike Santy

Attachment (document_view.xhtml): application/xhtml+xml, 5706 bytes

22,25d21
<   <h:panelGrid rendered="#{deleteActions.trashManagementEnabled}">
<     <ui:include src="/incl/trash_details.xhtml" />
<   </h:panelGrid>
< 
118a115,120
>   <c:if test="#{deleteActions.trashManagementEnabled}">
>     <h:outputText/>
>     <h:commandButton type="submit" value="#{messages['command.undeleteDocs']}" 
>       styleClass="button" action="#{deleteActions.restoreCurrentDocument}"
>       rendered="#{deleteActions.canRestoreCurrentDoc}" />
>   </c:if>

(Continue reading)

headers

Florent Guillaume | 30 May 02:00

Re: visual cleanup patch to document_view.xhtml

Hi,
Thanks for the patch! Yes, we're happy to accept cleanup contributions  
like this one.
Could you open an Improvement ticket in http://jira.nuxeo.org/ and  
attach your diff (we prefer unified diffs btw, diff -u).

Thanks,
Florent

On 1 May 2008, at 20:20, Michael Santy wrote:

> Hello,
>
> When customizing nuxeo I noticed that the "Restore" button for a  
> deleted
> document seems to be out of place.  I've modified the
> document_view.xhtml to place this button by the lifecycle information,
> and will show up when the document is deleted (as before).  The  
> attached
> diff against nuxeo 5.1.4 modifies the placement of the restore button
> and eliminates the need for the file trash_details.xhtml.
>
> Is there any interest in incorporating these type of patches into the
> nuxeo distribution?  If so, I've also been thinking of a visual  
> cleanup
> of the lock_details.xhtml.
>
> Cheers,
> Mike Santy
> <

(Continue reading)

headers

Michael Santy | 30 May 14:58

Re: visual cleanup patch to document_view.xhtml

Thanks the the response Florent.  From watching the lists, it looks like
you've been busy lately.

I created the issue http://jira.nuxeo.org/browse/NXP-2436

Cheers,
Mike

On Fri, 2008-05-30 at 02:00 +0200, Florent Guillaume wrote:
> Hi,
> Thanks for the patch! Yes, we're happy to accept cleanup contributions  
> like this one.
> Could you open an Improvement ticket in http://jira.nuxeo.org/ and  
> attach your diff (we prefer unified diffs btw, diff -u).
> 
> Thanks,
> Florent
> 
> On 1 May 2008, at 20:20, Michael Santy wrote:
> 
> > Hello,
> >
> > When customizing nuxeo I noticed that the "Restore" button for a  
> > deleted
> > document seems to be out of place.  I've modified the
> > document_view.xhtml to place this button by the lifecycle information,
> > and will show up when the document is deleted (as before).  The  
> > attached
> > diff against nuxeo 5.1.4 modifies the placement of the restore button
> > and eliminates the need for the file trash_details.xhtml.

(Continue reading)