headers
Jan Kratochvil | 1 Mar 2009 17:19
Picon
Favicon

[keiths-expr-cumulative] Regressions [Re: New branch for Fedora 11 merges]

On Fri, 27 Feb 2009 23:03:26 +0100, Sami Wagiaalla wrote:
> Sami Wagiaalla wrote:
>> I introduced this problem earlier when i was trying to resolve a  
>> conflict that I had with a patch of Jan's.  
>> 1de38657622396795ce681e64b03fb74e81e6c3d vs  
>> 60eb8684d0d85d0884aca7a2f013e5eb16a51d47
>>
>> I'll check in a fix for this. The issue is that sometimes a function 
>> Die might now have high/low pc tags but it has an abstract origin tag  
>> pointing to useful namespace information.
>
> I have check in a fix for this.

[archer-keiths-expr-cumulative] 3513c57475d20e65ac2fb2be097227011c4b8b5a

It still has a lot of regressions (tried archer-keiths-expr-cumulative) like:
	info function operator\*(^M
	memory clobbered past end of allocated block^M
	FAIL: gdb.cp/cplusfuncs.exp: info function for "operator%(" (timeout)
(at least on F10.x86_64 using mcheck: LDFLAGS="-lmcheck" ./configure...).

Possible quick fix is attached (not checked-in) - my code moved into
explore_abstract_origin() needs to know (the `die_children' count is only read)
the number of children DIEs - to allocate appropriately sized array.

Unfortunately even after this attached fix the branch is FAILing on:
+FAIL: gdb.cp/namespace-using.exp: print _a
+FAIL: gdb.cp/namespace-using.exp: print x

* Every test name should be unique - this is the reason the names exist.
(Continue reading)

Permalink | Reply |
headers
Sami Wagiaalla | 2 Mar 2009 16:39
Picon
Favicon

Re: [keiths-expr-cumulative] Regressions [Re: New branch for Fedora 11 merges]

Jan Kratochvil wrote:
> On Fri, 27 Feb 2009 23:03:26 +0100, Sami Wagiaalla wrote:
>> Sami Wagiaalla wrote:
>>> I introduced this problem earlier when i was trying to resolve a  
>>> conflict that I had with a patch of Jan's.  
>>> 1de38657622396795ce681e64b03fb74e81e6c3d vs  
>>> 60eb8684d0d85d0884aca7a2f013e5eb16a51d47
>>>
>>> I'll check in a fix for this. The issue is that sometimes a function 
>>> Die might now have high/low pc tags but it has an abstract origin tag  
>>> pointing to useful namespace information.
>> I have check in a fix for this.
> 
> [archer-keiths-expr-cumulative] 3513c57475d20e65ac2fb2be097227011c4b8b5a
> 
> 
> It still has a lot of regressions (tried archer-keiths-expr-cumulative) like:
> 	info function operator\*(^M
> 	memory clobbered past end of allocated block^M
> 	FAIL: gdb.cp/cplusfuncs.exp: info function for "operator%(" (timeout)
> (at least on F10.x86_64 using mcheck: LDFLAGS="-lmcheck" ./configure...).
> 
> Possible quick fix is attached (not checked-in) - my code moved into
> explore_abstract_origin() needs to know (the `die_children' count is only read)
> the number of children DIEs - to allocate appropriately sized array.
> 

I have committed your patch. Thanks.

>
(Continue reading)

Permalink | Reply |
headers
Jan Kratochvil | 2 Mar 2009 16:50
Picon
Favicon

Re: [keiths-expr-cumulative] Regressions

On Mon, 02 Mar 2009 16:39:17 +0100, Sami Wagiaalla wrote:
>> Unfortunately even after this attached fix the branch is FAILing on:
>> +FAIL: gdb.cp/namespace-using.exp: print _a
>> +FAIL: gdb.cp/namespace-using.exp: print x
>
> Are these the only regressions left ?

There is also that `constructor breakpoint' FAIL although assuming it is not
from you.  And feel free to run the testsuite yourself and compare the gdb.sum
files from unpatched GDB.  :-)

> Thanks for the pointers. I have made the changes and committed the patch.

c7c96c12054b0089c813555d72c60e8cdaa56946 looks OK to me, thanks.

> I will update if there are no regressions now.

I already had to update it in archer-jankratochvil-expr.  Just there was some
conflict in dwarf2_build_psymtabs_hard due to
e56b9f4bab7f78c2749bc115cc2aa5bdd7375e8c which I resolved there wrong
regarding CU PC ranges determination.  IMO that
e56b9f4bab7f78c2749bc115cc2aa5bdd7375e8c should be reverted if possible.

Regards,
Jan
Permalink | Reply |
headers
Sami Wagiaalla | 2 Mar 2009 17:05
Picon
Favicon

Re: [keiths-expr-cumulative] Regressions

Jan Kratochvil wrote:
> On Mon, 02 Mar 2009 16:39:17 +0100, Sami Wagiaalla wrote:
>>> Unfortunately even after this attached fix the branch is FAILing on:
>>> +FAIL: gdb.cp/namespace-using.exp: print _a
>>> +FAIL: gdb.cp/namespace-using.exp: print x
>> Are these the only regressions left ?
> 
> There is also that `constructor breakpoint' FAIL although assuming it is not
> from you.  And feel free to run the testsuite yourself and compare the gdb.sum
> files from unpatched GDB.  :-)

I do, before and after every patch and commit, but I could not reproduce 
these regressions. I normally test on f10 x8664, but I have tried on f10 
i386, and f11 i386, but not f11 i386 which I am about to do now. The 
only one I saw was:

	FAIL: gdb.cp/templates.exp: constructor breakpoint

Sami
Permalink | Reply |
headers
Tom Tromey | 2 Mar 2009 17:02
Picon
Favicon

Re: [keiths-expr-cumulative] Regressions

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@...> writes:

Jan> And feel free to run the testsuite yourself and compare the
Jan> gdb.sum files from unpatched GDB.  :-)

If anybody is interested, you can easily use the auto-tester on the
compile farm to regtest two revisions.

Tom
Permalink | Reply |

Gmane