headers
Jean-Baptiste Rouault | 11 Jul 2012 12:16
Favicon

[libvirt] [PATCH 0/2] vmx: handle shared folders

The following patches add support for shared folders
for VMware domains

Jean-Baptiste Rouault (2):
  vmx: handle shared folders formatting
  vmx: handle shared folders parsing

 src/vmx/vmx.c                              |  193 +++++++++++++++++++++++++++-
 src/vmx/vmx.h                              |    5 +
 tests/vmx2xmldata/vmx2xml-sharedfolder.vmx |    9 ++
 tests/vmx2xmldata/vmx2xml-sharedfolder.xml |   22 ++++
 tests/vmx2xmltest.c                        |    2 +
 tests/xml2vmxdata/xml2vmx-sharedfolder.vmx |   18 +++
 tests/xml2vmxdata/xml2vmx-sharedfolder.xml |   14 ++
 tests/xml2vmxtest.c                        |    2 +
 8 files changed, 263 insertions(+), 2 deletions(-)
 create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.xml
 create mode 100644 tests/xml2vmxdata/xml2vmx-sharedfolder.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-sharedfolder.xml

--

-- 
1.7.10.4
Permalink | Reply |
headers
Jean-Baptiste Rouault | 11 Jul 2012 12:16
Favicon

[libvirt] [PATCH 2/2] vmx: handle shared folders parsing

This patch adds support for parsing vmx files with
shared folders enabled.

Update test suite accordingly.
---
 src/vmx/vmx.c                              |  134 +++++++++++++++++++++++++++-
 src/vmx/vmx.h                              |    2 +
 tests/vmx2xmldata/vmx2xml-sharedfolder.vmx |    9 ++
 tests/vmx2xmldata/vmx2xml-sharedfolder.xml |   22 +++++
 tests/vmx2xmltest.c                        |    2 +
 5 files changed, 168 insertions(+), 1 deletion(-)
 create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.vmx
 create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.xml

diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 8a26f8c..d4f75ee 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
 <at>  <at>  -1237,6 +1237,8  <at>  <at>  virVMXParseConfig(virVMXContext *ctx, virCapsPtr caps, const char *vmx)
     bool present;
     int scsi_virtualDev[4] = { -1, -1, -1, -1 };
     int unit;
+    bool hgfs_disabled = true;
+    long long shared_folders_num = 0;

     if (ctx->parseFileName == NULL) {
         VMX_ERROR(VIR_ERR_INTERNAL_ERROR, "%s",
 <at>  <at>  -1676,7 +1678,37  <at>  <at>  virVMXParseConfig(virVMXContext *ctx, virCapsPtr caps, const char *vmx)
     }
(Continue reading)

Permalink | Reply |
headers
Matthias Bolte | 21 Jul 2012 20:18

Re: [libvirt] [PATCH 2/2] vmx: handle shared folders parsing

2012/7/11 Jean-Baptiste Rouault <jean-baptiste.rouault <at> diateam.net>:
> This patch adds support for parsing vmx files with
> shared folders enabled.
>
> Update test suite accordingly.
> ---
>  src/vmx/vmx.c                              |  134 +++++++++++++++++++++++++++-
>  src/vmx/vmx.h                              |    2 +
>  tests/vmx2xmldata/vmx2xml-sharedfolder.vmx |    9 ++
>  tests/vmx2xmldata/vmx2xml-sharedfolder.xml |   22 +++++
>  tests/vmx2xmltest.c                        |    2 +
>  5 files changed, 168 insertions(+), 1 deletion(-)
>  create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.vmx
>  create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.xml
>

> +int virVMXParseFileSystem(virConfPtr conf, int index, virDomainFSDefPtr *def)

I'll replace index with number here again as it shadows a global.

> +    /* vmx:hostPath */
> +    if (virVMXGetConfigString(conf, hostPath_name, &hostPath, false) < 0) {
> +        goto cleanup;
> +    }
> +
> +    (*def)->src = strdup(hostPath);
> +
> +    /* vmx:guestName */
> +    if (virVMXGetConfigString(conf, guestName_name, &guestName, false) < 0) {
> +        goto cleanup;
(Continue reading)

Permalink | Reply |
headers
Jean-Baptiste Rouault | 11 Jul 2012 12:16
Favicon

[libvirt] [PATCH 1/2] vmx: handle shared folders formatting

This patch adds support for generating vmx files with
shared folders enabled.

Update test suite accordingly.
---
 src/vmx/vmx.c                              |   59 +++++++++++++++++++++++++++-
 src/vmx/vmx.h                              |    3 ++
 tests/xml2vmxdata/xml2vmx-sharedfolder.vmx |   18 +++++++++
 tests/xml2vmxdata/xml2vmx-sharedfolder.xml |   14 +++++++
 tests/xml2vmxtest.c                        |    2 +
 5 files changed, 95 insertions(+), 1 deletion(-)
 create mode 100644 tests/xml2vmxdata/xml2vmx-sharedfolder.vmx
 create mode 100644 tests/xml2vmxdata/xml2vmx-sharedfolder.xml

diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 3de7062..8a26f8c 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
 <at>  <at>  -262,6 +262,29  <at>  <at>  def->disks[0]...

 
 ################################################################################
+## filesystems #################################################################
+
+                                        isolation.tools.hgfs.disable = "false"  # defaults to "true"
+
+def->nfss = 1                     <=>   sharedFolder.maxNum = "1"               # must match the number of shared folders
+
+                                        sharedFolder[0..n] -> <filesystem>
+
(Continue reading)

Permalink | Reply |
headers
Matthias Bolte | 21 Jul 2012 18:53

Re: [libvirt] [PATCH 1/2] vmx: handle shared folders formatting

2012/7/11 Jean-Baptiste Rouault <jean-baptiste.rouault <at> diateam.net>:
> This patch adds support for generating vmx files with
> shared folders enabled.
>
> Update test suite accordingly.

> +virVMXFormatFileSystem(virDomainFSDefPtr def, int index, virBufferPtr buffer)

I'll replace index with number here to avoid a warning about shadowing
a global before pushing.

ACK and pushed.

--

-- 
Matthias Bolte
http://photron.blogspot.com
Permalink | Reply |

Gmane