Common virtualization management library interface

headers

Benjamin Wang (gendwang | 16 Jul 2012 11:10

[libvirt] Question about contribution

Hi,

I am from Cisco. Now we want to use and contribute to Libvirt. One simple question is as following:

If our product needs a new feature for Libvirt, what is the process to submit our contribution to Libvirt? Must we

be approved by some committee?

B.R.

Benjamin

<div>
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi,<p></p></span></p>
<p class="MsoNormal"><span lang="EN-US">&nbsp; I am from Cisco. Now we want to use and contribute to Libvirt. One simple question is as following:<p></p></span></p>
<p class="MsoNormal"><span lang="EN-US">If our product needs a new feature for Libvirt, what is the process to submit our contribution to Libvirt? Must we<p></p></span></p>
<p class="MsoNormal"><span lang="EN-US">be approved by some committee?<p></p></span></p>
<p class="MsoNormal"><span lang="EN-US"><p>&nbsp;</p></span></p>
<p class="MsoNormal"><span lang="EN-US">B.R.<p></p></span></p>
<p class="MsoNormal"><span lang="EN-US">Benjamin<p></p></span></p>
</div>
</div>

headers

Michal Privoznik | 16 Jul 2012 11:16

Re: [libvirt] Question about contribution

On 16.07.2012 11:10, Benjamin Wang (gendwang) wrote:
> Hi,
> 
>   I am from Cisco. Now we want to use and contribute to Libvirt. One
> simple question is as following:
> 
> If our product needs a new feature for Libvirt, what is the process to
> submit our contribution to Libvirt? Must we
> 
> be approved by some committee?
> 

No, just write patches and send them to the list. There are several how-tos:

To line up with patch submission guidelines please see this:

   http://libvirt.org/hacking.html

For advices when introducing a new feature you might want to take a look
at this:

   http://libvirt.org/api_extension.html

Michal

headers

Daniel P. Berrange | 16 Jul 2012 11:20

Re: [libvirt] Question about contribution

On Mon, Jul 16, 2012 at 09:10:23AM +0000, Benjamin Wang (gendwang) wrote:
> Hi,
>   I am from Cisco. Now we want to use and contribute to Libvirt.
> One simple question is as following:
> If our product needs a new feature for Libvirt, what is the process
> to submit our contribution to Libvirt? Must we be approved by some
> committee?

No, libvirt contribution does not have any such complex process. Decisions
on whether a feature is accepted are based on "rough consensus" agreement
by the maintainers on this list. Anyone on this list is free to put forward
points in favour / or against a proposed feature, and the maintainers will
look to see what the general viewpoint is and make a decision. If the
feature fits within the scope of the libvirt API, then it is rare that we
would reject it outright - usually the worst is that we suggest a different
approach to achieve the same result.

So if your feature is expected to require non-trivial development work, and
particularly if it adds new public APIs, then it is worth describing your
rough design on this mailing list before you start coding. This allows
people to suggest how to best fit your feature into the libvirt architecture,
hopefully avoiding the need for you to do complex re-writing 1/2 way through
coding. The other important thing is to make sure you follow the coding
standards in the HACKING file, and generally try to make your code fit in
with the style of existing work.

Regards,
Daniel
--

-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|