Open Source TN5250 Emulator

Scott Klement | 6 Dec 2004 00:11

Re: x5250 version 0.4.6 released


> I'm hoping that 0.4.6 is the last 0.4 release before 0.5.  If you find
> anything in tn5250 version 0.16.5 that can't be done with x5250 0.4.6
> please let me know.  x5250 and tn5250 should now match feature for feature
> and do it without mistakes.  If nothing wrong is found then this will be
> released as 0.5.0.  Then we can move on to the interesting stuff like
> proper keymapping.

a) "typeahead" (typing keys ahead of time while the system is busy.)
doesn't work properly, the keys appear to get into the keyboard buffer,
but do not get printed on the screen when they finally do get displayed.

To test this:

    type DLYJOB DLY(5) <enter>
    while that delay is running, type "WRKACTJOB" (do not press enter)

    when the delay completes, only part of the string "WRKACTJOB" will
    appear on the screen.  The cursor gets moved, but many of the
    characters you typed aren't painted.

b) It's not possible to use the left-control key as the error reset key.
   This should be the default, as it's what pretty much everyone is
   used to.

c) When you display something in reverse-image, the characters get
   reversed, but the underlines below them do not.  They should also
   be reversed.  When you have several lines of reverse-image on the
   screen, the reverse imaged spaces should look like a continuous area.
   Right now there are a few lines of black space in between them.

(Continue reading)

headers

James Rich | 6 Dec 2004 21:00

Re: x5250 version 0.4.6 released

On Sun, 5 Dec 2004, Scott Klement wrote:

> a) "typeahead" (typing keys ahead of time while the system is busy.)
> doesn't work properly, the keys appear to get into the keyboard buffer,
> but do not get printed on the screen when they finally do get displayed.

Oh yes, thanks for reminding me.  The keystrokes do get into the buffer 
(pressing enter after WRKACTJOB in your example should do the right 
thing) but the charaters do not get drawn.  I've added this to the list.

> b) It's not possible to use the left-control key as the error reset key.
>   This should be the default, as it's what pretty much everyone is
>   used to.

I'm thinking of leaving key map related issues until after 0.5.  I 
recognize that tn5250 has some keymapping abilities, but I'd rather 
address these issues later.

> c) When you display something in reverse-image, the characters get
>   reversed, but the underlines below them do not.  They should also
>   be reversed.  When you have several lines of reverse-image on the
>   screen, the reverse imaged spaces should look like a continuous area.
>   Right now there are a few lines of black space in between them.

Are you saying that underlined fields do not get reversed when blank?  Or 
that underlines should not be drawn in reverse fields?  I think the "few 
lines of black space in between" reversed fields are related to your next 
item below.

> d) There are extra/unnecessary blank pixels between each line of text on

(Continue reading)

headers

Scott Klement | 6 Dec 2004 03:24

Re: x5250 version 0.4.6 released


> d) There are extra/unnecessary blank pixels between each line of text on
>    the screen.  Compare an xterm screen with the same font to an x5250

Here's a patch that works for me that solves the problem with having too
many empty pixels between each line. Please try it, and consider it for
the next x5250 release.

diff -u ../../orig/x5250-0.4.6/src/x5250.c ./x5250.c
--- ../../orig/x5250-0.4.6/src/x5250.c	Wed Dec  1 20:24:16 2004
+++ ./x5250.c	Sun Dec  5 20:13:05 2004
 <at>  <at>  -1013,7 +1013,7  <at>  <at> 
     }
   else
     {
-      columnsepheight = font_height;
+      columnsepheight = font_height - 2;
     }

 <at>  <at>  -1066,73 +1066,73  <at>  <at> 
 		      XDrawLine (display, win, terminal->data->gcgreen,
 				 (widthbuf * underlinestart),
 				 ((font_height + ROWSPACING) * (i + 1)) +
-				 BASELINESPACE,
+				 BASELINESPACE + 2,
 				 (widthbuf * j),
 				 ((font_height + ROWSPACING) * (i + 1)) +
-				 BASELINESPACE);
+				 BASELINESPACE + 2);
 		      break;

(Continue reading)