Development of OpenSSL

Sander Temme | 2 Nov 2008 18:19

Re: [PATCH] keep CHIL engine from breaking in non-threaded situations [openssl.org #1736]


On Oct 29, 2008, at 8:33 AM, Geoff Thorpe wrote:

>> Same patch, applies clean to trunk and to 0.9.8-stable.  I actually
>> took it against trunk.  Doesn't seem to be touched by make update,
>> unless I'm missing something.
>
> It didn't remove the error string? Can you please try removing it
> manually and verifying everything builds ok? AFAICT, you are orphaning
> an error string that no longer needs to take up space in the code or
> compiled image.

The following compiles and tests cleanly on trunk and on the latest  
snapshot of 0.9.8-stable (with offset 1 in e_chil.c).  Also attached  
to prevent line wrap:

Index: engines/e_chil.c
===================================================================
RCS file: /home/openssl/cvs/openssl/engines/e_chil.c,v
retrieving revision 1.5
diff -u -r1.5 e_chil.c
--- engines/e_chil.c	18 Mar 2006 14:22:20 -0000	1.5
+++ engines/e_chil.c	31 Oct 2008 23:18:30 -0000
 <at>  <at>  -588,12 +588,6  <at>  <at> 
  			hwcrhk_globals.mutex_release = hwcrhk_mutex_unlock;
  			hwcrhk_globals.mutex_destroy = hwcrhk_mutex_destroy;
  			}
-		else if (CRYPTO_get_locking_callback() != NULL)
-			{
-			HWCRHKerr(HWCRHK_F_HWCRHK_INIT,HWCRHK_R_LOCKING_MISSING);

(Continue reading)

headers

Sander Temme | 11 Nov 2008 06:28

Re: [PATCH] keep CHIL engine from breaking in non-threaded situations [openssl.org #1736]


On Nov 2, 2008, at 9:19 AM, Sander Temme wrote:

> The following compiles and tests cleanly on trunk and on the latest  
> snapshot of 0.9.8-stable (with offset 1 in e_chil.c).  Also attached  
> to prevent line wrap:

Ping?

Thanks,

S.

> Index: engines/e_chil.c
> ===================================================================
> RCS file: /home/openssl/cvs/openssl/engines/e_chil.c,v
> retrieving revision 1.5
> diff -u -r1.5 e_chil.c
> --- engines/e_chil.c	18 Mar 2006 14:22:20 -0000	1.5
> +++ engines/e_chil.c	31 Oct 2008 23:18:30 -0000
>  <at>  <at>  -588,12 +588,6  <at>  <at> 
> 			hwcrhk_globals.mutex_release = hwcrhk_mutex_unlock;
> 			hwcrhk_globals.mutex_destroy = hwcrhk_mutex_destroy;
> 			}
> -		else if (CRYPTO_get_locking_callback() != NULL)
> -			{
> -			HWCRHKerr(HWCRHK_F_HWCRHK_INIT,HWCRHK_R_LOCKING_MISSING);
> -			ERR_add_error_data(1,"You HAVE to add dynamic locking callbacks  
> via CRYPTO_set_dynlock_{create,lock,destroy}_callback()");
> -			goto err;

(Continue reading)

headers

Sander Temme | 19 Nov 2008 01:22

Re: [PATCH] keep CHIL engine from breaking in non-threaded situations [openssl.org #1736]

On Nov 11, 2008, at 12:28 AM, Sander Temme wrote:

>
> On Nov 2, 2008, at 9:19 AM, Sander Temme wrote:
>
>> The following compiles and tests cleanly on trunk and on the latest  
>> snapshot of 0.9.8-stable (with offset 1 in e_chil.c).  Also  
>> attached to prevent line wrap:
>
> Ping?

Any chance to squeeze this simple, six line patch, that doesn't touch  
but a single source file, in before 0.9.8j is tagged?  Do we need more  
than Geoff Thorpe's ACK from 10/27/08?

Thanks,

S.

> Thanks,
>
> S.
>
>> Index: engines/e_chil.c
>> ===================================================================
>> RCS file: /home/openssl/cvs/openssl/engines/e_chil.c,v
>> retrieving revision 1.5
>> diff -u -r1.5 e_chil.c
>> --- engines/e_chil.c	18 Mar 2006 14:22:20 -0000	1.5

(Continue reading)

headers

Geoff Thorpe | 19 Nov 2008 16:18

Re: [PATCH] keep CHIL engine from breaking in non-threaded situations [openssl.org #1736]

On Tuesday 18 November 2008 19:22:55 Sander Temme wrote:
> On Nov 11, 2008, at 12:28 AM, Sander Temme wrote:
> > On Nov 2, 2008, at 9:19 AM, Sander Temme wrote:
> >> The following compiles and tests cleanly on trunk and on the latest
> >> snapshot of 0.9.8-stable (with offset 1 in e_chil.c).  Also
> >> attached to prevent line wrap:
> >
> > Ping?
>
> Any chance to squeeze this simple, six line patch, that doesn't touch
> but a single source file, in before 0.9.8j is tagged?  Do we need more
> than Geoff Thorpe's ACK from 10/27/08?

It's in now, please verify the next nightly snapshot.

Cheers,
Geoff

--

-- 
Un terrien, c'est un singe avec des clefs de char...
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev <at> openssl.org
Automated List Manager                           majordomo <at> openssl.org