headers
Christoph Hellwig | 29 Jul 2011 17:50
Favicon

[PATCH, RFC] jfs support for xfstests

The patch below adds basic jfs support to xfstests.  Unfortunately it
doesn't get very far, as test 001 already blows up with a kernel crash,
as do 011 and 013 as other random picks. 

Index: xfstests-dev/common.rc
===================================================================
--- xfstests-dev.orig/common.rc	2011-07-29 15:36:52.000000000 +0000
+++ xfstests-dev/common.rc	2011-07-29 15:39:41.000000000 +0000
 <at>  <at>  -102,6 +102,9  <at>  <at>  _mkfs_opts()
     gfs2)
 	export MKFS_OPTIONS="$GFS2_MKFS_OPTIONS -O -p lock_nolock"
 	;;
+    jfs)
+	export MKFS_OPTIONS="$JFS_MKFS_OPTIONS -q"
+	;;
     *)
 	;;
     esac

------------------------------------------------------------------------------
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
Permalink | Reply |
headers
Dave Kleikamp | 29 Jul 2011 18:03
Picon
Favicon

Re: [PATCH, RFC] jfs support for xfstests

On 07/29/2011 10:50 AM, Christoph Hellwig wrote:
> The patch below adds basic jfs support to xfstests.  Unfortunately it
> doesn't get very far, as test 001 already blows up with a kernel crash,
> as do 011 and 013 as other random picks.

Great :-)

Seems to be a good idea to support jfs. I'll carve out some time to
reproduce and debug the crashes.

Thanks,
Shaggy

> 
> 
> Index: xfstests-dev/common.rc
> ===================================================================
> --- xfstests-dev.orig/common.rc	2011-07-29 15:36:52.000000000 +0000
> +++ xfstests-dev/common.rc	2011-07-29 15:39:41.000000000 +0000
>  <at>  <at>  -102,6 +102,9  <at>  <at>  _mkfs_opts()
>      gfs2)
>  	export MKFS_OPTIONS="$GFS2_MKFS_OPTIONS -O -p lock_nolock"
>  	;;
> +    jfs)
> +	export MKFS_OPTIONS="$JFS_MKFS_OPTIONS -q"
> +	;;
>      *)
>  	;;
>      esac
>
(Continue reading)

Permalink | Reply |
headers
Dave Kleikamp | 1 Aug 2011 20:29
Picon
Favicon

[PATCH] jfs: flush journal completely before releasing metadata inodes

On 07/29/2011 11:03 AM, Dave Kleikamp wrote:
> On 07/29/2011 10:50 AM, Christoph Hellwig wrote:
>> The patch below adds basic jfs support to xfstests.  Unfortunately it
>> doesn't get very far, as test 001 already blows up with a kernel crash,
>> as do 011 and 013 as other random picks.
> 
> Great :-)
> 
> Seems to be a good idea to support jfs. I'll carve out some time to
> reproduce and debug the crashes.

This fixes a race during unmount. We need to not only make sure that
the journal is completely written, but that the metadata changes make
it to disk before releasing ipimap and ipbmap.

Signed-off-by: Dave Kleikamp <dave.kleikamp <at> oracle.com>
---
 fs/jfs/jfs_umount.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
index adcf92d..7971f37 100644
--- a/fs/jfs/jfs_umount.c
+++ b/fs/jfs/jfs_umount.c
 <at>  <at>  -68,7 +68,7  <at>  <at>  int jfs_umount(struct super_block *sb)
 		/*
 		 * Wait for outstanding transactions to be written to log:
 		 */
-		jfs_flush_journal(log, 1);
+		jfs_flush_journal(log, 2);
(Continue reading)

Permalink | Reply |
headers
Christoph Hellwig | 1 Aug 2011 20:32
Favicon

Re: [PATCH] jfs: flush journal completely before releasing metadata inodes

On Mon, Aug 01, 2011 at 01:29:26PM -0500, Dave Kleikamp wrote:
> On 07/29/2011 11:03 AM, Dave Kleikamp wrote:
> > On 07/29/2011 10:50 AM, Christoph Hellwig wrote:
> >> The patch below adds basic jfs support to xfstests.  Unfortunately it
> >> doesn't get very far, as test 001 already blows up with a kernel crash,
> >> as do 011 and 013 as other random picks.
> > 
> > Great :-)
> > 
> > Seems to be a good idea to support jfs. I'll carve out some time to
> > reproduce and debug the crashes.
> 
> This fixes a race during unmount. We need to not only make sure that
> the journal is completely written, but that the metadata changes make
> it to disk before releasing ipimap and ipbmap.

Looks sensible.  How far does a ./check -g auto get now?  Any other
failures?

------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
Permalink | Reply |
headers
Dave Kleikamp | 1 Aug 2011 22:04
Picon
Favicon

Re: [PATCH] jfs: flush journal completely before releasing metadata inodes


On 08/01/2011 01:32 PM, Christoph Hellwig wrote:
> On Mon, Aug 01, 2011 at 01:29:26PM -0500, Dave Kleikamp wrote:
>> On 07/29/2011 11:03 AM, Dave Kleikamp wrote:

>> This fixes a race during unmount. We need to not only make sure that
>> the journal is completely written, but that the metadata changes make
>> it to disk before releasing ipimap and ipbmap.
> 
> Looks sensible.  How far does a ./check -g auto get now?  Any other
> failures?

It runs through them all. A lot of tests get skipped claiming not to be
supported on jfs. A failure because jfs doesn't support fallocate and
hole-punch, but no crashes.

Shaggy

------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
Permalink | Reply |
headers
Christoph Hellwig | 2 Aug 2011 12:25
Favicon

Re: [PATCH] jfs: flush journal completely before releasing metadata inodes

On Mon, Aug 01, 2011 at 03:04:32PM -0500, Dave Kleikamp wrote:
> It runs through them all. A lot of tests get skipped claiming not to be
> supported on jfs. A failure because jfs doesn't support fallocate and
> hole-punch, but no crashes.

Looks like the fallocate feature tests are broken, I'll look into fixing
it.

------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
Permalink | Reply |
headers
Christoph Hellwig | 2 Aug 2011 12:25
Favicon

Re: [PATCH] jfs: flush journal completely before releasing metadata inodes

On Mon, Aug 01, 2011 at 03:04:32PM -0500, Dave Kleikamp wrote:
> It runs through them all. A lot of tests get skipped claiming not to be
> supported on jfs. A failure because jfs doesn't support fallocate and
> hole-punch, but no crashes.

Looks like the fallocate feature tests are broken, I'll look into fixing
it.

_______________________________________________
xfs mailing list
xfs <at> oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Permalink | Reply |
headers
Dave Kleikamp | 1 Aug 2011 22:04
Picon
Favicon

Re: [PATCH] jfs: flush journal completely before releasing metadata inodes


On 08/01/2011 01:32 PM, Christoph Hellwig wrote:
> On Mon, Aug 01, 2011 at 01:29:26PM -0500, Dave Kleikamp wrote:
>> On 07/29/2011 11:03 AM, Dave Kleikamp wrote:

>> This fixes a race during unmount. We need to not only make sure that
>> the journal is completely written, but that the metadata changes make
>> it to disk before releasing ipimap and ipbmap.
> 
> Looks sensible.  How far does a ./check -g auto get now?  Any other
> failures?

It runs through them all. A lot of tests get skipped claiming not to be
supported on jfs. A failure because jfs doesn't support fallocate and
hole-punch, but no crashes.

Shaggy

_______________________________________________
xfs mailing list
xfs <at> oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Permalink | Reply |
headers
Christoph Hellwig | 1 Aug 2011 20:32
Favicon

Re: [PATCH] jfs: flush journal completely before releasing metadata inodes

On Mon, Aug 01, 2011 at 01:29:26PM -0500, Dave Kleikamp wrote:
> On 07/29/2011 11:03 AM, Dave Kleikamp wrote:
> > On 07/29/2011 10:50 AM, Christoph Hellwig wrote:
> >> The patch below adds basic jfs support to xfstests.  Unfortunately it
> >> doesn't get very far, as test 001 already blows up with a kernel crash,
> >> as do 011 and 013 as other random picks.
> > 
> > Great :-)
> > 
> > Seems to be a good idea to support jfs. I'll carve out some time to
> > reproduce and debug the crashes.
> 
> This fixes a race during unmount. We need to not only make sure that
> the journal is completely written, but that the metadata changes make
> it to disk before releasing ipimap and ipbmap.

Looks sensible.  How far does a ./check -g auto get now?  Any other
failures?

_______________________________________________
xfs mailing list
xfs <at> oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Permalink | Reply |
headers
Dave Kleikamp | 1 Aug 2011 20:29
Picon
Favicon

[PATCH] jfs: flush journal completely before releasing metadata inodes

On 07/29/2011 11:03 AM, Dave Kleikamp wrote:
> On 07/29/2011 10:50 AM, Christoph Hellwig wrote:
>> The patch below adds basic jfs support to xfstests.  Unfortunately it
>> doesn't get very far, as test 001 already blows up with a kernel crash,
>> as do 011 and 013 as other random picks.
> 
> Great :-)
> 
> Seems to be a good idea to support jfs. I'll carve out some time to
> reproduce and debug the crashes.

This fixes a race during unmount. We need to not only make sure that
the journal is completely written, but that the metadata changes make
it to disk before releasing ipimap and ipbmap.

Signed-off-by: Dave Kleikamp <dave.kleikamp <at> oracle.com>
---
 fs/jfs/jfs_umount.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
index adcf92d..7971f37 100644
--- a/fs/jfs/jfs_umount.c
+++ b/fs/jfs/jfs_umount.c
 <at>  <at>  -68,7 +68,7  <at>  <at>  int jfs_umount(struct super_block *sb)
 		/*
 		 * Wait for outstanding transactions to be written to log:
 		 */
-		jfs_flush_journal(log, 1);
+		jfs_flush_journal(log, 2);
(Continue reading)

Permalink | Reply |
headers
Dave Kleikamp | 29 Jul 2011 18:03
Picon
Favicon

Re: [Jfs-discussion] [PATCH, RFC] jfs support for xfstests

On 07/29/2011 10:50 AM, Christoph Hellwig wrote:
> The patch below adds basic jfs support to xfstests.  Unfortunately it
> doesn't get very far, as test 001 already blows up with a kernel crash,
> as do 011 and 013 as other random picks.

Great :-)

Seems to be a good idea to support jfs. I'll carve out some time to
reproduce and debug the crashes.

Thanks,
Shaggy

> 
> 
> Index: xfstests-dev/common.rc
> ===================================================================
> --- xfstests-dev.orig/common.rc	2011-07-29 15:36:52.000000000 +0000
> +++ xfstests-dev/common.rc	2011-07-29 15:39:41.000000000 +0000
>  <at>  <at>  -102,6 +102,9  <at>  <at>  _mkfs_opts()
>      gfs2)
>  	export MKFS_OPTIONS="$GFS2_MKFS_OPTIONS -O -p lock_nolock"
>  	;;
> +    jfs)
> +	export MKFS_OPTIONS="$JFS_MKFS_OPTIONS -q"
> +	;;
>      *)
>  	;;
>      esac
>
(Continue reading)

Permalink | Reply |

Gmane