Re: Translating Zero Install

2009/6/4 Rene Lopez <rsl <at> members.fsf.org>:
> On Wed, Jun 3, 2009 at 4:59 PM, Rene Lopez <rsl <at> members.fsf.org> wrote:
>> I already have translated it and are just checking that everything is
>> in context but, as I thought when translating it, there are a lot of
>> missing strings and I'm "gettextizing" them; others are useless or I
>> haven't found where they appear. I think that you must keep in mind
>> translations when adding new strings so it can be easier to completely
>> translate them.
>>
> I want you to review my changes to the source to see what do you
> think, maybe I'm gettextizing something that should not be translated
> (because is parsed) or the contrary.

Looks fine to me. Probably don't need to translate asserts (since the
message should never get displayed), e.g.

   assert widget, _("Widget '%s' not found in glade file '%s'") %
(name, self.gladefile)

Although possibly some of the asserts can trigger in normal cases.
e.g. I should probably change

		assert impl, _("Failed to choose an implementation of %s") % uri

to something like:

		if not impl:
				raise SafeException(_("Failed to choose an implementation of %s") % uri)

> I haven't added the --version output, should I add it?