X.org development discussions and patch review ()

Chris Ball | 18 Feb 2011 05:53

Current tinderbox regression (xserver, randr)

http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build

rrcrtc.c: In function 'RRConvertCrtcConfig':
rrcrtc.c:1512: error: 'RR_CurrentScanoutPixmap' undeclared (first use in this function)
rrcrtc.c:1512: error: (Each undeclared identifier is reported only once
rrcrtc.c:1512: error: for each function it appears in.)

--

-- 
Chris Ball   <cjb@...>
One Laptop Per Child
_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

headers

Cyril Brulebois | 18 Feb 2011 09:21

Re: Current tinderbox regression (xserver, randr)

Chris Ball <cjb@...> (17/02/2011):
> http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build
> 
> rrcrtc.c: In function 'RRConvertCrtcConfig':
> rrcrtc.c:1512: error: 'RR_CurrentScanoutPixmap' undeclared (first use in this function)
> rrcrtc.c:1512: error: (Each undeclared identifier is reported only once
> rrcrtc.c:1512: error: for each function it appears in.)

Putting Keith in Cc. Fallout of the following commit in randrproto:

| commit 105a161a3f5fb67f5fe7e4119629d424672804aa
| Author: Keith Packard <keithp@...>
| Date:   Wed Feb 16 22:44:30 2011 -0800
| 
|     Make SetCrtcConfigs take flags bits to allow partial configuration changes
|     
|     Instead of requiring a complete new configuration to be computed,
|     allow the client to send a partial configuration with only the changed
|     values included. This simplifies clients so that they need not change
|     things they don't understand.
|     
|     This also removes the 'CurrentScanoutPixmap' hack as that is no longer
|     necessary.

                                     ↑↑↑

|     
|     Signed-off-by: Keith Packard <keithp@...>

KiBi.

(Continue reading)

headers

Chris Ball | 23 Feb 2011 04:36

Re: Current tinderbox regression (xserver, randr)

Hi Keith,

On Fri, Feb 18, 2011 at 09:21:06AM +0100, Cyril Brulebois wrote:
> Chris Ball <cjb@...> (17/02/2011):
> > http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build
> > 
> > rrcrtc.c: In function 'RRConvertCrtcConfig':
> > rrcrtc.c:1512: error: 'RR_CurrentScanoutPixmap' undeclared (first use in this function)
> > rrcrtc.c:1512: error: (Each undeclared identifier is reported only once
> > rrcrtc.c:1512: error: for each function it appears in.)
> 
> Putting Keith in Cc. Fallout of the following commit in randrproto:
> 
> | commit 105a161a3f5fb67f5fe7e4119629d424672804aa
> | Author: Keith Packard <keithp@...>
> | Date:   Wed Feb 16 22:44:30 2011 -0800
> | 
> |     Make SetCrtcConfigs take flags bits to allow partial configuration changes

The xserver HEAD build's been broken for about six days now due to this
commit.  Can we please fix it?

Thanks,

--

-- 
Chris Ball   <cjb@...>   <http://printf.net/>
One Laptop Per Child
_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel

(Continue reading)

headers

Joel Feiner | 23 Feb 2011 06:56

Re: Current tinderbox regression (xserver, randr)

On Tue, Feb 22, 2011 at 10:36 PM, Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org> wrote:

Hi Keith,

On Fri, Feb 18, 2011 at 09:21:06AM +0100, Cyril Brulebois wrote:
> Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org> (17/02/2011):
> > http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build
> >
> > rrcrtc.c: In function 'RRConvertCrtcConfig':
> > rrcrtc.c:1512: error: 'RR_CurrentScanoutPixmap' undeclared (first use in this function)
> > rrcrtc.c:1512: error: (Each undeclared identifier is reported only once
> > rrcrtc.c:1512: error: for each function it appears in.)
>
> Putting Keith in Cc. Fallout of the following commit in randrproto:
>
> | commit 105a161a3f5fb67f5fe7e4119629d424672804aa
> | Author: Keith Packard <keithp <at> keithp.com>
> | Date: Wed Feb 16 22:44:30 2011 -0800
> |
> | Make SetCrtcConfigs take flags bits to allow partial configuration changes

The xserver HEAD build's been broken for about six days now due to this
commit. Can we please fix it?

I deleted the if-statement and the line it governs without any ill effect for those looking for a workaround until this gets fixed (I too am annoyed that it's taken this long).

Thanks,

--
Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org> <http://printf.net/>

One Laptop Per Child
_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

--
- Joel

_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

headers

Colin Harrison | 23 Feb 2011 11:28

Re: Current tinderbox regression (xserver, randr)

Hi,

I think Keith was waiting for someone to review this patch...

http://lists.x.org/archives/xorg-devel/2011-February/019390.html

and RandR 1.4 fixes...

http://lists.x.org/archives/xorg-devel/2011-February/019389.html

The patch makes the code compile for me (MinGW for Windows)..but I haven't
got suitable tests to say Rand 1.4 is OK.

Thanks,
Colin Harrison

_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel