headers
Peter Hutterer | 19 May 2011 07:36

[PATCH] xfree86: bump to video ABI 11

We've broken the ABI with some commit and drivers built against ABI 10
happily segfault now.

Signed-off-by: Peter Hutterer <peter.hutterer@...>
---
Hints as to which commit actually broke it would be appreciated, I didn't
really look hard.

 hw/xfree86/common/xf86Module.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/xfree86/common/xf86Module.h b/hw/xfree86/common/xf86Module.h
index 581047d..94f17e9 100644
--- a/hw/xfree86/common/xf86Module.h
+++ b/hw/xfree86/common/xf86Module.h
 <at>  <at>  -82,7 +82,7  <at>  <at>  typedef enum {
  * mask is 0xFFFF0000.
  */
 #define ABI_ANSIC_VERSION	SET_ABI_VERSION(0, 4)
-#define ABI_VIDEODRV_VERSION	SET_ABI_VERSION(10, 0)
+#define ABI_VIDEODRV_VERSION	SET_ABI_VERSION(11, 0)
 #define ABI_XINPUT_VERSION	SET_ABI_VERSION(12, 2)
 #define ABI_EXTENSION_VERSION	SET_ABI_VERSION(5, 0)
 #define ABI_FONT_VERSION	SET_ABI_VERSION(0, 6)
--

-- 
1.7.4.4

_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
(Continue reading)

Permalink | Reply |
headers
Cyril Brulebois | 23 May 2011 14:57
Picon
Favicon

Re: [PATCH] xfree86: bump to video ABI 11

Hi Peter,

Peter Hutterer <peter.hutterer@...> (19/05/2011):
> We've broken the ABI with some commit and drivers built against ABI 10
> happily segfault now.

not reproduced with the virtualbox thingy, but trivially reproduced
with the ati driver.

> Hints as to which commit actually broke it would be appreciated, I
> didn't really look hard.

git bisect between 1.10.0 and master points to:
| commit 51f353d0a0d116af16d7d9590cadef6c56328746
| Author: Adam Jackson <ajax@...>
| Date:   Mon Feb 28 13:10:20 2011 -0500
| 
|     dix: Fix ATOM typedef
|     
|     unsigned long is needlessly large on LP64.  Use uint32_t instead.
|     
|     Reviewed-by: Daniel Stone <daniel@...>
|     Signed-off-by: Adam Jackson <ajax@...>

Reverting that partially (see attached patch) makes ati work again for
trivial tasks (I didn't test xv, glx, and compositing very heavily),
with current master.

(I haven't rebuilt ati at all, was built against 1.10, and not changed
since then.)
(Continue reading)

Permalink | Reply |
headers
Keith Packard | 23 May 2011 18:37
Favicon
Gravatar

Re: [PATCH] xfree86: bump to video ABI 11

On Mon, 23 May 2011 14:57:19 +0200, Cyril Brulebois <kibi@...> wrote:

> Reverting that partially (see attached patch) makes ati work again for
> trivial tasks (I didn't test xv, glx, and compositing very heavily),
> with current master.

Thanks for figuring out where the ABI changed; I'll go ahead and merge
Peter's ABI bump.

--

-- 
keith.packard@...

_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Permalink | Reply |
headers
Alan Coopersmith | 23 May 2011 19:51
Picon
Favicon
Gravatar

Re: [PATCH] xfree86: bump to video ABI 11

On 05/23/11 09:37 AM, Keith Packard wrote:
> On Mon, 23 May 2011 14:57:19 +0200, Cyril Brulebois <kibi@...> wrote:
> 
>> Reverting that partially (see attached patch) makes ati work again for
>> trivial tasks (I didn't test xv, glx, and compositing very heavily),
>> with current master.
> 
> Thanks for figuring out where the ABI changed; I'll go ahead and merge
> Peter's ABI bump.

Since ATOM is not specific to video drivers, do any of the other ABI
versions need to bumped as well?

--

-- 
	-Alan Coopersmith-        alan.coopersmith@...
	 Oracle Solaris Platform Engineering: X Window System

_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Permalink | Reply |
headers
Peter Hutterer | 24 May 2011 04:18

Re: [PATCH] xfree86: bump to video ABI 11

On Mon, May 23, 2011 at 10:51:35AM -0700, Alan Coopersmith wrote:
> On 05/23/11 09:37 AM, Keith Packard wrote:
> > On Mon, 23 May 2011 14:57:19 +0200, Cyril Brulebois
<kibi@...> wrote:
> > 
> >> Reverting that partially (see attached patch) makes ati work again for
> >> trivial tasks (I didn't test xv, glx, and compositing very heavily),
> >> with current master.
> > 
> > Thanks for figuring out where the ABI changed; I'll go ahead and merge
> > Peter's ABI bump.
> 
> Since ATOM is not specific to video drivers, do any of the other ABI
> versions need to bumped as well?

I hadn't noticed any breakage so far but I've gone some changes for the ABI
anyway. I'll merge them in with an input ABI bump, so we get that out of the
way too.

Cheers,
  Peter
_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Permalink | Reply |
headers
Keith Packard | 23 May 2011 18:45
Favicon
Gravatar

Re: [PATCH] xfree86: bump to video ABI 11

On Thu, 19 May 2011 15:36:29 +1000, Peter Hutterer <peter.hutterer@...t> wrote:
> We've broken the ABI with some commit and drivers built against ABI 10
> happily segfault now.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer@...>

Merged.
   1fb501a..0de7cec  master -> master

--

-- 
keith.packard@...

_______________________________________________
xorg-devel@...: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Permalink | Reply |

Gmane