25 Apr 2002 18:33
Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c
Pierre Muller <muller <at> cerbere.u-strasbg.fr>
2002-04-25 16:33:04 GMT
2002-04-25 16:33:04 GMT
At 17:38 25/04/2002 , Andrew Cagney a écrit: >>On Wed, Apr 24, 2002 at 11:50:40AM -0700, Michael Snyder wrote: >> >>>Daniel Jacobowitz wrote: >> >>> > > On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote: >> >>> > > This is a second of the files that I listed in >>> > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html >>> > > as still having direct uses of stderr. >>> > > >>> > > I did not fix a 80 char overflow, because I didn't find a good way to do it: >>> > > If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" >>> > > with gdb_stderr, I still get an overflow, how show I indent the args then? >>> > > Should I break the string constant? >> >>> > > Yes, I'd recommend: >>> > > - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", >>> > + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. " >>> > "Shouldn't happen.\n", > >The other is the more traditional: > > ..... "\ >Psymtab for ......\n\ >.......\n" > >(the ``\'' at the end of the line is needed. > >>>(Continue reading)
I suspect danielJ slightly prefers the ISO C form, so
perhaps go with that.
Andrew
RSS Feed