Pierre Muller | 25 Apr 2002 18:33
Picon
Picon

Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c

At 17:38 25/04/2002 , Andrew Cagney a écrit:
>>On Wed, Apr 24, 2002 at 11:50:40AM -0700, Michael Snyder wrote:
>>
>>>Daniel Jacobowitz wrote:
>>
>>> > > On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote:
>>
>>> > > This is a second of the files that I listed in
>>> > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html
>>> > > as still having direct uses of stderr.
>>> > >
>>> > > I did not fix a 80 char overflow, because I didn't find a good way to do it:
>>> > > If I try to align the string "Psymtab for %s already read in.  Shouldn't happen.\n"
>>> > > with gdb_stderr, I still get an overflow, how show I indent the args then?
>>> > > Should I break the string constant?
>>
>>> > > Yes, I'd recommend:
>>> > > -      fprintf (stderr, "Psymtab for %s already read in.  Shouldn't happen.\n",
>>> > +      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  "
>>> > "Shouldn't happen.\n",
>
>The other is the more traditional:
>
>         ..... "\
>Psymtab for ......\n\
>.......\n"
>
>(the ``\'' at the end of the line is needed.
>
>>>
(Continue reading)

Andrew Cagney | 25 Apr 2002 19:16
Picon

Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c

> (Pierre, yes, ok with a tweak).
> 
> Sorry, but I din't understand which version of the
> modification I should use here...

Either is acceptable and either works.  (Personally, it really doesn't 
worry me :-)  I suspect danielJ slightly prefers the ISO C form, so 
perhaps go with that.

Andrew

Daniel Jacobowitz | 25 Apr 2002 20:52

Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c

On Thu, Apr 25, 2002 at 01:16:15PM -0400, Andrew Cagney wrote:
> >(Pierre, yes, ok with a tweak).
> >
> >Sorry, but I din't understand which version of the
> >modification I should use here...
> 
> Either is acceptable and either works.  (Personally, it really doesn't 
> worry me :-)  I suspect danielJ slightly prefers the ISO C form, so 
> perhaps go with that.

Nod.  I find that the \-newline form is uglier w.r.t. indentation, so
if no one else cares...

--

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


Gmane