headers
teawater | 2 Mar 2009 07:10
Picon
Gravatar

[RFA] Patch to fix "reverse-step" command error

Hi Michael,

This patch is for bug in
http://sourceware.org/ml/gdb-patches/2009-02/msg00246.html.

The reason of bug is when inferior reverse exection into dynsym
resolve code, gdb doesn't insert breakpoint in right address.
It just happen in some distributions for example SLED.

This patch make gdb insert breakpoint in right address or step in that case.

2008-03-02  Hui Zhu  <teawater <at> gmail.com>

       * infrun.c (handle_inferior_event): Make inferior insert
       breakpoint at right address or step in reverse and it stepped
       into dynsym resolve code.

Thanks,
Hui

---
 infrun.c |   31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

--- a/infrun.c
+++ b/infrun.c
 <at>  <at>  -3412,13 +3412,34  <at>  <at>  infrun: BPSTAT_WHAT_SET_LONGJMP_RESUME (

       if (pc_after_resolver)
(Continue reading)

Permalink | Reply |
headers
Hui Zhu | 6 May 2009 07:31
Picon
Gravatar

Re: [RFA] Patch to fix "reverse-step" command error

Hi Marc,

I cannot reproduce this issue with cvs-head.
Could you please help me test with this issue?
If both of us cannot reproduce this issue,  I think I can give up this patch.

Thanks,
Hui

On Mon, Mar 2, 2009 at 14:10, teawater <teawater <at> gmail.com> wrote:
> Hi Michael,
>
> This patch is for bug in
> http://sourceware.org/ml/gdb-patches/2009-02/msg00246.html.
>
> The reason of bug is when inferior reverse exection into dynsym
> resolve code, gdb doesn't insert breakpoint in right address.
> It just happen in some distributions for example SLED.
>
> This patch make gdb insert breakpoint in right address or step in that case.
>
> 2008-03-02  Hui Zhu  <teawater <at> gmail.com>
>
>       * infrun.c (handle_inferior_event): Make inferior insert
>       breakpoint at right address or step in reverse and it stepped
>       into dynsym resolve code.
>
> Thanks,
> Hui
>
(Continue reading)

Permalink | Reply |
headers
Hui Zhu | 6 May 2009 10:13
Picon
Gravatar

Re: [RFA] Patch to fix "reverse-step" command error

Hi Marc and Michael,

Sorry I forget this issue just reproduce in SLED 10.

I reproduced it with cvs-head and patch can fix it.  Michael, Please
help me review it.

The attachment is the new patch follow cvs-head.

2009-05-06  Hui Zhu  <teawater <at> gmail.com>

       * infrun.c (handle_inferior_event): Make inferior insert
       breakpoint at right address or step in reverse and it stepped
       into dynsym resolve code.

Thanks,
Hui

On Wed, May 6, 2009 at 13:31, Hui Zhu <teawater <at> gmail.com> wrote:
> Hi Marc,
>
> I cannot reproduce this issue with cvs-head.
> Could you please help me test with this issue?
> If both of us cannot reproduce this issue,  I think I can give up this patch.
>
> Thanks,
> Hui
>
>
> On Mon, Mar 2, 2009 at 14:10, teawater <teawater <at> gmail.com> wrote:
(Continue reading)

Permalink | Reply |
headers
Hui Zhu | 11 May 2009 09:07
Picon
Gravatar

Re: [RFA] Patch to fix "reverse-step" command error

PING

On Wed, May 6, 2009 at 16:13, Hui Zhu <teawater <at> gmail.com> wrote:
> Hi Marc and Michael,
>
> Sorry I forget this issue just reproduce in SLED 10.
>
> I reproduced it with cvs-head and patch can fix it.  Michael, Please
> help me review it.
>
> The attachment is the new patch follow cvs-head.
>
> 2009-05-06  Hui Zhu  <teawater <at> gmail.com>
>
>       * infrun.c (handle_inferior_event): Make inferior insert
>       breakpoint at right address or step in reverse and it stepped
>       into dynsym resolve code.
>
> Thanks,
> Hui
>
> On Wed, May 6, 2009 at 13:31, Hui Zhu <teawater <at> gmail.com> wrote:
>> Hi Marc,
>>
>> I cannot reproduce this issue with cvs-head.
>> Could you please help me test with this issue?
>> If both of us cannot reproduce this issue,  I think I can give up this patch.
>>
>> Thanks,
>> Hui
(Continue reading)

Permalink | Reply |
headers
Hui Zhu | 9 Jun 2009 04:18
Picon
Gravatar

Re: [RFA] Patch to fix "reverse-step" command error

PING

On Mon, May 11, 2009 at 15:07, Hui Zhu<teawater <at> gmail.com> wrote:
> PING
>
> On Wed, May 6, 2009 at 16:13, Hui Zhu <teawater <at> gmail.com> wrote:
>> Hi Marc and Michael,
>>
>> Sorry I forget this issue just reproduce in SLED 10.
>>
>> I reproduced it with cvs-head and patch can fix it.  Michael, Please
>> help me review it.
>>
>> The attachment is the new patch follow cvs-head.
>>
>> 2009-05-06  Hui Zhu  <teawater <at> gmail.com>
>>
>>       * infrun.c (handle_inferior_event): Make inferior insert
>>       breakpoint at right address or step in reverse and it stepped
>>       into dynsym resolve code.
>>
>> Thanks,
>> Hui
>>
>> On Wed, May 6, 2009 at 13:31, Hui Zhu <teawater <at> gmail.com> wrote:
>>> Hi Marc,
>>>
>>> I cannot reproduce this issue with cvs-head.
>>> Could you please help me test with this issue?
>>> If both of us cannot reproduce this issue,  I think I can give up this patch.
(Continue reading)

Permalink | Reply |
headers
Michael Snyder | 22 Jun 2009 01:11
Favicon

Re: [RFA] Patch to fix "reverse-step" command error

Hui Zhu wrote:
> PING

Hui, Marc, I just posted a new patch that should replace this one.
Please review http://sourceware.org/ml/gdb-patches/2009-06/msg00551.html

Thanks,
Michael
Permalink | Reply |
headers
Marc Khouzam | 22 Jun 2009 03:51
Picon
Favicon
Gravatar

RE: [RFA] Patch to fix "reverse-step" command error

> -----Original Message-----
> From: Michael Snyder [mailto:msnyder <at> vmware.com] 
> Sent: June-21-09 7:12 PM
> To: Hui Zhu
> Cc: Marc Khouzam; gdb-patches <at> sourceware.org
> Subject: Re: [RFA] Patch to fix "reverse-step" command error
> 
> Hui Zhu wrote:
> > PING
> 
> Hui, Marc, I just posted a new patch that should replace this one.
> Please review 
> http://sourceware.org/ml/gdb-patches/2009-06/msg00551.html

Thanks for that.

I don't have my SLED right now, which is where I could see the
problem.  I may be able to get my hands on one the week after next.
If Hui hasn't been able to test this until that time, then 
I will give it a try myself.

Thanks again.

> 
> Thanks,
> Michael
>
Permalink | Reply |
headers
Michael Snyder | 22 Jun 2009 05:45
Favicon

Re: [RFA] Patch to fix "reverse-step" command error

Marc Khouzam wrote:
>> -----Original Message-----
>> From: Michael Snyder [mailto:msnyder <at> vmware.com] 
>> Sent: June-21-09 7:12 PM
>> To: Hui Zhu
>> Cc: Marc Khouzam; gdb-patches <at> sourceware.org
>> Subject: Re: [RFA] Patch to fix "reverse-step" command error
>>
>> Hui Zhu wrote:
>>> PING
>> Hui, Marc, I just posted a new patch that should replace this one.
>> Please review 
>> http://sourceware.org/ml/gdb-patches/2009-06/msg00551.html
> 
> Thanks for that.
> 
> I don't have my SLED right now, which is where I could see the
> problem.  I may be able to get my hands on one the week after next.
> If Hui hasn't been able to test this until that time, then 
> I will give it a try myself.

By the way, I was able to see the mis-behavior on RHEL4.
Permalink | Reply |
headers
Hui Zhu | 22 Jun 2009 04:18
Picon
Gravatar

Re: [RFA] Patch to fix "reverse-step" command error

On Mon, Jun 22, 2009 at 09:51, Marc Khouzam<marc.khouzam <at> ericsson.com> wrote:
>> -----Original Message-----
>> From: Michael Snyder [mailto:msnyder <at> vmware.com]
>> Sent: June-21-09 7:12 PM
>> To: Hui Zhu
>> Cc: Marc Khouzam; gdb-patches <at> sourceware.org
>> Subject: Re: [RFA] Patch to fix "reverse-step" command error
>>
>> Hui Zhu wrote:
>> > PING
>>
>> Hui, Marc, I just posted a new patch that should replace this one.
>> Please review
>> http://sourceware.org/ml/gdb-patches/2009-06/msg00551.html
>
> Thanks for that.
>
> I don't have my SLED right now, which is where I could see the
> problem.  I may be able to get my hands on one the week after next.
> If Hui hasn't been able to test this until that time, then
> I will give it a try myself.
>
> Thanks again.
>
Don't warry about it, Marc.  I keep SLED 10 in virtualbox.
I will try this patch in SLED 10.

Thanks,
Hui
(Continue reading)

Permalink | Reply |

Gmane