headers
Doug Evans | 20 Jun 2012 00:26
Picon
Favicon

[doc RFA] "set debug dwarf2-read" and "set debug symtab-create"

Hi.

I'm committing this after a doc RFA.
[But feel free to suggest changes or enhancements.]

This adds two options for debugging dwarf2 debug info reading and symbol table
creation, and adds the beginnings of some useful messages for such.

2012-06-19  Doug Evans  <dje <at> google.com>

	* NEWS: Mention new options "set debug dwarf2-read" and
	"set debug symtab-create".
	* dwarf2read.c (dwarf2_read_debug): New static global.
	(dwarf2_build_psymtabs_hard): Add debugging printfs.
	(process_queue): Ditto.
	(process_full_comp_unit): Ditto.
	(_initialize_dwarf2_read): Add new option "set debug dwarf2-read".
	* elfread.c (elf_symfile_read): Add debugging printf.
	* minsyms.c (install_minimal_symbols): Ditto.
	* psymtab.c (allocate_psymtab): Ditto.
	* symfile.c (allocate_symtab): Ditto.
	* symtab.c (symtab_create_debug): New global.
	(_initialize_symtab): Add new option "set debug symtab-create".
	* symtab.h (symtab_create_debug): Declare.

	doc/
	* gdb.texinfo (Debugging Output): Document debug options dwarf2-read
	and symtab-create.

diff --git a/gdb/NEWS b/gdb/NEWS
(Continue reading)

Permalink | Reply |
headers
Tom Tromey | 22 Jun 2012 16:06
Picon
Favicon

Re: [doc RFA] "set debug dwarf2-read" and "set debug symtab-create"

>>>>> "Doug" == Doug Evans <dje <at> google.com> writes:

Doug> I'm committing this after a doc RFA.
Doug> [But feel free to suggest changes or enhancements.]

Seems nice; I've wanted something like this before.  I have one
suggestion:

Doug>  <at>  <at>  -5286,6 +5300,13  <at>  <at>  process_queue (void)

Doug> +      fprintf_unfiltered (gdb_stdlog,
Doug> +			  "Expanding one or more symtabs of objfile %s ...\n",
Doug> +			  dwarf2_per_objfile->objfile->name);

This seems a little vague; it would be nice to, say, print the CU offset
here.

Tom
Permalink | Reply |
headers
Doug Evans | 24 Jun 2012 00:58
Picon
Favicon

Re: [doc RFA] "set debug dwarf2-read" and "set debug symtab-create"

On Fri, Jun 22, 2012 at 7:06 AM, Tom Tromey <tromey <at> redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje <at> google.com> writes:
>
> Doug> I'm committing this after a doc RFA.
> Doug> [But feel free to suggest changes or enhancements.]
>
> Seems nice; I've wanted something like this before.  I have one
> suggestion:
>
> Doug>  <at>  <at>  -5286,6 +5300,13  <at>  <at>  process_queue (void)
>
> Doug> +      fprintf_unfiltered (gdb_stdlog,
> Doug> +                   "Expanding one or more symtabs of objfile %s ...\n",
> Doug> +                   dwarf2_per_objfile->objfile->name);
>
> This seems a little vague; it would be nice to, say, print the CU offset
> here.
>
> Tom

This message is part A of a two part set.
The other part is:

 <at>  <at>  -5690,6 +5717,14  <at>  <at>  process_full_comp_unit (struct
dwarf2_per_cu_data *per_cu,
   struct cleanup *back_to, *delayed_list_cleanup;
   CORE_ADDR baseaddr;

+  if (dwarf2_read_debug)
+    {
(Continue reading)

Permalink | Reply |
headers
Doug Evans | 26 Jun 2012 17:45
Picon
Favicon

Re: [doc RFA] "set debug dwarf2-read" and "set debug symtab-create"

Hi.  "Ping." :-)

On Tue, Jun 19, 2012 at 3:26 PM, Doug Evans <dje <at> google.com> wrote:
> Hi.
>
> I'm committing this after a doc RFA.
> [But feel free to suggest changes or enhancements.]
>
> This adds two options for debugging dwarf2 debug info reading and symbol table
> creation, and adds the beginnings of some useful messages for such.
>
> 2012-06-19  Doug Evans  <dje <at> google.com>
>
>        * NEWS: Mention new options "set debug dwarf2-read" and
>        "set debug symtab-create".
>        * dwarf2read.c (dwarf2_read_debug): New static global.
>        (dwarf2_build_psymtabs_hard): Add debugging printfs.
>        (process_queue): Ditto.
>        (process_full_comp_unit): Ditto.
>        (_initialize_dwarf2_read): Add new option "set debug dwarf2-read".
>        * elfread.c (elf_symfile_read): Add debugging printf.
>        * minsyms.c (install_minimal_symbols): Ditto.
>        * psymtab.c (allocate_psymtab): Ditto.
>        * symfile.c (allocate_symtab): Ditto.
>        * symtab.c (symtab_create_debug): New global.
>        (_initialize_symtab): Add new option "set debug symtab-create".
>        * symtab.h (symtab_create_debug): Declare.
>
>        doc/
>        * gdb.texinfo (Debugging Output): Document debug options dwarf2-read
(Continue reading)

Permalink | Reply |
headers
Eli Zaretskii | 26 Jun 2012 18:26
Picon

Re: [doc RFA] "set debug dwarf2-read" and "set debug symtab-create"

> Date: Tue, 26 Jun 2012 08:45:04 -0700
> From: Doug Evans <dje <at> google.com>
> Cc: gdb-patches <gdb-patches <at> sourceware.org>
> 
> Hi.  "Ping." :-)

Sorry, but your wording was ambiguous:

> > I'm committing this after a doc RFA.

I interpreted that as meaning "doc review was already done, I'm
committing this".

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
>  <at>  <at>  -462,6 +462,16  <at>  <at>  tstop [NOTES]
>
>  * New options
>
> +set debug dwarf2-read
> +show debug dwarf2-read
> +  Turns on or off display of GDB info related to reading DWARF debugging
> +  information.  The default is off.

I'd prefer to say "display of debugging messages related to reading
DWARF debug info".

> + <at> item set debug dwarf2-read
> + <at> cindex DWARF2 Reading
> +Turns on or off display of  <at> value{GDBN} info related to reading
(Continue reading)

Permalink | Reply |
headers
Doug Evans | 26 Jun 2012 22:16
Picon
Favicon

Re: [doc RFA] "set debug dwarf2-read" and "set debug symtab-create"

On Tue, Jun 26, 2012 at 9:26 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > Date: Tue, 26 Jun 2012 08:45:04 -0700
> > From: Doug Evans <dje <at> google.com>
> > Cc: gdb-patches <gdb-patches <at> sourceware.org>
> >
> > Hi.  "Ping." :-)
>
> Sorry, but your wording was ambiguous:
>
> > > I'm committing this after a doc RFA.
>
> I interpreted that as meaning "doc review was already done, I'm
> committing this".
>
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> >  <at>  <at>  -462,6 +462,16  <at>  <at>  tstop [NOTES]
> >
> >  * New options
> >
> > +set debug dwarf2-read
> > +show debug dwarf2-read
> > +  Turns on or off display of GDB info related to reading DWARF debugging
> > +  information.  The default is off.
>
> I'd prefer to say "display of debugging messages related to reading
> DWARF debug info".
>
> > + <at> item set debug dwarf2-read
(Continue reading)

Permalink | Reply |

Gmane