For patch submissions and discussion

Keith Seitz | 16 Aug 2012 22:15

[RFA 2/3] c++/13356: set/show check type

Hi,

This patch is the real meat of the bug, in which the user yearns for a 
way to permit some specialized type conversions which violate the standard.

I've introduced a new badness level for this conversion, and return it 
when strict type checking is disabled. Most of the rest of the patch is 
the "new" set/show check type command and tests. Documentation is in the 
next patch.

Comments/questions/concerns?
Keith

ChangeLog
2012-08-16  Keith Seitz  <keiths <at> redhat.com>

	PR c++/13356
	* gdbtypes.c (strict_type_checking): New variable.
	(show_strict_type_checking): New function.
	(rank_one_type): Return NS_POINTER_INTEGER_CONVERSION_BADNESS
	if strict type checking is disabled.
	(_initialize_gdbtypes): Add "check type" subcommand.
	* gdbtypes.h (NS_INTEGER_POINTER_CONVERSION_BADNESS): New struct.

teestuite/ChangeLog
2012-08-16  Keith Seitz  <keiths <at> redhat.com>

	PR c++/13356
	* gdb.base/default.exp: Update all "check type" tests.
	* gdb.base/help.exp: Likewise.

(Continue reading)

headers

Tom Tromey | 17 Aug 2012 18:27

Re: [RFA 2/3] c++/13356: set/show check type

>>>>> "Keith" == Keith Seitz <keiths <at> redhat.com> writes:

Keith> I've introduced a new badness level for this conversion, and return it
Keith> when strict type checking is disabled. Most of the rest of the patch
Keith> is the "new" set/show check type command and tests. Documentation is
Keith> in the next patch.

Ok.  Thanks for doing this.  Also, please send a follow-up to the gcc
thread when you check it in.

Tom

headers

Keith Seitz | 17 Aug 2012 19:38

Re: [RFA 2/3] c++/13356: set/show check type

On 08/17/2012 09:27 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths <at> redhat.com> writes:
>
> Keith> I've introduced a new badness level for this conversion, and return it
> Keith> when strict type checking is disabled. Most of the rest of the patch
> Keith> is the "new" set/show check type command and tests. Documentation is
> Keith> in the next patch.
>
> Ok.

All committed.

> Thanks for doing this.  Also, please send a follow-up to the gcc
> thread when you check it in.

Will update the PR and send email shortly.

Thank you Eli and Tom for the speedy review!

Keith