Openstreetmap dev list ()

headers

Ian Dees | 11 Jul 2012 22:23

[OSM-dev] API change

Andy made a commit that changed the API response for nodes.

http://git.osm.org/rails.git/commitdiff/2c67c07

Previously, visible="false" nodes would include their lat/lon. Now such nodes will no longer include lat/lon.

At the very least this breaks some functionality in JOSM.

_______________________________________________
dev mailing list
dev <at> openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev

headers

Richard Fairhurst | 11 Jul 2012 22:51

Re: [OSM-dev] API change

Ian Dees wrote:
> Andy made a commit that changed the API response for nodes.
> http://git.osm.org/rails.git/commitdiff/2c67c07
> Previously, visible="false" nodes would include their lat/lon. Now 
> such nodes will no longer include lat/lon.

For background: this is pretty much essential to the functioning of the
redaction bot. The previous behaviour was inconsistent with the rest of the
API - deleted ways and relations don't return any content - so this didn't
seem the most outrageous change to work.

In an ideal world we would like to have given more warning. But as a former
JOSM maintainer has proudly proclaimed beforehand "Software whose
programmers whine about having to make a change deserves to die, or be
banned", then I have no doubt that JOSM will, as ever, rise to the
challenge.

(Frederik and I love each other really.)

cheers
Richard

--
View this message in context: http://gis.19327.n5.nabble.com/API-change-tp5716151p5716153.html
Sent from the Developer Discussion mailing list archive at Nabble.com.

headers

Frederik Ramm | 12 Jul 2012 08:55

Re: [OSM-dev] API change

Hi,

On 07/11/12 22:51, Richard Fairhurst wrote:
> In an ideal world we would like to have given more warning. But as a former
> JOSM maintainer has proudly proclaimed beforehand "Software whose
> programmers whine about having to make a change deserves to die, or be
> banned", then I have no doubt that JOSM will, as ever, rise to the
> challenge.

It's high time that JOSM starts to play in Potlatch's league. Let's 
remove 90% of the features ;)

I think this discussion needs to be escalated to a higher level: 
http://twitpic.com/7pwgld

Bye
Frederik

--

-- 
Frederik Ramm  ##  eMail frederik <at> remote.org  ##  N49°00'09" E008°23'33"

headers

Jochen Topf | 12 Jul 2012 09:15

Re: [OSM-dev] API change

On Thu, Jul 12, 2012 at 08:55:09AM +0200, Frederik Ramm wrote:
> On 07/11/12 22:51, Richard Fairhurst wrote:
> >In an ideal world we would like to have given more warning. But as a former
> >JOSM maintainer has proudly proclaimed beforehand "Software whose
> >programmers whine about having to make a change deserves to die, or be
> >banned", then I have no doubt that JOSM will, as ever, rise to the
> >challenge.
> 
> It's high time that JOSM starts to play in Potlatch's league. Let's
> remove 90% of the features ;)
> 
> I think this discussion needs to be escalated to a higher level:
> http://twitpic.com/7pwgld

I am glad you two are having fun...

But is this change documented somewhere now? Are there test cases I could test
my software against? There are a few more programs reading those XML files, you
know...

Jochen
--

-- 
Jochen Topf  jochen <at> remote.org  http://www.remote.org/jochen/  +49-721-388298

headers

Frederik Ramm | 12 Jul 2012 09:23

Re: [OSM-dev] API change

Hi,

On 07/12/12 09:15, Jochen Topf wrote:
> But is this change documented somewhere now?

I think all we currently have to offer is this:

http://git.openstreetmap.org/rails.git/commit/2c67c079ac39cefd3b096524fc0b7364b0eb21d7

Of course anyone is welcome to fix any API documentation they might find 
accordingly!

 > Are there test cases I could test
 > my software against?

As for test cases, downloading the XML for *any* deleted node will show 
the changed XML; if you want to look at what the bot does specifically, 
pick one of these changesets:

http://www.openstreetmap.org/user/OSMF%20Redaction%20Account/edits

> There are a few more programs reading those XML files, you
> know...

There haven't been any changes to *file* formats yet, just transfer 
formats; the planet file doesn't have deleted nodes, and the history 
planet export script hasn't been modified yet (but will probably be in 
due course).

Bye
Frederik

--

-- 
Frederik Ramm  ##  eMail frederik <at> remote.org  ##  N49°00'09" E008°23'33"

headers

Jochen Topf | 12 Jul 2012 09:50

Re: [OSM-dev] API change

On Thu, Jul 12, 2012 at 09:23:59AM +0200, Frederik Ramm wrote:
> >There are a few more programs reading those XML files, you
> >know...
> 
> There haven't been any changes to *file* formats yet, just transfer
> formats; the planet file doesn't have deleted nodes, and the history
> planet export script hasn't been modified yet (but will probably be
> in due course).

There never was a difference between what you call "file formats" and "transfer
formats". Software that could read one could read the other. In all cases it
is just the XML representation of OSM data.

Jochen
--

-- 
Jochen Topf  jochen <at> remote.org  http://www.remote.org/jochen/  +49-721-388298