Sebastien Pouliot | 14 Aug 14:03

Re: [PATCH] System.Security: trivial fixes for XmlDsig transforms

On Thu, 2008-08-14 at 04:52 +0200, Gert Driesen wrote:
> Hey Sebastien,
> 
> I'm remove all unnecessary changes (like the brace position, bad
> habits ...) and resubmit the patch for review.

Thanks!
Sebastien

> Gert
> 
> -----Original Message-----
> From: mono-devel-list-bounces <at> lists.ximian.com
[mailto:mono-devel-list-bounces <at> lists.ximian.com] On Behalf Of Sebastien Pouliot
> Sent: donderdag 14 augustus 2008 2:58
> To: Gert Driesen
> Cc: mono-devel-list <at> ximian.com
> Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
> 
> On Sat, 2008-08-09 at 11:04 +0200, Gert Driesen wrote:
> > Hi,
> > 
> > The attached patch provides some trivial fixes for XmlDsig transforms in
> > System.Security, and adds/improves unit tests.
> > 
> > Let me know if this is ok to commit.
> 
> No. It seems there's good stuff (like updating the old syntax of unit
> tests) but then there's all the other unneeded stuff part of this patch
> (some examples follows).
(Continue reading)

Gert Driesen | 14 Aug 16:47
Favicon
Gravatar

Re: [PATCH] System.Security: trivial fixes for XmlDsig transforms


> -----Original Message-----
> From: mono-devel-list-bounces <at> lists.ximian.com
[mailto:mono-devel-list-bounces <at> lists.ximian.com] On Behalf Of Sebastien Pouliot
> Sent: donderdag 14 augustus 2008 14:03
> To: Gert Driesen
> Cc: mono-devel-list <at> ximian.com
> Subject: Re: [Mono-dev] [PATCH] System.Security: trivial fixes for XmlDsig transforms
>
> On Thu, 2008-08-14 at 04:52 +0200, Gert Driesen wrote:
> > Hey Sebastien,
> > 
> > I'm remove all unnecessary changes (like the brace position, bad
> > habits ...) and resubmit the patch for review.
>
> Thanks!

Np. Can you (ask someone to) allow my updated patch to make it to the devel list (size restriction again,
although I swear the patch is smaller now ;-))?

Gert

Gmane