Re: [PATCH] System.Security: trivial fixes for XmlDsig transforms

On Thu, 2008-08-14 at 06:35 +0200, Gert Driesen wrote:
> > Index: Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs
> > ===================================================================
> > --- Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs   (revision 110022)
> > +++ Test/System.Security.Cryptography.Xml/XmlDsigXsltTransformTest.cs   (working copy)
> > @@ -23,8 +23,17 @@
> >  
> >         // Note: GetInnerXml is protected in XmlDsigXsltTransform making it
> >         // difficult to test properly. This class "open it up" 
> > -       public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform {
> > +       public class UnprotectedXmlDsigXsltTransform : XmlDsigXsltTransform
> > +       {
> 
> Your interpretation was different than mine so you asked (I think I
> suggested it) on mono-dev about this (May 26th) and Miguel's answer (May
> 27th) was clear: 
>         "Same line, there are a couple of samples on that page."
> 
> Anyway please do not introduce unneeded changes into your patches.
> 
> > +               public UnprotectedXmlDsigXsltTransform ()
> > +               {
> > +               }
> >  
> > +               public UnprotectedXmlDsigXsltTransform (bool includeComments)
> > +                       : base (includeComments)
> > +               {
> > +               }
> 
> Did you include this in your remarks to signal that braces should go