headers
Rodrigo Kumpera | 20 Aug 05:09
Gravatar

Custom exception handling code in ppc

Hey guys,

Reading the ppc code for exception handling seens like we could get rid of the
CUSTOM_EXCEPTION_HANDLING define and a big chunk of ppc specific code.

I can't spot any platform specific code in in exceptions-ppc.c::arch_handle_exception
comparing to mini-exceptions.c::mono_handle_exception_internal.

Actually the later one have some userfull additions missing in the ppc code.

Do you mind taking a look if we can remove this big chunk of 90% duplicated code?

Cheers,
Rodrigo

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Permalink | Reply |
headers
Mark Probst | 21 Aug 15:06

Re: Custom exception handling code in ppc

Hey,

> I can't spot any platform specific code in in
> exceptions-ppc.c::arch_handle_exception
> comparing to mini-exceptions.c::mono_handle_exception_internal.
>
> Actually the later one have some userfull additions missing in the ppc code.
>
> Do you mind taking a look if we can remove this big chunk of 90% duplicated
> code?

There seems to be some important difference, because a few runtime
tests fail with the arch-independent code.  I'll investigate.

Mark
Permalink | Reply |
headers
Mark Probst | 24 Aug 19:07

Re: Custom exception handling code in ppc

Hey,

> There seems to be some important difference, because a few runtime
> tests fail with the arch-independent code.  I'll investigate.

The difference is that MONO_CONTEXT_GET_BP for the PPC doesn't
actually get the base pointer, but the stack pointer.  With that
fixed, the arch-independent exception handling works.  Will be
committed soon.

Mark
Permalink | Reply |

Gmane