Cedric Vivier | 15 Oct 08:47

[PATCH] Get back methods in the symbol files generated by SRE-using compilers

Hey all,

I've recently discovered that code generated by booc (or other
compilers using SRE [1]) cannot be conveniently debugged with the mono
debugger anymore because there is no methods information in the
generated symbol file.
It was working pre-kahalo, but when symbol writing code from SRE came
back in r105607 (Jun 11 2008) the necessary
SymbolWriter.SetMethodSourceRange method has not been implemented but
just stubbed with a "#if FIXME" englobing all body.

This patch implements SetMethodSourceRange using the new underlying
MonoSymbolWriter's API so that the symbol files generated by SRE-using
compiler are useful again.

Please review.

Regards,

[1] System.Reflection.Emit
Attachment (SymbolWriterImpl.patch): text/x-diff, 2534 bytes
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Rodrigo Kumpera | 15 Oct 16:13
Gravatar

Re: [PATCH] Get back methods in the symbol files generated by SRE-using compilers

Martin,

Do you think that this fix can be backported to 2.0?

Thanks,
Rodrigo

2008/10/15 Cedric Vivier <cedricv <at> neonux.com>
Hey all,

I've recently discovered that code generated by booc (or other
compilers using SRE [1]) cannot be conveniently debugged with the mono
debugger anymore because there is no methods information in the
generated symbol file.
It was working pre-kahalo, but when symbol writing code from SRE came
back in r105607 (Jun 11 2008) the necessary
SymbolWriter.SetMethodSourceRange method has not been implemented but
just stubbed with a "#if FIXME" englobing all body.

This patch implements SetMethodSourceRange using the new underlying
MonoSymbolWriter's API so that the symbol files generated by SRE-using
compiler are useful again.

Please review.

Regards,

[1] System.Reflection.Emit

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


_______________________________________________
Mono-devel-list mailing list
Mono-devel-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Jb Evain | 15 Oct 16:15
Favicon

Re: [PATCH] Get back methods in the symbol files generated by SRE-using compilers

Hey,

On 10/15/08, Cedric Vivier <cedricv <at> neonux.com> wrote:
>  Please review.

Following up an IRC discussion, this patch has been reviewed and commited.

--

-- 
Jb Evain  <jb <at> nurv.fr>
Jb Evain | 15 Oct 17:43
Favicon

Re: [PATCH] Get back methods in the symbol files generated by SRE-using compilers

On 10/15/08, Jb Evain <jb <at> nurv.fr> wrote:
>  Following up an IRC discussion, this patch has been reviewed and commited.

And has been backported to the 2.0 branch as well.

--

-- 
Jb Evain  <jb <at> nurv.fr>

Gmane