graham | 22 Jun 2012 10:19
Picon
Favicon

Add missing shebang line in MacOSX instructions. (issue 6300118)

I thought that bash doesn't need the shebang in some cases?  at least, I
could have sworn that I never added the shebang in this case?

Anyway, LGTM and you can push it directly to staging if you want.

http://codereview.appspot.com/6300118/
David Kastrup | 22 Jun 2012 10:32
X-Face
Picon
Picon

Re: Add missing shebang line in MacOSX instructions. (issue 6300118)

graham <at> percival-music.ca writes:

> I thought that bash doesn't need the shebang in some cases?  at least, I
> could have sworn that I never added the shebang in this case?
>
> Anyway, LGTM and you can push it directly to staging if you want.
>
> http://codereview.appspot.com/6300118/

For shell scripts, it is usually sufficient to add

:

in the first line.  This is enough to tell other shells (like the C
shell) that it should better not try interpreting this shell script
themselves.

However, without a shebang line, you can only execute such scripts while
being in a shell or shell script.  It won't work when called via the
exec system call.

--

-- 
David Kastrup
julien.rioux | 22 Jun 2012 10:59
Picon

Re: Add missing shebang line in MacOSX instructions. (issue 6300118)

Reviewers: Graham Percival,

Message:
On 2012/06/22 08:19:29, Graham Percival wrote:
> I thought that bash doesn't need the shebang in some cases?  at least,
I could
> have sworn that I never added the shebang in this case?

As I understand it, problems ensue when you try to call that script from
python.

--
Julien

Description:
Add missing shebang line in MacOSX instructions.

Please review this at http://codereview.appspot.com/6300118/

Affected files:
   M Documentation/web/download.itexi

Index: Documentation/web/download.itexi
diff --git a/Documentation/web/download.itexi  
b/Documentation/web/download.itexi
index  
55306b48d89798718b81951c45706e9343885d25..365ecedaa3595aac6da3db6860c35f72d1653778  
100644
--- a/Documentation/web/download.itexi
+++ b/Documentation/web/download.itexi
(Continue reading)


Gmane