Re: Brain surgery on the build system, first stage (issue 6446096)
<john.mandereau <at> gmail.com>
2012-08-09 21:06:44 GMT
File aclocal.m4 (right):
aclocal.m4:1350: + if test "$CYGWIN$MINGW32" = "nono"; then
On 2012/08/09 18:32:28, dak wrote:
> This does not look like aclocal.m4 at all, more like the output of git
> What is up with this?
This looks like a bug in git-cl and/or side-by-side view or Rietveld.
Unified diff view is correct, though.
Brain surgery on the build system, first stage
Sorry to do this just before 2.16 branching out, but if you remember
nightmares about non-distributed files and the like because of the
desire to include last-minute changes to translations and whatnot, IMO
the part of this patch regarding "make dist" is really worth the
trouble. If you like, I can also include a merge of stepmake/stepmake
and make/, but I thought this would really clutter the review of other
changes, and this merge is trivial if you compare with the patch of
this issue, so that merge will be submitted for review after this
review issue settled down.
Commits are viewable separately on dev/jmandereau: