Hi just wanted to check in and see if everyone is ok with releasing 4.5.3 this weekend. This would be from the 4.5.x branch in git. There are a few small things such as updating the icon that is still on my todo list... anything else? cheers ARUN
At 12:59 28-9-2011 -0700, Arun Persaud wrote: >... anything else? Well, I was checking things, and encountered the following problem in XBoard: For board sizes (-size) 29, 33, 37, and 40 the menu bar is now wider than the board, bacause the new menu organization has more items than it used to have. This means the menu bar will determine the width of the window in those sizes, leaving lots of white space to the right of the board, which is truly ugly. At -size 25 the problem disappears, because XBoard switches to so-called tinyLayout, where it only putsthe first letter on the menu names on the menu bar. Should we still do something about this for 4.5.3? And if so, what? The easiest fix would be to let tinyLayout start at -size 40 in stead of 25. This gives many sizes where we only have single-letter menu titles, though. An alternative would be to change the default point size of the -messageFont. (This could be acheived by changing the default fonts table in the code, as well as by configuring defaults in the xboard.config file.) With 11 point in stead of 12, for instance, -sizes 37 and 40 would be OK. The font would also be used in the pull-down menu itself, though, which makes them look a bit sparse to my taste. Finally we could reconsider the new menu organization, e.g. dissolve the Engine menu and move the items to Action and Options, or merge Action and Mode. This would mean a major change to the code, though.
Hi On 09/29/2011 12:11 PM, h.g. muller wrote: > At 12:59 28-9-2011 -0700, Arun Persaud wrote: >> ... anything else? > > Well, I was checking things, and encountered the following problem in > XBoard: > For board sizes (-size) 29, 33, 37, and 40 the menu bar is now wider > than the board, > bacause the new menu organization has more items than it used to have. > This means the menu bar will determine the width of the window in those > sizes, > leaving lots of white space to the right of the board, which is truly ugly. > At -size 25 the problem disappears, because XBoard switches to so-called > tinyLayout, where it only putsthe first letter on the menu names on the > menu bar. > > Should we still do something about this for 4.5.3? And if so, what? > The easiest fix would be to let tinyLayout start at -size 40 in stead > of 25. I would vote for this quick fix or leaving it as it is (doesn't look too bad on my computer)... another fix could be to center the board under the menu in case the menu is longer than the board... might look a better?! > [...] Finally we could reconsider the new menu organization, e.g. dissolve the > Engine > menu and move the items to Action and Options, or merge Action and Mode. > This would mean a major change to the code, though.(Continue reading)
At 19:37 29-9-2011 -0700, Arun Persaud wrote: > > The easiest fix would be to let tinyLayout start at -size 40 in stead > > of 25. > >I would vote for this quick fix or leaving it as it is (doesn't look too >bad on my computer)... another fix could be to center the board under >the menu in case the menu is longer than the board... might look a better?! Well, centering the board is unfortunately difficult in Xt. You would have to calculate the offset from the left edge by hand, and the fix no longer qualifies as easy. An additional complication that I overlooked upto now is that the tinyLayout decision should really be taken based on board width rather than square size. E.g. -size 29 would not be a problem at all in Gothic Chess, where the board is 10x8. But I could do something like tinyLaout = (BOARD_WIDTH * (squareSize+lineGap) < 8*42); This would then work with the default font settings. Come to think of it, there actually might already be code in XBoard to calculate the width of the menu bar, because it must layout things such that the message widget and button bar together have exactly the same length. In that case I could replace the 8*42 by the actual length, which would then take into account the font that is used (and a possible translation!)(Continue reading)
I now committed a compromise patch in the hgm4.5.2 branch, where I don't immediately limit the menu names to just the first letter when the full names do not fit, but where I gradually clip the names to a length where the menu bar fits. It kicks in for square sizes below 45, but accounts for the number of board files. For all supported square sizes and 8x8 boards it now gives palatable results with the standard fonts. As far as I am concerned it is safe to put this in the 4.5.3 release.
On 09/30/2011 10:26 AM, h.g. muller wrote: > I now committed a compromise patch in the hgm4.5.2 branch, > where I don't immediately limit the menu names to just the first > letter when the full names do not fit, but where I gradually clip > the names to a length where the menu bar fits. It kicks in for > square sizes below 45, but accounts for the number of board files. > > For all supported square sizes and 8x8 boards it now gives > palatable results with the standard fonts. > > As far as I am concerned it is safe to put this in the 4.5.3 release. sounds good... I'll pull those today or tomorrow and the prepare a release tomorrow or the day after... Does the improved icon work for everyone? In that case I'll include that one too Arun
>Does the improved icon work for everyone? In that case I'll include that >one too The white border makes the icon stand out better when I view it with an image viewer. I couldn't see a difference in the actual game though when I tried overwriting the icon with the new one. Does it just appear against the app in the gnome menu and in the active apps list at the bottom of the screen? By the way I pushed a change to Savannah for the variant board size issue. HG your change in the nubati repo for the same issue had also gone to Savannah which I'm not sure if you intended (do the changes in nubati repo all go to Savannah even in gtk-xt branch?). This caused a merge conflict which I resolved by using my version of the change, which was based on yours anyway. JC
At 08:48 1-10-2011 +0100, John Cheetham wrote: >HG your change in the nubati repo for the same issue had also gone to >Savannah which I'm not sure if you intended No, this was not intended. Arun handles pushing of the hgm.nubati stuff to savannah, and I thought he was doing this selectively for the hgmaster and hgm4.5.2 branches only. I guess the automatic pushing here happened because in my local branch I used the same branch name formy local branch as is used on savannah. I should have named it hgtk-xt, or something like that. I will do that in the future, sorry about the messup.
Hi On 10/01/2011 01:31 AM, h.g. muller wrote: > At 08:48 1-10-2011 +0100, John Cheetham wrote: >> HG your change in the nubati repo for the same issue had also gone to >> Savannah which I'm not sure if you intended > > No, this was not intended. Arun handles pushing of the hgm.nubati stuff > to savannah, and I thought he was doing this selectively for the > hgmaster and hgm4.5.2 branches only. I guess the automatic pushing here > happened because in my local branch I used the same branch name formy > local branch as is used on savannah. I should have named it hgtk-xt, or > something like that. I will do that in the future, sorry about the messup. sorry, my mistake, I pushed that one over to savannah... should have asked first. No need to rename the branch... Arun
Hi On 10/01/2011 12:48 AM, John Cheetham wrote: >> Does the improved icon work for everyone? In that case I'll include >> that one too > > The white border makes the icon stand out better when I view it with > an image viewer. I couldn't see a difference in the actual game > though when I tried overwriting the icon with the new one. Does it > just appear against the app in the gnome menu and in the active apps > list at the bottom of the screen? yes, it's just the item that is used in by the window manager, nothing within the game. HGM noticed that it doesn't have a good contrast against a dark background, so I modified it a bit. I'll add it to the distro and will work on releasing 4.5.3 today then. Arun
RSS Feed