Bruno Postle | 4 Mar 2009 00:46
X-Face

Re: Patch for autopano-sift-C to do the right thing rather than die

Hi Norman, thanks I applied this to autopano-sift-C SVN.

-- 
Bruno

On Tue 03-Mar-2009 at 22:41 +0000, Norman Yarvin wrote:
>This patch eliminates a couple of rare cases in which autopano-sift-C chooses to
>print an error message and die, rather than doing anything sensible.  These
>cases are numerically rather rare (some number has to be exactly zero).  I
>haven't thought this patch out to all its consequences, but (a) erroring out
>when some floating-point number is exactly zero, but not when it is almost zero,
>is hardly ever the right thing to do; and (b) whatever the consequences to end
>users, they can hardly be worse than dying with an error.  In any case, the
>following patch seemed to fix things for the test case I tried: instead of an
>error message, I got normal, usable output.

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
Kornel Benko | 4 Mar 2009 07:46
Picon
Favicon

Re: Patch for autopano-sift-C to do the right thing rather than die

Am 2009-03-04 schrieb Bruno Postle:
> Hi Norman, thanks I applied this to autopano-sift-C SVN.
> 

May I supply a patch for creating rpm?

It sets the correct installation directory and different release number.

	Kornel
--

-- 
Kornel Benko
Kornel.Benko@...
Attachment (CMakeLists.diff): text/x-diff, 848 bytes
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
PanoTools-devel mailing list
PanoTools-devel@...
https://lists.sourceforge.net/lists/listinfo/panotools-devel
Bruno Postle | 4 Mar 2009 20:06
X-Face

Re: Patch for autopano-sift-C to do the right?thing rather than die

On Wed 04-Mar-2009 at 07:46 +0100, Kornel Benko wrote:
>
>May I supply a patch for creating rpm?
>
>It sets the correct installation directory and different release number.

Thanks, applied.

--

-- 
Bruno

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
Kornel Benko | 5 Mar 2009 09:45
Picon
Favicon

Re: Patch for autopano-sift-C to do the right?thing rather than die

Am 2009-03-04 schrieb Bruno Postle:
> On Wed 04-Mar-2009 at 07:46 +0100, Kornel Benko wrote:
> >
> >May I supply a patch for creating rpm?
> >
> >It sets the correct installation directory and different release number.
> 
> Thanks, applied.
> 

Ok, but why did you set the generator be TGZ and TBZ2 only?

(About line 224 in CMakeLists.txt: "SET(CPACK_GENERATOR "TGZ;TBZ2")" )

I had to comment it out

	Kornel
--

-- 
Kornel Benko
Kornel.Benko@...
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
(Continue reading)


Gmane