headers
Kornel Benko | 3 Mar 2011 09:29
Picon
Favicon

Re: [panotools-cvs] /hgrepo/p/pa/panotools/libpano: Fixed compiler warnings and clea...

Am Donnerstag, 3. März 2011 schrieb dmg-a84/LA3/q2c@public.gmane.org

> -## Locate the hugin source root and its parent directory

> -IF(HUGIN_BASE_DIR)

> -  GET_FILENAME_COMPONENT(SOURCE_BASE_DIR ${HUGIN_BASE_DIR} PATH CACHE)

> -  set(CMAKE_MODULE_PATH ${HUGIN_BASE_DIR}/CMakeModules)

> -ELSE(HUGIN_BASE_DIR)

> -  GET_FILENAME_COMPONENT(SOURCE_BASE_DIR ${CMAKE_SOURCE_DIR} PATH CACHE)

> -  set(CMAKE_MODULE_PATH ${SOURCE_BASE_DIR}/hugin/CMakeModules)

> -ENDIF(HUGIN_BASE_DIR)

We had some fights in the past, as how to reuse modules between our projects (enblend hugin, libpano).

So removing this makes me uneasy.

Kornel

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
PanoTools-devel mailing list
PanoTools-devel@...
https://lists.sourceforge.net/lists/listinfo/panotools-devel
Permalink | Reply |
headers
dmg | 3 Mar 2011 09:48
Picon
Picon
Favicon

Re: [panotools-cvs] /hgrepo/p/pa/panotools/libpano: Fixed compiler warnings and clea...

Hi Kornel,

can you be more explicit on what it does and why it needs to be in
libpano rather than hugin?

-dmg

2011/3/3 Kornel Benko <Kornel.Benko@...>:
> Am Donnerstag, 3. März 2011 schrieb dmg@...
>
>> -## Locate the hugin source root and its parent directory
>
>> -IF(HUGIN_BASE_DIR)
>
>> -  GET_FILENAME_COMPONENT(SOURCE_BASE_DIR ${HUGIN_BASE_DIR} PATH CACHE)
>
>> -  set(CMAKE_MODULE_PATH ${HUGIN_BASE_DIR}/CMakeModules)
>
>> -ELSE(HUGIN_BASE_DIR)
>
>> -  GET_FILENAME_COMPONENT(SOURCE_BASE_DIR ${CMAKE_SOURCE_DIR} PATH CACHE)
>
>> -  set(CMAKE_MODULE_PATH ${SOURCE_BASE_DIR}/hugin/CMakeModules)
>
>> -ENDIF(HUGIN_BASE_DIR)
>
> We had some fights in the past, as how to reuse modules between our projects
> (enblend hugin, libpano).
>
> So removing this makes me uneasy.
>
> Kornel
>
> ------------------------------------------------------------------------------
> Free Software Download: Index, Search & Analyze Logs and other IT data in
> Real-Time with Splunk. Collect, index and harness all the fast moving IT
> data
> generated by your applications, servers and devices whether physical,
> virtual
> or in the cloud. Deliver compliance at lower cost and gain new business
> insights. http://p.sf.net/sfu/splunk-dev2dev
> _______________________________________________
> PanoTools-devel mailing list
> PanoTools-devel@...
> https://lists.sourceforge.net/lists/listinfo/panotools-devel
>
>

--

-- 
--dmg

---
Daniel M. German
http://turingmachine.org

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev
Permalink | Reply |
headers
Kornel Benko | 3 Mar 2011 10:08
Picon
Favicon

Re: [panotools-cvs] /hgrepo/p/pa/panotools/libpano: Fixed compiler warnings and clea...

Am Donnerstag, 3. März 2011 schrieb dmg:

> Hi Kornel,

>

> can you be more explicit on what it does

For the calls like

FIND_PACKAGE(TIFF REQUIRED)

it provides an extra search path to find the appropriate "FindTIFF.cmake". It has no effect, if no such path exists.

Sometimes one has to provide a module which is missing on some platforms, or has to be changed to

better suit one's needs.

> and why it needs to be in

> libpano rather than hugin?

There is no preference in this direction from my side. I even would accept a completelly new project for this.

Hugin was the first one using own modules, that was the only reason.

> -dmg

>

Kornel

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
PanoTools-devel mailing list
PanoTools-devel@...
https://lists.sourceforge.net/lists/listinfo/panotools-devel
Permalink | Reply |
headers
dmg | 3 Mar 2011 10:21
Picon
Picon
Favicon

Re: [panotools-cvs] /hgrepo/p/pa/panotools/libpano: Fixed compiler warnings and clea...

Ok, I see what you mean (I am no expert in cmake). I'll put it back.

--dmg

2011/3/3 Kornel Benko <Kornel.Benko@...>:
> Am Donnerstag, 3. März 2011 schrieb dmg:
>
>> Hi Kornel,
>
>>
>
>> can you be more explicit on what it does
>
> For the calls like
>
> FIND_PACKAGE(TIFF REQUIRED)
>
> it provides an extra search path to find the appropriate "FindTIFF.cmake".
> It has no effect, if no such path exists.
>
> Sometimes one has to provide a module which is missing on some platforms, or
> has to be changed to
>
> better suit one's needs.
>
>> and why it needs to be in
>
>> libpano rather than hugin?
>
> There is no preference in this direction from my side. I even would accept a
> completelly new project for this.
>
> Hugin was the first one using own modules, that was the only reason.
>
>> -dmg
>
>>
>
> Kornel
>
> ------------------------------------------------------------------------------
> Free Software Download: Index, Search & Analyze Logs and other IT data in
> Real-Time with Splunk. Collect, index and harness all the fast moving IT
> data
> generated by your applications, servers and devices whether physical,
> virtual
> or in the cloud. Deliver compliance at lower cost and gain new business
> insights. http://p.sf.net/sfu/splunk-dev2dev
> _______________________________________________
> PanoTools-devel mailing list
> PanoTools-devel@...
> https://lists.sourceforge.net/lists/listinfo/panotools-devel
>
>

--

-- 
--dmg

---
Daniel M. German
http://turingmachine.org

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev
Permalink | Reply |

Gmane