Graham Cobb | 7 Apr 01:55

libmimedir broken in revision 9093

I have been travelling this week and have just noticed that revision 9093 has 
broken my automatic daily builds:  libmimedir does not build.  The actual 
problem is that the modified Makefile references mimedir-recurrence-rule.c 
(and .h) but those files have not been added to the SVN.  I have removed the 
references from the Makefile again so that libmimedir can now build again.

Before anyone re-does the patch (providing the missing files this time), 
please be aware that I deliberately did not include the 
mimedir-recurrence-rule.c patch when I created libmimedir because it does not 
seem to do anything.  Although the OE patch creates mimedir-recurrence-rule.c 
it does not seem to ever cause it to be referenced by any other code, unless 
I am missing something.  Recurrences are definitely broken anyway (for 
example multiple BY clauses don't work) but this patch does not seem to 
change anything!

If this patch actually fixes something feel free to re-apply it, remembering 
to SVN ADD the new files.  But please check that the component builds again 
afterwards.  I would be very interested to see a test case which does not 
work without the patch and which does work with the patch.

Graham
Philippe De Swert | 7 Apr 11:48
Favicon

Re: libmimedir broken in revision 9093

Hi all,

On Sat, 2007-04-07 at 00:56 +0100, Graham Cobb wrote:
> I have been travelling this week and have just noticed that revision 9093 has 
> broken my automatic daily builds:  libmimedir does not build.  The actual 
> problem is that the modified Makefile references mimedir-recurrence-rule.c 
> (and .h) but those files have not been added to the SVN.  I have removed the 
> references from the Makefile again so that libmimedir can now build again.

That would be my fault, please accept my apologies. I had been checking
the libmimedir patches from OE as I added a libmimedir_svn.bb file. I
indeed seem to have forgotten the mimedir-recurrence-rule.c (and .h)
file. Weirdly enough it still built for me, however now the build fails.
Given what you specify now I will not re-apply the patch. I will fix it
differently in OE.

Cheers,

Philippe

Gmane