This is the official homepage of the first free open source JavaServer(tm) Faces implementation called "MyFaces"

dennis hoersch (JIRA | 29 Jun 2012 12:07

[jira] [Created] (TOMAHAWK-1630) Render conditional comments for IE at the html tag

dennis hoersch created TOMAHAWK-1630:
----------------------------------------

             Summary: Render conditional comments for IE at the html tag
                 Key: TOMAHAWK-1630
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1630
             Project: MyFaces Tomahawk
          Issue Type: Improvement
    Affects Versions: 1.1.11
         Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
            Reporter: dennis hoersch
         Attachments: Document.java, DocumentRenderer.java, patch_Document.txt, patch_DocumentRenderer.txt

Hi,

in our old (pre-JSF2) product version we use some IE conditional comments to insert IE specific stylesheets:

<h:outputText
  value="&lt;!--[if IE 9]&gt;&lt;link rel=&quot;stylesheet&quot; type=&quot;text/css&quot; href=&quot;/path/to/someIE9.css&quot;/&gt;&lt;![endif]--&gt;"
  escape="false" />

But now I want to use <h:outputStylesheet />. (So that the stylesheets are registered at the view root.)

My researches in the Internet gave me a solution used by other frameworks: surround the HTML root tag with
conditional comments an give them IE version specific classes:

<!--[if lt IE 7 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie6"><![endif]-->
<!--[if IE 7 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie7"><![endif]-->
<!--[if IE 8 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie8"><![endif]-->
<!--[if IE 9 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie9"><![endif]-->

(Continue reading)

headers

Leonardo Uribe (JIRA | 29 Jun 2012 15:21

[jira] [Commented] (TOMAHAWK-1630) Render conditional comments for IE at the html tag


    [
https://issues.apache.org/jira/browse/TOMAHAWK-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403888#comment-13403888
] 

Leonardo Uribe commented on TOMAHAWK-1630:
------------------------------------------

I think it is a very useful feature. I would like to find a better name for
renderConditionalCommentsAndStyleClasses . Maybe includeBrowserSelectors ? It could be more meaningful.

> Render conditional comments for IE at the html tag
> --------------------------------------------------
>
>                 Key: TOMAHAWK-1630
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1630
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>    Affects Versions: 1.1.11
>         Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
>            Reporter: dennis hoersch
>         Attachments: Document.java, DocumentRenderer.java, patch_Document.txt, patch_DocumentRenderer.txt
>
>
> Hi,
> in our old (pre-JSF2) product version we use some IE conditional comments to insert IE specific stylesheets:
> <h:outputText
>   value="&lt;!--[if IE 9]&gt;&lt;link rel=&quot;stylesheet&quot; type=&quot;text/css&quot; href=&quot;/path/to/someIE9.css&quot;/&gt;&lt;![endif]--&gt;"
>   escape="false" />
> But now I want to use <h:outputStylesheet />. (So that the stylesheets are registered at the view root.)

(Continue reading)

headers

dennis hoersch (JIRA | 29 Jun 2012 15:35

[jira] [Commented] (TOMAHAWK-1630) Render conditional comments for IE at the html tag


    [
https://issues.apache.org/jira/browse/TOMAHAWK-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403898#comment-13403898
] 

dennis hoersch commented on TOMAHAWK-1630:
------------------------------------------

Yes, I hoped that someone would find a better name :)

> Render conditional comments for IE at the html tag
> --------------------------------------------------
>
>                 Key: TOMAHAWK-1630
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1630
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>    Affects Versions: 1.1.11
>         Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
>            Reporter: dennis hoersch
>         Attachments: Document.java, DocumentRenderer.java, patch_Document.txt, patch_DocumentRenderer.txt
>
>
> Hi,
> in our old (pre-JSF2) product version we use some IE conditional comments to insert IE specific stylesheets:
> <h:outputText
>   value="&lt;!--[if IE 9]&gt;&lt;link rel=&quot;stylesheet&quot; type=&quot;text/css&quot; href=&quot;/path/to/someIE9.css&quot;/&gt;&lt;![endif]--&gt;"
>   escape="false" />
> But now I want to use <h:outputStylesheet />. (So that the stylesheets are registered at the view root.)
> My researches in the Internet gave me a solution used by other frameworks: surround the HTML root tag with

(Continue reading)

headers

Leonardo Uribe (JIRA | 7 Oct 2012 07:21

[jira] [Resolved] (TOMAHAWK-1630) Render conditional comments for IE at the html tag


     [
https://issues.apache.org/jira/browse/TOMAHAWK-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-1630.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.14-SNAPSHOT
         Assignee: Leonardo Uribe

Committed patch, with the new property name changed to includeBrowserSelectors. Thanks to dennis
hoersch for provide this patch.

> Render conditional comments for IE at the html tag
> --------------------------------------------------
>
>                 Key: TOMAHAWK-1630
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1630
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>    Affects Versions: 1.1.11
>         Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
>            Reporter: dennis hoersch
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.14-SNAPSHOT
>
>         Attachments: Document.java, DocumentRenderer.java, patch_DocumentRenderer.txt, patch_Document.txt
>
>

(Continue reading)