headers
Alexander Lehmann (JIRA | 28 Jul 2012 11:10

[jira] (JBEHAVE-804) Improved test in PrintStreamOutputBehaviour
Issue Type: Improvement
Affects Versions: 3.6.8
Assignee: Unassigned
Components: Core
Created: 28/Jul/12 4:08 AM
Description:

I tried to improve the tests in PrintStreamOutputBehaviour similar to the changes I did in the Template output to check if xml encoding is done correctly in all cases (it does) and if the file is actually valid xml (it wasn't, not even the expected string was).
To make this work I added an xmlunit check and changed the order of the created story to match the way a real story is created, in this case the xml is valid.
This didn't require any change to actual code, only the test code was wrong, so this is a minor issue.
Project: JBehave
Priority: Minor
Reporter: Alexander Lehmann
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Alexander Lehmann (JIRA | 28 Jul 2012 11:10

[jira] (JBEHAVE-804) Improved test in PrintStreamOutputBehaviour

I'm not 100% sure how to commit this to be independent of the previous patch I submitted for the Templatable issue, I will wait until the other patch is merged.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Mauro Talevi (JIRA | 28 Jul 2012 12:11

[jira] (JBEHAVE-804) Improved test in PrintStreamOutputBehaviour
Change By: Mauro Talevi (28/Jul/12 5:10 AM)
Fix Version/s: 3.6.9
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Mauro Talevi (JIRA | 28 Jul 2012 12:11

[jira] (JBEHAVE-804) Improved test in PrintStreamOutputBehaviour

Mauro Talevi commented on JBEHAVE-804

Please pull latest with renamed class.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Alexander Lehmann (JIRA | 30 Jul 2012 21:41

[jira] (JBEHAVE-804) Improved test in PrintStreamOutputBehaviour

https://github.com/alexlehm/jbehave-core/commit/7b72bfaaaa33d22abf14fb4bdfced11bfade7410

JBEHAVE-804: Improved test in PrintStreamOutputBehaviour

Added a check for valid xml to the xml test method, more elaborate pending methods, changed the sequence of the test story to be more like actual stories (dry run moved below beforeStory and pending methods before afterStory).
this way the story xml is proper xml.

This doesn't change any main code, only the test was wrong.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Mauro Talevi (JIRA | 31 Jul 2012 01:35

[jira] (JBEHAVE-804) Improved test in PrintStreamOutputBehaviour

Mauro Talevi resolved JBEHAVE-804 as Fixed
Change By: Mauro Talevi (30/Jul/12 6:33 PM)
Resolution: Fixed
Status: Open Resolved
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |

Gmane