headers
Tony Chemit (JIRA | 21 Jun 2012 13:10

[jira] (MOJO-1851) Use version property for plugins acting also as report
Issue Type: Improvement
Assignee: Unassigned
Components: _Mojo Parent
Created: 21/Jun/12 6:10 AM
Description:

It is a shame to need to change twice a version in the pom when plugin acts also as a report, says:

  • checkstyle-p
  • invoker-p
  • javadoc-p
  • plugin-p
    ...

More over, if a child project wants to override it, it should only change the version property instead of redeclare the plugin in both section...
Project: Mojo
Priority: Major
Reporter: Tony Chemit
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 21 Jun 2012 13:28

[jira] (MOJO-1851) Use version property for plugins acting also as report
Change By: Tony Chemit (21/Jun/12 6:26 AM)
Assignee: Tony Chemit
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 21 Jun 2012 13:48

[jira] (MOJO-1851) Use version property for plugins acting also as report

Tony Chemit closed MOJO-1851 as Fixed

see rev 16943
Change By: Tony Chemit (21/Jun/12 6:46 AM)
Resolution: Fixed
Status: Open Closed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Anders Hammar (JIRA | 21 Jun 2012 13:48

[jira] (MOJO-1851) Use version property for plugins acting also as report

Anders Hammar commented on MOJO-1851

I believe it is possible to declare the version only once when using Maven 3 and v3.x of m-site-p:
http://maven.apache.org/plugins/maven-site-plugin/maven-3.html#Version_Resolution

If a child project then wants to override the version and the report plugin version is resolved from the build plugin, you just configure the version in pluginManagement in the standard Maven way for changing a version. (Haven't tried this though, but it should work in theory.)
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 21 Jun 2012 13:51

[jira] (MOJO-1851) Use version property for plugins acting also as report

 
Tony Chemit edited a comment on MOJO-1851

see rev 16942
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 21 Jun 2012 14:00

[jira] (MOJO-1851) Use version property for plugins acting also as report

Tony Chemit commented on MOJO-1851

Arch, damned! I just commit it.

The main problem is that we do not use the m-site-p 3.x (the version 3.0 has still some problem)., but perharps version 3.1 will works fine now ?

About using the new way of configuring the report (inside the configuration of the m-site-p) I read that it does not work fine with inheritance, so we can not use it in the mojo-parent ? And in documentation the old reporting was still the official way to configure report... and moreover not everybody use maven 3 (lame argument I know...)

So I don't know if it is good moment to change this.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Anders Hammar (JIRA | 21 Jun 2012 14:05

[jira] (MOJO-1851) Use version property for plugins acting also as report

Anders Hammar commented on MOJO-1851

Regarding r16942, I very much dislike this type of property usage. It's so not Maven-ish.

Not sure about m-site-p v3.1. What were the exact problems we had with v3.0? Also, I don't think we need to use the new configuration style, but the requirement for the report plugin version resolution is to use v3.x of the m-site-p. So it should work with Maven 2.x as well. (But I really think we should bump the requirement to release to Maven 3.0.x.)
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Anders Hammar (JIRA | 21 Jun 2012 14:05

[jira] (MOJO-1851) Use version property for plugins acting also as report

Re-opening as I'm not satisfied with the implemented solution.
Change By: Anders Hammar (21/Jun/12 7:05 AM)
Status: Closed Reopened
Resolution: Fixed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 21 Jun 2012 14:25

[jira] (MOJO-1851) Use version property for plugins acting also as report

Tony Chemit commented on MOJO-1851

I can remember about this one https://jira.codehaus.org/browse/MLICENSE-26 ,
but there were some others, I can't remeber.

About fixing my previous commit, what can I do ?
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Anders Hammar (JIRA | 21 Jun 2012 14:34

[jira] (MOJO-1851) Use version property for plugins acting also as report

Anders Hammar commented on MOJO-1851

I think we should focus on switching to m-site-p 3.x instead. If we implement these new properties, we can never remove them without break backwards compatibility of mojo-parent. I'd rather not introduce such a thing because of the (minor) issue of this ticket. Especially when there is (should be) a better solution.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 21 Jun 2012 16:42

[jira] (MOJO-1851) Use version property for plugins acting also as report

Tony Chemit commented on MOJO-1851

Ok, fair enough.

I revert previous commit, remove also version in the reporting section and pass to m-site-p 3.1 and obtain a not very nice message

[WARNING] [WARNING] Some problems were encountered while building the effective model for org.codehaus.mojo:mojo-parent:pom:31-SNAPSHOT [WARNING] 'reporting.plugins.plugin.version' for org.apache.maven.plugins:maven-plugin-plugin is missing. <at> line 389, column 15 [WARNING] 'reporting.plugins.plugin.version' for org.apache.maven.plugins:maven-project-info-reports-plugin is missing. <at> line 402, column 15 [WARNING] 'reporting.plugins.plugin.version' for org.apache.maven.plugins:maven-checkstyle-plugin is missing. <at> line 518, column 19 [WARNING] 'reporting.plugins.plugin.version' for org.apache.maven.plugins:maven-jxr-plugin is missing. <at> line 580, column 19 [WARNING] 'reporting.plugins.plugin.version' for org.apache.maven.plugins:maven-pmd-plugin is missing. <at> line 584, column 19 [WARNING] 'reporting.plugins.plugin.version' for org.apache.maven.plugins:maven-surefire-report-plugin is missing. <at> line 622, column 19 [WARNING] 'reporting.plugins.plugin.version' for org.codehaus.mojo:cobertura-maven-plugin is missing. <at> line 634, column 19 [WARNING] 'reporting.plugins.plugin.version' for org.codehaus.mojo:taglist-maven-plugin is missing. <at> line 645, column 19 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING]

The same in a child project.

But as far as I can see, the site is still perfect. Should I commit my change ?
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Robert Scholte (JIRA | 21 Jun 2012 19:02

[jira] (MOJO-1851) Use version property for plugins acting also as report

Robert Scholte commented on MOJO-1851

Looks like there's a need for an enforcer-rule which verifies that the versions of build plugins and report plugins are in sync.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Anders Hammar (JIRA | 22 Jun 2012 10:01

[jira] (MOJO-1851) Use version property for plugins acting also as report

Anders Hammar commented on MOJO-1851

<at> Tony: These warnings come from Maven core. Maven core can't know how the m-site-p do version resolution. But these warnings will confuse devs so we can't have them I think.
What I think we should do is revert the old configuration with version number declared twice. IMHO it's not the end of the world.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 24 Jun 2012 16:48

[jira] (MOJO-1851) Use version property for plugins acting also as report

Tony Chemit commented on MOJO-1851

<at> Anders: Ok I just revert to old configuration, and reject this issue. I will try to switch to m-site-p 3.1 later.
<at> Robert: good idea for an extra enforcer-rule
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |
headers
Tony Chemit (JIRA | 24 Jun 2012 16:55

[jira] (MOJO-1851) Use version property for plugins acting also as report

Tony Chemit closed MOJO-1851 as Won't Fix
Change By: Tony Chemit (24/Jun/12 9:54 AM)
Resolution: Won't Fix
Status: Reopened Closed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Permalink | Reply |

Gmane