Technical discussion about the development of the networking part of the the core libraries ()

chris hegarty | 12 Mar 2012 21:55

RFR 7152796: TEST_BUG: java/net/Socks/SocksV4Test.java does not terminate

This is a follow up to some tests Alan found that are not being run 
because of a missing  <at> run tag [1].

When run this test didn't exit. I simply fixed the terminate method to 
close the server socket and allow the thread executing the server 
complete. And some minor cleanup.

http://cr.openjdk.java.net/~chegar/7152796/webrev.00/webrev/

-Chris.

[1] 
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-March/009530.html

headers

Alan Bateman | 13 Mar 2012 09:48

Re: RFR 7152796: TEST_BUG: java/net/Socks/SocksV4Test.java does not terminate

On 12/03/2012 20:55, chris hegarty wrote:
> This is a follow up to some tests Alan found that are not being run 
> because of a missing  <at> run tag [1].
>
> When run this test didn't exit. I simply fixed the terminate method to 
> close the server socket and allow the thread executing the server 
> complete. And some minor cleanup.
>
> http://cr.openjdk.java.net/~chegar/7152796/webrev.00/webrev/
Thanks for the sorting this one out, the changes look good to me.

-Alan.