Gravatar

[PATCH] Toolbar borkage fix

Hi all,

Toolbars are broken on KDE. The patch:
http://media.ereslibre.es/2008/08/kdelibs-toolbars.diff

fixes them. In Kontact I also have another patch to complement it:
http://media.ereslibre.es/2008/08/kdepim-toolbars.diff

In theory what was happening (from my understanding) is that it depends on the 
active component (or the current component) how the toolbars should be saved.

As we have usually more than one mainToolbar (depending on the component that 
is active), at the moment of saving (and switching toolbars) Qt was going 
crazy with the saveState() and restoreState() mechanism.

Now, depending on the component that is active, the toolbar state of each 
component is retrieved and loaded/saved.

Are this patches OK to be committed ?

Regards,
Rafael Fernández López.

Allen Winter | 18 Aug 19:29

Re: [PATCH] Toolbar borkage fix

On Sunday 17 August 2008 15:57:38 Rafael Fernández López wrote:
> Hi all,
> 
> Toolbars are broken on KDE. The patch:
> http://media.ereslibre.es/2008/08/kdelibs-toolbars.diff
> 
I applied both patches locally and konqueror and kontact
now seem to have working toolbar positioning.

So a big +1 from me.

-Allen


Gmane