This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105288/

Ship it!

Thanks, looks fine! (btw: from my point of view no review-request would have been necessary for this fix, but of course it is exemplary doing it this way )

- Peter

On June 18th, 2012, 1:47 a.m., Jekyll Wu wrote:

Review request for KDE Base Apps and Peter Penz. By Jekyll Wu. Updated June 18, 2012, 1:47 a.m. Description "desktop-file-validate dolphin.dekstop" generates this: dolphin.desktop: error: (will be fatal in the future): value "FileManager" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: System;FileTools FDO menu specification[1] suggests "System;FileTools" should be used together with the "FileManager" category. The patch simply adds the missing "FileTools" [1] http://standards.freedesktop.org/menu-spec/latest/apa.html Diffs dolphin/src/dolphin.desktop (cd9da17) View Diff

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105288/

This review has been submitted with commit a7d999b7ba3e35069649eb434e9c4e88052a25d0 by Jekyll Wu to branch master.

- Commit

On June 18th, 2012, 1:47 a.m., Jekyll Wu wrote:

Review request for KDE Base Apps and Peter Penz. By Jekyll Wu. Updated June 18, 2012, 1:47 a.m. Description "desktop-file-validate dolphin.dekstop" generates this: dolphin.desktop: error: (will be fatal in the future): value "FileManager" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: System;FileTools FDO menu specification[1] suggests "System;FileTools" should be used together with the "FileManager" category. The patch simply adds the missing "FileTools" [1] http://standards.freedesktop.org/menu-spec/latest/apa.html Diffs dolphin/src/dolphin.desktop (cd9da17) View Diff