This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/

On July 12th, 2012, 4:17 p.m., David Faure wrote:

Looks good. For master only, though, given feature+message freeze in 4.9.

Totally forgot to commit this :( Will do for master (4.10) once my ssh key for my new notebook got imported.

- Kai Uwe

On June 20th, 2012, 12:06 a.m., Kai Uwe Broulik wrote:

Review request for KDE Base Apps. By Kai Uwe Broulik. Updated June 20, 2012, 12:06 a.m. Description As somebody who loves bash scripting but also wants to have a nice userfriendly graphical "interface" for those scripts, I excessively use kdialog. In a new project I am working on, I need the detailedsorry thing in KMessageBox, so I can provide a simple error message "could not launch xyz" while allowing detailed error information such as "directory xyz does not exist" in an expandable Details box. This patch adds this functionality to kdialog. Usage: kdialog --detailedsorry "error message" "what should be in the details section" also works with detailederror [I am volunteering for an update of the respective Wiki page on techbase http://techbase.kde.org/index.php?title=Development/Tutorials/Shell_Scripting_with_KDE_Dialogs_%28de%29 as well. Those screenshots date back to KDE 3 and early KDE 4 times ;) ] Testing Tested and works. Works with linebreaks and other parameters as well. Diffs kdialog/kdialog.cpp (ca2df2f) View Diff Screenshots

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/

On July 12th, 2012, 4:17 p.m. UTC, David Faure wrote:

Looks good. For master only, though, given feature+message freeze in 4.9.

On October 10th, 2012, 4:53 p.m. UTC, Kai Uwe Broulik wrote:

Totally forgot to commit this :( Will do for master (4.10) once my ssh key for my new notebook got imported.

I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?

- Albert

On June 20th, 2012, 12:06 a.m. UTC, Kai Uwe Broulik wrote:

Review request for KDE Base Apps. By Kai Uwe Broulik. Updated June 20, 2012, 12:06 a.m. Description As somebody who loves bash scripting but also wants to have a nice userfriendly graphical "interface" for those scripts, I excessively use kdialog. In a new project I am working on, I need the detailedsorry thing in KMessageBox, so I can provide a simple error message "could not launch xyz" while allowing detailed error information such as "directory xyz does not exist" in an expandable Details box. This patch adds this functionality to kdialog. Usage: kdialog --detailedsorry "error message" "what should be in the details section" also works with detailederror [I am volunteering for an update of the respective Wiki page on techbase http://techbase.kde.org/index.php?title=Development/Tutorials/Shell_Scripting_with_KDE_Dialogs_%28de%29 as well. Those screenshots date back to KDE 3 and early KDE 4 times ;) ] Testing Tested and works. Works with linebreaks and other parameters as well. Diffs kdialog/kdialog.cpp (ca2df2f) View Diff Screenshots

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/

On July 12th, 2012, 4:17 p.m. UTC, David Faure wrote:

Looks good. For master only, though, given feature+message freeze in 4.9.

On October 10th, 2012, 4:53 p.m. UTC, Kai Uwe Broulik wrote:

Totally forgot to commit this :( Will do for master (4.10) once my ssh key for my new notebook got imported.

On February 7th, 2013, 9:09 p.m. UTC, Albert Astals Cid wrote:

I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?

Haven't come around to rebase the patch. Will do a new one next week, no time before Monday.

- Kai Uwe

On June 20th, 2012, 12:06 a.m. UTC, Kai Uwe Broulik wrote:

Review request for KDE Base Apps. By Kai Uwe Broulik. Updated June 20, 2012, 12:06 a.m. Description As somebody who loves bash scripting but also wants to have a nice userfriendly graphical "interface" for those scripts, I excessively use kdialog. In a new project I am working on, I need the detailedsorry thing in KMessageBox, so I can provide a simple error message "could not launch xyz" while allowing detailed error information such as "directory xyz does not exist" in an expandable Details box. This patch adds this functionality to kdialog. Usage: kdialog --detailedsorry "error message" "what should be in the details section" also works with detailederror [I am volunteering for an update of the respective Wiki page on techbase http://techbase.kde.org/index.php?title=Development/Tutorials/Shell_Scripting_with_KDE_Dialogs_%28de%29 as well. Those screenshots date back to KDE 3 and early KDE 4 times ;) ] Testing Tested and works. Works with linebreaks and other parameters as well. Diffs kdialog/kdialog.cpp (ca2df2f) View Diff Screenshots