Bernd Buschinski | 29 Jun 2012 20:06

Review Request: kjs: Range needs a prototype

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105388/

Review request for kdelibs.
By Bernd Buschinski.

Description

kjs: Range needs a prototype some websites do stuff like if (Range.prototype.someFunction !== undefined) { Range.prototype.someFunction = ourOwnFunction; } the problem is we report no prototype, and thus we have Range -> undefined.someFunction which will always fail and throw an exception. But Range should have a prototype, so this patch adds its valid prototype and makes some websites happy.

Diffs

  • khtml/ecma/kjs_range.cpp (500ebbd)

View Diff

Maks Orlovich | 6 Jul 2012 15:39
Picon
Favicon

Re: Review Request: kjs: Range needs a prototype

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105388/

Ship it!

Ship It!

- Maks


On June 29th, 2012, 6:06 p.m., Bernd Buschinski wrote:

Review request for kdelibs.
By Bernd Buschinski.

Updated June 29, 2012, 6:06 p.m.

Description

kjs: Range needs a prototype some websites do stuff like if (Range.prototype.someFunction !== undefined) { Range.prototype.someFunction = ourOwnFunction; } the problem is we report no prototype, and thus we have Range -> undefined.someFunction which will always fail and throw an exception. But Range should have a prototype, so this patch adds its valid prototype and makes some websites happy.

Diffs

  • khtml/ecma/kjs_range.cpp (500ebbd)

View Diff

Commit Hook | 5 Sep 2012 20:37
Picon
Favicon

Re: Review Request: kjs: Range needs a prototype

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105388/

This review has been submitted with commit 47b4a9c8732b654c86540e18a35ca6da3d4840a5 by Bernd Buschinski to branch KDE/4.9.

- Commit


On June 29th, 2012, 6:06 p.m., Bernd Buschinski wrote:

Review request for kdelibs.
By Bernd Buschinski.

Updated June 29, 2012, 6:06 p.m.

Description

kjs: Range needs a prototype some websites do stuff like if (Range.prototype.someFunction !== undefined) { Range.prototype.someFunction = ourOwnFunction; } the problem is we report no prototype, and thus we have Range -> undefined.someFunction which will always fail and throw an exception. But Range should have a prototype, so this patch adds its valid prototype and makes some websites happy.

Diffs

  • khtml/ecma/kjs_range.cpp (500ebbd)

View Diff


Gmane