headers
Martin Koller | 30 Jun 2012 15:21
Picon

Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105395/

Review request for kdelibs.
By Martin Koller.

Description

When a non-local webpage contains a mailto: link and you click on it, konqueror shows a confirmation dialog: This untrusted page links to mailto: some.name <at> some.domain. Do you want to follow the link? (using the page with opera or firefox does not give any such warning and opens kmail) The check is done by KAuthorized:authorizeUrlAction("redirect", pageURL, linkURL); This patch fixes this by always allowing a redirection to a mailto link.

Testing

The following simple html page when the page is served from a local running HTTP Server ( http://localhost:8080/data/test.html ) <html> <body> <a href="mailto:test.test <at> test.at">test.test <at> test.at</a> </body> </html>

Diffs

  • kdecore/kernel/kauthorized.cpp (f7d795a)

View Diff
Permalink | Reply |
headers
David Faure | 12 Jul 2012 18:15
Picon
Favicon
Gravatar

Re: Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105395/

Ship it!

Looks good. I'm curious as to why this wasn't necessary before, but anyway: please commit this for 4.9, obviously.

- David


On June 30th, 2012, 1:21 p.m., Martin Koller wrote:

Review request for kdelibs.
By Martin Koller.

Updated June 30, 2012, 1:21 p.m.

Description

When a non-local webpage contains a mailto: link and you click on it, konqueror shows a confirmation dialog: This untrusted page links to mailto: some.name <at> some.domain. Do you want to follow the link? (using the page with opera or firefox does not give any such warning and opens kmail) The check is done by KAuthorized:authorizeUrlAction("redirect", pageURL, linkURL); This patch fixes this by always allowing a redirection to a mailto link.

Testing

The following simple html page when the page is served from a local running HTTP Server ( http://localhost:8080/data/test.html ) <html> <body> <a href="mailto:test.test <at> test.at">test.test <at> test.at</a> </body> </html>

Diffs

  • kdecore/kernel/kauthorized.cpp (f7d795a)

View Diff
Permalink | Reply |
headers
Rolf Eike Beer | 13 Jul 2012 00:37
Picon
Favicon

Re: Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

Am Donnerstag, 12. Juli 2012, 16:15:53 schrieb David Faure:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105395/#review15734
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Looks good. I'm curious as to why this wasn't necessary before, but anyway:
> please commit this for 4.9, obviously.

What about putting it in 4.8, too? It's also annoying there.

Eike
Permalink | Reply |
headers
David Faure | 13 Jul 2012 16:00
Picon
Favicon
Gravatar

Re: Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

On Friday 13 July 2012 00:37:49 Rolf Eike Beer wrote:
> Am Donnerstag, 12. Juli 2012, 16:15:53 schrieb David Faure:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/105395/#review15734
> > -----------------------------------------------------------
> > 
> > Ship it!
> > 
> > 
> > Looks good. I'm curious as to why this wasn't necessary before, but
> > anyway:
> > please commit this for 4.9, obviously.
> 
> What about putting it in 4.8, too? It's also annoying there.

Done.

--

-- 
David Faure, faure <at> kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
Permalink | Reply |

Gmane