| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Description
Testing
Bugs:
297209
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 2:46 a.m. Changes
Description (updated)
Testing
Bugs:
297209
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 5:41 a.m. Changes
Description
Testing
Bugs:
297209
Diffs (updated)
Screenshots (updated) |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 5:48 a.m. Changes
Description
Testing
Bugs:
297209
Diffs (updated)
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
- Konstantinos
On July 14th, 2012, 5:48 a.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 5:48 a.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
This is how it looks like over here with Oxygen: http://i46.tinypic.com/2m47rrm.pngOn July 14th, 2012, 12:18 p.m., Konstantinos Smanis wrote:
My QML knowledge is too limited to review your code, but I tested your patch and have the following remarks to make: 1) There is some flickering when hovering a menu item. Dunno if it has to do with my theme (tried Oxygen + Caledonia). 2) There is no proper '&' escaping. Ampersands are falsely treated as keyboard accelerators (the old code provisioned for this). A double ampersand is shown as a single. 3) When the menu item's text is small (~4-5 characters), the arrow is shown very close to the text. The core functionality seems to be fine, I onlyn noticed the above GUI issues.
- Konstantinos
On July 14th, 2012, 5:48 a.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 5:48 a.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
I do not see any flickering here. However, I disable several Oxygen effects here to improve performance, maybe one of them is causing your problem.On July 14th, 2012, 12:18 p.m., Konstantinos Smanis wrote:
My QML knowledge is too limited to review your code, but I tested your patch and have the following remarks to make: 1) There is some flickering when hovering a menu item. Dunno if it has to do with my theme (tried Oxygen + Caledonia). 2) There is no proper '&' escaping. Ampersands are falsely treated as keyboard accelerators (the old code provisioned for this). A double ampersand is shown as a single. 3) When the menu item's text is small (~4-5 characters), the arrow is shown very close to the text. The core functionality seems to be fine, I onlyn noticed the above GUI issues.On July 14th, 2012, 12:23 p.m., Konstantinos Smanis wrote:
This is how it looks like over here with Oxygen: http://i46.tinypic.com/2m47rrm.png
- Lamarque Vieira
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
Actually the flickering occurs even without the patch (but it's not that noticeable). It doesn't have to do with this specific patch.On July 14th, 2012, 12:18 p.m., Konstantinos Smanis wrote:
My QML knowledge is too limited to review your code, but I tested your patch and have the following remarks to make: 1) There is some flickering when hovering a menu item. Dunno if it has to do with my theme (tried Oxygen + Caledonia). 2) There is no proper '&' escaping. Ampersands are falsely treated as keyboard accelerators (the old code provisioned for this). A double ampersand is shown as a single. 3) When the menu item's text is small (~4-5 characters), the arrow is shown very close to the text. The core functionality seems to be fine, I onlyn noticed the above GUI issues.On July 14th, 2012, 12:23 p.m., Konstantinos Smanis wrote:
This is how it looks like over here with Oxygen: http://i46.tinypic.com/2m47rrm.pngOn July 14th, 2012, 6:54 p.m., Lamarque Vieira Souza wrote:
I do not see any flickering here. However, I disable several Oxygen effects here to improve performance, maybe one of them is causing your problem.
- Konstantinos
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Changes
Description
Testing
Bugs:
297209
Diffs (updated)
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
- Konstantinos
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
- Commit
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
- Commit
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
- Konstantinos
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
I will fix that tonight. I need to go now.On July 17th, 2012, 6:19 p.m., Konstantinos Smanis wrote:
I forgot to mention that the submenus should only be created if Grub2 or Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) should still be able to use '>' in the menu titles without creating submenus. See the ksmserver part of the other patch I am submitting for branch KDE/4.8 (https://git.reviewboard.kde.org/r/105563/).
- Lamarque Vieira
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
i would recommend against doing anything until the kdm patch is finalOn July 17th, 2012, 6:19 p.m., Konstantinos Smanis wrote:
I forgot to mention that the submenus should only be created if Grub2 or Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) should still be able to use '>' in the menu titles without creating submenus. See the ksmserver part of the other patch I am submitting for branch KDE/4.8 (https://git.reviewboard.kde.org/r/105563/).On July 17th, 2012, 7:18 p.m., Lamarque Vieira Souza wrote:
I will fix that tonight. I need to go now.
- Oswald
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/ |
Too late, this patch and the commit to fix the issue above are already pushed. ksmserver now works with or without the kdm patch. It will create a flat menu if the kdm patch is not applied or user is using a boot manager different from Grub2 or Burg.On July 17th, 2012, 6:19 p.m., Konstantinos Smanis wrote:
I forgot to mention that the submenus should only be created if Grub2 or Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) should still be able to use '>' in the menu titles without creating submenus. See the ksmserver part of the other patch I am submitting for branch KDE/4.8 (https://git.reviewboard.kde.org/r/105563/).On July 17th, 2012, 7:18 p.m., Lamarque Vieira Souza wrote:
I will fix that tonight. I need to go now.On July 17th, 2012, 9:04 p.m., Oswald Buddenhagen wrote:
i would recommend against doing anything until the kdm patch is final
- Lamarque Vieira
On July 14th, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
|
Review request for KDE Runtime and Konstantinos Smanis.
By Lamarque Vieira Souza.
Updated July 14, 2012, 6:53 p.m. Description
Testing
Bugs:
297209
Diffs
Screenshots |
RSS Feed