| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
| void KDialogJobUiDelegate::showErrorMessage() | |||
| static uint msgBoxDisplayed = 0; | 92KMessageBox::queuedMessageBox ( d->errorParentWidget, KMessageBox::Information, plain ); | ||
- Frank
On August 16th, 2012, 12:18 p.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 16, 2012, 12:18 p.m. Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
How about aggregating all the errors/warnings in a single dialog box as a list? E.g. the list would have fields like "message" and "file", and would allow the user to easily see all that went wrong and what files were involved. He could then select multiple entries and perform the same action on them, if applicable. E.g. if the message was "destination already exists, replace or skip?" he could select some of the entries and perform "ignore", but perform "replace" on others. The copying could continue in the background, and the replacements would be performed only once the user confirms then.On August 16th, 2012, 1:10 p.m., Frank Reininghaus wrote:
I'm afraid the users suffering from https://bugs.kde.org/show_bug.cgi?id=206500 will kill us if they get a message box for every single file. Right now, they have the option to wait until the operation is completed, then close the first (and only) message box and be happy.
kdeui/jobs/kdialogjobuidelegate.cpp (Diff revision 1) void KDialogJobUiDelegate::showErrorMessage() 92 static uint msgBoxDisplayed = 0; 92KMessageBox::queuedMessageBox ( d->errorParentWidget, KMessageBox::Information, plain );
- Ambroz
On August 16th, 2012, 12:18 p.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 16, 2012, 12:18 p.m. Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
But you can get multiple kinds of warnings during the operation. How would you separate them? You would either have to have a separate dialog for each kind of error or a very complex UI dialog. In general I like the idea of a box "These files failed to copy" (similar to the Delete Files dialog), but I think that simple 'OK' would be enough. Ideas?On August 16th, 2012, 1:10 p.m., Frank Reininghaus wrote:
I'm afraid the users suffering from https://bugs.kde.org/show_bug.cgi?id=206500 will kill us if they get a message box for every single file. Right now, they have the option to wait until the operation is completed, then close the first (and only) message box and be happy.
kdeui/jobs/kdialogjobuidelegate.cpp (Diff revision 1) void KDialogJobUiDelegate::showErrorMessage() 92 static uint msgBoxDisplayed = 0; 92KMessageBox::queuedMessageBox ( d->errorParentWidget, KMessageBox::Information, plain ); On August 16th, 2012, 1:32 p.m., Ambroz Bizjak wrote:
How about aggregating all the errors/warnings in a single dialog box as a list? E.g. the list would have fields like "message" and "file", and would allow the user to easily see all that went wrong and what files were involved. He could then select multiple entries and perform the same action on them, if applicable. E.g. if the message was "destination already exists, replace or skip?" he could select some of the entries and perform "ignore", but perform "replace" on others. The copying could continue in the background, and the replacements would be performed only once the user confirms then.
- Dan
On August 16th, 2012, 12:18 p.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 16, 2012, 12:18 p.m. Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
Yes, that's a good idea. When a file fails to copy, pop up the "These files failed to copy" dialog, but when another file fails, just add it to the list in the existing dialog. User can click "OK" which closes the dialog, and if more files fail, another one pops up. Small problem though: what happens if the user clicks OK, without noticing that another file was added to the list just before he closed the dialog? Maybe a safeguard should be added that no less than N seconds may pass from the time the last file was added to when the user clicks OK.On August 16th, 2012, 1:10 p.m., Frank Reininghaus wrote:
I'm afraid the users suffering from https://bugs.kde.org/show_bug.cgi?id=206500 will kill us if they get a message box for every single file. Right now, they have the option to wait until the operation is completed, then close the first (and only) message box and be happy.
kdeui/jobs/kdialogjobuidelegate.cpp (Diff revision 1) void KDialogJobUiDelegate::showErrorMessage() 92 static uint msgBoxDisplayed = 0; 92KMessageBox::queuedMessageBox ( d->errorParentWidget, KMessageBox::Information, plain ); On August 16th, 2012, 1:32 p.m., Ambroz Bizjak wrote:
How about aggregating all the errors/warnings in a single dialog box as a list? E.g. the list would have fields like "message" and "file", and would allow the user to easily see all that went wrong and what files were involved. He could then select multiple entries and perform the same action on them, if applicable. E.g. if the message was "destination already exists, replace or skip?" he could select some of the entries and perform "ignore", but perform "replace" on others. The copying could continue in the background, and the replacements would be performed only once the user confirms then.On August 16th, 2012, 1:43 p.m., Dan Vratil wrote:
But you can get multiple kinds of warnings during the operation. How would you separate them? You would either have to have a separate dialog for each kind of error or a very complex UI dialog. In general I like the idea of a box "These files failed to copy" (similar to the Delete Files dialog), but I think that simple 'OK' would be enough. Ideas?
- Ambroz
On August 16th, 2012, 12:18 p.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 16, 2012, 12:18 p.m. Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
Aggregating errors is part of Cyril Oblikov's SOC project already. I just asked him to aggregate warnings in that dialog too. This is a longer-term fix though.On August 16th, 2012, 1:10 p.m., Frank Reininghaus wrote:
I'm afraid the users suffering from https://bugs.kde.org/show_bug.cgi?id=206500 will kill us if they get a message box for every single file. Right now, they have the option to wait until the operation is completed, then close the first (and only) message box and be happy.
kdeui/jobs/kdialogjobuidelegate.cpp (Diff revision 1) void KDialogJobUiDelegate::showErrorMessage() 92 static uint msgBoxDisplayed = 0; 92KMessageBox::queuedMessageBox ( d->errorParentWidget, KMessageBox::Information, plain ); On August 16th, 2012, 1:32 p.m., Ambroz Bizjak wrote:
How about aggregating all the errors/warnings in a single dialog box as a list? E.g. the list would have fields like "message" and "file", and would allow the user to easily see all that went wrong and what files were involved. He could then select multiple entries and perform the same action on them, if applicable. E.g. if the message was "destination already exists, replace or skip?" he could select some of the entries and perform "ignore", but perform "replace" on others. The copying could continue in the background, and the replacements would be performed only once the user confirms then.On August 16th, 2012, 1:43 p.m., Dan Vratil wrote:
But you can get multiple kinds of warnings during the operation. How would you separate them? You would either have to have a separate dialog for each kind of error or a very complex UI dialog. In general I like the idea of a box "These files failed to copy" (similar to the Delete Files dialog), but I think that simple 'OK' would be enough. Ideas?On August 16th, 2012, 2:14 p.m., Ambroz Bizjak wrote:
Yes, that's a good idea. When a file fails to copy, pop up the "These files failed to copy" dialog, but when another file fails, just add it to the list in the existing dialog. User can click "OK" which closes the dialog, and if more files fail, another one pops up. Small problem though: what happens if the user clicks OK, without noticing that another file was added to the list just before he closed the dialog? Maybe a safeguard should be added that no less than N seconds may pass from the time the last file was added to when the user clicks OK.
- David
On August 16th, 2012, 12:18 p.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 16, 2012, 12:18 p.m. Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
| void KDialogJobUiDelegate::showErrorMessage() | |||
| static uint msgBoxDisplayed = 0; | 92KMessageBox::queuedMessageBox ( d->errorParentWidget, KMessageBox::Information, plain ); | ||
In fact, no space within the parenthesis either, but you couldn't guess that: existing code doesn't follow the kdelibs coding style. When writing new code, no spaces within (...).
| void ListJobPrivate::gotEntries(KIO::Job *, const KIO::UDSEntryList& list ) | |||
| 2620 | // Left's emit a signal about this though | ||
- David
On August 16th, 2012, 12:18 p.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 16, 2012, 12:18 p.m. Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 22, 2012, 8:24 a.m. Description
Diffs (updated)
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
Ship it!
Ship It!- David
On August 22nd, 2012, 8:24 a.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 22, 2012, 8:24 a.m. Description
Diffs
|
| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/ |
- Commit
On August 22nd, 2012, 8:24 a.m., Dan Vratil wrote:
|
Review request for kdelibs and David Faure.
By Dan Vratil.
Updated Aug. 22, 2012, 8:24 a.m. Description
Diffs
|
RSS Feed