Tadeusz Andrzej Kadlubowski | 28 Feb 11:27 2010
Picon

Review Request: Rename magazynier to ksokoban


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3075/
-----------------------------------------------------------

Review request for KDE Games and Tadeusz Andrzej Kadlubowski.

Summary
-------

Well, magazynier, which is a sokoban game for KDE4, has a chance to be included in KDE SC 4.5, though it still
needs some work. 

In KDE3 times we had a sokoban game that was named ksokoban. Magazynier is a ksokoban replacement
functionality-wise, though it is not a direct source code port. Many people still remember ksokoban
brand. How about renaming magazynier to ksokoban and bumping up the version number?

(if this rudimentary patch is accepted, I will update the rest of the magazynier sources, contact
translators etc.m

Diffs
-----

  /trunk/playground/games/magazynier/magazynier.cpp 1072693 

Diff: http://reviewboard.kde.org/r/3075/diff

Testing
-------
(Continue reading)

Johannes Obermayr | 28 Feb 22:06 2010
Picon
Picon

Re: Review Request: Rename magazynier to ksokoban


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3075/#review4319
-----------------------------------------------------------

Please change also last line in Messages.sh:
$podir/magazynier.pot -> $podir/ksokoban.pot

- Johannes

On 2010-02-28 10:27:11, Tadeusz Andrzej Kadlubowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3075/
> -----------------------------------------------------------
> 
> (Updated 2010-02-28 10:27:11)
> 
> 
> Review request for KDE Games and Tadeusz Andrzej Kadlubowski.
> 
> 
> Summary
> -------
> 
> Well, magazynier, which is a sokoban game for KDE4, has a chance to be included in KDE SC 4.5, though it still
needs some work. 
> 
(Continue reading)

Rex Dieter | 1 Mar 19:54 2010

Re: Review Request: Rename magazynier to ksokoban


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3075/#review4330
-----------------------------------------------------------

My "trademarks!" spidey-sense started tingling.  http://www.sokoban.jp/ suggests that sokoban is
indeed trademarked, best avoid using that name.  We just went through trouble with kbattleship, ktron,
please don't repeat history here.

- Rex

On 2010-02-28 10:27:11, Tadeusz Andrzej Kadlubowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3075/
> -----------------------------------------------------------
> 
> (Updated 2010-02-28 10:27:11)
> 
> 
> Review request for KDE Games and Tadeusz Andrzej Kadlubowski.
> 
> 
> Summary
> -------
> 
> Well, magazynier, which is a sokoban game for KDE4, has a chance to be included in KDE SC 4.5, though it still
needs some work. 
(Continue reading)

Ian Wadham | 1 Mar 07:30 2010
Picon

Re: Review Request: Rename magazynier to ksokoban


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3075/#review4321
-----------------------------------------------------------

Great idea to retain the old name, but I think it needs to be KSokoban (capital K and S).

Ian Wadham.

- Ian

On 2010-02-28 10:27:11, Tadeusz Andrzej Kadlubowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3075/
> -----------------------------------------------------------
> 
> (Updated 2010-02-28 10:27:11)
> 
> 
> Review request for KDE Games and Tadeusz Andrzej Kadlubowski.
> 
> 
> Summary
> -------
> 
> Well, magazynier, which is a sokoban game for KDE4, has a chance to be included in KDE SC 4.5, though it still
needs some work. 
(Continue reading)


Gmane