headers
Thomas Zander | 9 Jul 2011 15:32
Picon
Favicon

Review Request: Make kword WP import filter compile for me.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101901/

Review request for KOffice.
By Thomas Zander.

Description

I got a compiler error on ubuntu (11.04 32 bit) due to a method signature difference; the code used size_t and the libwpd header file uses unsigned long. Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method uses unsigned long. I want to update koffice to follow.

Diffs

  • filters/kword/wordperfect/import/wpimport.cc (8c8b8e3)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the
calligra-devel <at> kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org.
Permalink | Reply |
headers
Robert Mathias Marmorstein | 9 Jul 2011 16:42
Picon
Favicon
Gravatar

Re: Review Request: Make kword WP import filter compile for me.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101901/

Ship it!

Looks good!

- Robert Mathias


On July 9th, 2011, 1:32 p.m., Thomas Zander wrote:

Review request for KOffice.
By Thomas Zander.

Updated July 9, 2011, 1:32 p.m.

Description

I got a compiler error on ubuntu (11.04 32 bit) due to a method signature difference; the code used size_t and the libwpd header file uses unsigned long. Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method uses unsigned long. I want to update koffice to follow.

Diffs

  • filters/kword/wordperfect/import/wpimport.cc (8c8b8e3)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the
calligra-devel <at> kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org.
Permalink | Reply |

Gmane