Chris Smith | 13 Mar 2012 05:21

Review Request: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104252/

Review request for KOffice.

By Chris Smith.

Description

Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

Diffs

kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

headers

Thomas Zander | 13 Mar 2012 19:35

Re: Review Request: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104252/

Ship it!

Apart from the comment, this is a good cleanup. Thanks for that! Do you have a kde account? If so, please feel free to push this commit. If not, let us know so one of us can push it for you.

kword/part/KWApplicationConfig.cpp (Diff revision 1) 120 87

void KWApplicationConfig::load(KWDocument *document)
KConfigGroup spelling = KoGlobal::kofficeConfig()->group("Spelling");	KConfigGroup spelling = KoGlobal::kofficeConfig()->group("Spelling");

The spelling variable now is not going to be used either, so I suggest removing this line and the comment above it too.

- Thomas

On March 13th, 2012, 4:21 a.m., Chris Smith wrote:

Review request for KOffice.

By Chris Smith.

Updated March 13, 2012, 4:21 a.m.

Description

Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

Diffs

kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

headers

Albert Astals Cid | 7 Feb 2013 22:25

Re: Review Request 104252: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104252/

I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?

- Albert

On March 13th, 2012, 4:21 a.m. UTC, Chris Smith wrote:

Review request for KOffice.

By Chris Smith.

Updated March 13, 2012, 4:21 a.m.

Description

Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

Diffs

kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

headers

Albert Astals Cid | 5 Apr 2013 22:03

Re: Review Request 104252: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104252/

This change has been discarded.

Review request for KOffice.

By Chris Smith.

Updated April 5, 2013, 8:03 p.m.

Description

Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make warnings.

Diffs

kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel