headers
Robert Mathias Marmorstein | 13 Mar 2012 19:53
Picon
Favicon
Gravatar

Review Request: Add parentheses around instatiation of object to avoid ambiguity

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104262/

Review request for KOffice.
By Robert Mathias Marmorstein.

Description

The clang compiler won't build the unit test without these parentheses claiming that it doesn't know how to disambiguate a function call. I'm not sure I understand exactly why, but adding the parens fixes things so that the unit test can build and doesn't have any other negative effect.

Testing

Compiled and ran unit tests with both gcc and clang. All tests still pass (now with both compilers).

Diffs

  • kcells/tests/TestLogicFunctions.cpp (d49aeda)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
Permalink | Reply |
headers
Thomas Zander | 13 Mar 2012 20:14
Picon
Favicon

Re: Review Request: Add parentheses around instatiation of object to avoid ambiguity

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104262/

Ship it!

Can't imagine that having any negative side effects, so if it fixes the problem, then ship it :)

- Thomas


On March 13th, 2012, 6:53 p.m., Robert Mathias Marmorstein wrote:

Review request for KOffice.
By Robert Mathias Marmorstein.

Updated March 13, 2012, 6:53 p.m.

Description

The clang compiler won't build the unit test without these parentheses claiming that it doesn't know how to disambiguate a function call. I'm not sure I understand exactly why, but adding the parens fixes things so that the unit test can build and doesn't have any other negative effect.

Testing

Compiled and ran unit tests with both gcc and clang. All tests still pass (now with both compilers).

Diffs

  • kcells/tests/TestLogicFunctions.cpp (d49aeda)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
Permalink | Reply |

Gmane